From 4ab3b7458aa06e05951d706b6cedba8d92755a2d Mon Sep 17 00:00:00 2001 From: strtgbb <146047128+strtgbb@users.noreply.github.com> Date: Tue, 30 Sep 2025 14:34:48 -0400 Subject: [PATCH 1/7] disable cache in that workflow --- .github/workflows/release_builds.yml | 21 --------------------- ci/workflows/release_builds.py | 4 ++-- 2 files changed, 2 insertions(+), 23 deletions(-) diff --git a/.github/workflows/release_builds.yml b/.github/workflows/release_builds.yml index 75ab0f1df4cc..abcbf54f2202 100644 --- a/.github/workflows/release_builds.yml +++ b/.github/workflows/release_builds.yml @@ -89,7 +89,6 @@ jobs: dockers_build_amd: runs-on: [self-hosted, altinity-on-demand, altinity-style-checker] needs: [config_workflow] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'RG9ja2VycyBCdWlsZCAoYW1kKQ==') }} name: "Dockers Build (amd)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -137,7 +136,6 @@ jobs: dockers_build_arm: runs-on: [self-hosted, altinity-on-demand, altinity-style-checker-aarch64] needs: [config_workflow] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'RG9ja2VycyBCdWlsZCAoYXJtKQ==') }} name: "Dockers Build (arm)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -185,7 +183,6 @@ jobs: build_amd_debug: runs-on: [self-hosted, altinity-on-demand, altinity-builder] needs: [config_workflow, dockers_build_amd, dockers_build_arm] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'QnVpbGQgKGFtZF9kZWJ1Zyk=') }} name: "Build (amd_debug)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -233,7 +230,6 @@ jobs: build_amd_release: runs-on: [self-hosted, altinity-on-demand, altinity-builder] needs: [config_workflow, dockers_build_amd, dockers_build_arm] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'QnVpbGQgKGFtZF9yZWxlYXNlKQ==') }} name: "Build (amd_release)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -281,7 +277,6 @@ jobs: build_amd_asan: runs-on: [self-hosted, altinity-on-demand, altinity-builder] needs: [config_workflow, dockers_build_amd, dockers_build_arm] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'QnVpbGQgKGFtZF9hc2FuKQ==') }} name: "Build (amd_asan)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -329,7 +324,6 @@ jobs: build_amd_tsan: runs-on: [self-hosted, altinity-on-demand, altinity-builder] needs: [config_workflow, dockers_build_amd, dockers_build_arm] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'QnVpbGQgKGFtZF90c2FuKQ==') }} name: "Build (amd_tsan)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -377,7 +371,6 @@ jobs: build_amd_msan: runs-on: [self-hosted, altinity-on-demand, altinity-builder] needs: [config_workflow, dockers_build_amd, dockers_build_arm] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'QnVpbGQgKGFtZF9tc2FuKQ==') }} name: "Build (amd_msan)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -425,7 +418,6 @@ jobs: build_amd_ubsan: runs-on: [self-hosted, altinity-on-demand, altinity-builder] needs: [config_workflow, dockers_build_amd, dockers_build_arm] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'QnVpbGQgKGFtZF91YnNhbik=') }} name: "Build (amd_ubsan)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -473,7 +465,6 @@ jobs: build_amd_binary: runs-on: [self-hosted, altinity-on-demand, altinity-builder] needs: [config_workflow, dockers_build_amd, dockers_build_arm] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'QnVpbGQgKGFtZF9iaW5hcnkp') }} name: "Build (amd_binary)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -521,7 +512,6 @@ jobs: build_arm_release: runs-on: [self-hosted, altinity-on-demand, altinity-builder] needs: [config_workflow, dockers_build_amd, dockers_build_arm] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'QnVpbGQgKGFybV9yZWxlYXNlKQ==') }} name: "Build (arm_release)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -569,7 +559,6 @@ jobs: build_arm_binary: runs-on: [self-hosted, altinity-on-demand, altinity-builder] needs: [config_workflow, dockers_build_amd, dockers_build_arm] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'QnVpbGQgKGFybV9iaW5hcnkp') }} name: "Build (arm_binary)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -617,7 +606,6 @@ jobs: docker_server_image: runs-on: [self-hosted, altinity-on-demand, altinity-style-checker] needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_release, build_arm_release] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'RG9ja2VyIHNlcnZlciBpbWFnZQ==') }} name: "Docker server image" outputs: data: ${{ steps.run.outputs.DATA }} @@ -665,7 +653,6 @@ jobs: docker_keeper_image: runs-on: [self-hosted, altinity-on-demand, altinity-style-checker] needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_release, build_arm_release] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'RG9ja2VyIGtlZXBlciBpbWFnZQ==') }} name: "Docker keeper image" outputs: data: ${{ steps.run.outputs.DATA }} @@ -713,7 +700,6 @@ jobs: install_packages_amd_release: runs-on: [self-hosted, altinity-on-demand, altinity-func-tester] needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_release] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'SW5zdGFsbCBwYWNrYWdlcyAoYW1kX3JlbGVhc2Up') }} name: "Install packages (amd_release)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -761,7 +747,6 @@ jobs: install_packages_arm_release: runs-on: [self-hosted, altinity-on-demand, altinity-func-tester-aarch64] needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_arm_release] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'SW5zdGFsbCBwYWNrYWdlcyAoYXJtX3JlbGVhc2Up') }} name: "Install packages (arm_release)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -809,7 +794,6 @@ jobs: stateless_tests_amd_binary_old_analyzer_s3_storage_databasereplicated_parallel: runs-on: [self-hosted, altinity-on-demand, altinity-func-tester] needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_binary] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'U3RhdGVsZXNzIHRlc3RzIChhbWRfYmluYXJ5LCBvbGQgYW5hbHl6ZXIsIHMzIHN0b3JhZ2UsIERhdGFiYXNlUmVwbGljYXRlZCwgcGFyYWxsZWwp') }} name: "Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, parallel)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -857,7 +841,6 @@ jobs: stateless_tests_amd_binary_old_analyzer_s3_storage_databasereplicated_sequential: runs-on: [self-hosted, altinity-on-demand, altinity-func-tester] needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_binary] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'U3RhdGVsZXNzIHRlc3RzIChhbWRfYmluYXJ5LCBvbGQgYW5hbHl6ZXIsIHMzIHN0b3JhZ2UsIERhdGFiYXNlUmVwbGljYXRlZCwgc2VxdWVudGlhbCk=') }} name: "Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, sequential)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -905,7 +888,6 @@ jobs: stateless_tests_amd_binary_parallelreplicas_s3_storage_parallel: runs-on: [self-hosted, altinity-on-demand, altinity-func-tester] needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_binary] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'U3RhdGVsZXNzIHRlc3RzIChhbWRfYmluYXJ5LCBQYXJhbGxlbFJlcGxpY2FzLCBzMyBzdG9yYWdlLCBwYXJhbGxlbCk=') }} name: "Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -953,7 +935,6 @@ jobs: stateless_tests_amd_binary_parallelreplicas_s3_storage_sequential: runs-on: [self-hosted, altinity-on-demand, altinity-func-tester] needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_binary] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'U3RhdGVsZXNzIHRlc3RzIChhbWRfYmluYXJ5LCBQYXJhbGxlbFJlcGxpY2FzLCBzMyBzdG9yYWdlLCBzZXF1ZW50aWFsKQ==') }} name: "Stateless tests (amd_binary, ParallelReplicas, s3 storage, sequential)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -1001,7 +982,6 @@ jobs: stateless_tests_arm_binary_parallel: runs-on: [self-hosted, altinity-on-demand, altinity-func-tester-aarch64] needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_arm_binary] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'U3RhdGVsZXNzIHRlc3RzIChhcm1fYmluYXJ5LCBwYXJhbGxlbCk=') }} name: "Stateless tests (arm_binary, parallel)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -1049,7 +1029,6 @@ jobs: stateless_tests_arm_binary_sequential: runs-on: [self-hosted, altinity-on-demand, altinity-func-tester-aarch64] needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_arm_binary] - if: ${{ !failure() && !cancelled() && !contains(fromJson(needs.config_workflow.outputs.data).cache_success_base64, 'U3RhdGVsZXNzIHRlc3RzIChhcm1fYmluYXJ5LCBzZXF1ZW50aWFsKQ==') }} name: "Stateless tests (arm_binary, sequential)" outputs: data: ${{ steps.run.outputs.DATA }} diff --git a/ci/workflows/release_builds.py b/ci/workflows/release_builds.py index 826ed0e7b3a9..d491dc51127c 100644 --- a/ci/workflows/release_builds.py +++ b/ci/workflows/release_builds.py @@ -34,8 +34,8 @@ ], dockers=DOCKERS, secrets=SECRETS, - enable_job_filtering_by_changes=True, - enable_cache=True, + enable_job_filtering_by_changes=False, + enable_cache=False, enable_report=True, enable_cidb=True, enable_commit_status_on_failure=True, From 46f36fce5918f0610023d7066691b10cf87b3911 Mon Sep 17 00:00:00 2001 From: strtgbb <146047128+strtgbb@users.noreply.github.com> Date: Wed, 1 Oct 2025 09:34:51 -0400 Subject: [PATCH 2/7] fast builds workflow should perform essential builds first --- ci/workflows/release_builds.py | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/ci/workflows/release_builds.py b/ci/workflows/release_builds.py index d491dc51127c..2e248827bec0 100644 --- a/ci/workflows/release_builds.py +++ b/ci/workflows/release_builds.py @@ -10,11 +10,28 @@ if "coverage" not in job.name ] +PRIORITY_BUILD_JOBS = [ + job.name + for job in JobConfigs.build_jobs + if any( + substr in job.name + for substr in ( + "binary", + "release", + ) + ) +] + workflow = Workflow.Config( name="Release Builds", event=Workflow.Event.DISPATCH, jobs=[ - *builds_for_release_branch, + *[ + job.set_dependency( + PRIORITY_BUILD_JOBS if job.name not in PRIORITY_BUILD_JOBS else [] + ) + for job in builds_for_release_branch + ], JobConfigs.docker_sever, JobConfigs.docker_keeper, *JobConfigs.install_check_master_jobs, From a74635867f9fed439ae6b03ff2cd2bdcac796860 Mon Sep 17 00:00:00 2001 From: strtgbb <146047128+strtgbb@users.noreply.github.com> Date: Wed, 1 Oct 2025 09:42:51 -0400 Subject: [PATCH 3/7] remove unused prehooks --- ci/workflows/release_builds.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ci/workflows/release_builds.py b/ci/workflows/release_builds.py index 2e248827bec0..46903c533907 100644 --- a/ci/workflows/release_builds.py +++ b/ci/workflows/release_builds.py @@ -57,8 +57,8 @@ enable_cidb=True, enable_commit_status_on_failure=True, pre_hooks=[ - "python3 ./ci/jobs/scripts/workflow_hooks/store_data.py", - "python3 ./ci/jobs/scripts/workflow_hooks/version_log.py", + # "python3 ./ci/jobs/scripts/workflow_hooks/store_data.py", + # "python3 ./ci/jobs/scripts/workflow_hooks/version_log.py", ], workflow_filter_hooks=[should_skip_job], post_hooks=[], From baf9c0b64027e7e27c9ceb6060879438f42df2ff Mon Sep 17 00:00:00 2001 From: strtgbb <146047128+strtgbb@users.noreply.github.com> Date: Wed, 1 Oct 2025 10:03:12 -0400 Subject: [PATCH 4/7] forgot to regenerate workflows --- .github/workflows/release_builds.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/release_builds.yml b/.github/workflows/release_builds.yml index abcbf54f2202..cc34e50f8879 100644 --- a/.github/workflows/release_builds.yml +++ b/.github/workflows/release_builds.yml @@ -182,7 +182,7 @@ jobs: build_amd_debug: runs-on: [self-hosted, altinity-on-demand, altinity-builder] - needs: [config_workflow, dockers_build_amd, dockers_build_arm] + needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_release, build_amd_binary, build_arm_release, build_arm_binary] name: "Build (amd_debug)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -276,7 +276,7 @@ jobs: build_amd_asan: runs-on: [self-hosted, altinity-on-demand, altinity-builder] - needs: [config_workflow, dockers_build_amd, dockers_build_arm] + needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_release, build_amd_binary, build_arm_release, build_arm_binary] name: "Build (amd_asan)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -323,7 +323,7 @@ jobs: build_amd_tsan: runs-on: [self-hosted, altinity-on-demand, altinity-builder] - needs: [config_workflow, dockers_build_amd, dockers_build_arm] + needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_release, build_amd_binary, build_arm_release, build_arm_binary] name: "Build (amd_tsan)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -370,7 +370,7 @@ jobs: build_amd_msan: runs-on: [self-hosted, altinity-on-demand, altinity-builder] - needs: [config_workflow, dockers_build_amd, dockers_build_arm] + needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_release, build_amd_binary, build_arm_release, build_arm_binary] name: "Build (amd_msan)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -417,7 +417,7 @@ jobs: build_amd_ubsan: runs-on: [self-hosted, altinity-on-demand, altinity-builder] - needs: [config_workflow, dockers_build_amd, dockers_build_arm] + needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_release, build_amd_binary, build_arm_release, build_arm_binary] name: "Build (amd_ubsan)" outputs: data: ${{ steps.run.outputs.DATA }} From 511ff9935a5fe08e1347a90427302f1359d18508 Mon Sep 17 00:00:00 2001 From: strtgbb <146047128+strtgbb@users.noreply.github.com> Date: Wed, 1 Oct 2025 12:46:11 -0400 Subject: [PATCH 5/7] partially re-enable version_log hook --- ci/jobs/scripts/workflow_hooks/version_log.py | 35 ++++++++++--------- ci/workflows/release_builds.py | 2 +- 2 files changed, 19 insertions(+), 18 deletions(-) diff --git a/ci/jobs/scripts/workflow_hooks/version_log.py b/ci/jobs/scripts/workflow_hooks/version_log.py index a4ed6e9b248b..8d3821e07dfc 100644 --- a/ci/jobs/scripts/workflow_hooks/version_log.py +++ b/ci/jobs/scripts/workflow_hooks/version_log.py @@ -8,23 +8,24 @@ def _add_build_to_version_history(): - info = Info() - Shell.check( - f"git rev-parse --is-shallow-repository | grep -q true && git fetch --unshallow --prune --no-recurse-submodules --filter=tree:0 origin {info.git_branch} ||:" - ) - commit_parents = Shell.get_output("git log --format=%P -n 1").split(" ") - data = { - "check_start_time": datetime.now().strftime("%Y-%m-%d %H:%M:%S"), - "pull_request_number": info.pr_number, - "pull_request_url": info.pr_url, - "commit_sha": info.sha, - "commit_url": info.commit_url, - "parent_commits_sha": commit_parents, - "version": CHVersion.get_version(), - "git_ref": info.git_branch, - } - print(f"Update version log: [{data}]") - CIDBCluster().insert_json(table="version_history", json_str=data) + # info = Info() + # Shell.check( + # f"git rev-parse --is-shallow-repository | grep -q true && git fetch --unshallow --prune --no-recurse-submodules --filter=tree:0 origin {info.git_branch} ||:" + # ) + # commit_parents = Shell.get_output("git log --format=%P -n 1").split(" ") + # data = { + # "check_start_time": datetime.now().strftime("%Y-%m-%d %H:%M:%S"), + # "pull_request_number": info.pr_number, + # "pull_request_url": info.pr_url, + # "commit_sha": info.sha, + # "commit_url": info.commit_url, + # "parent_commits_sha": commit_parents, + # "version": CHVersion.get_version(), + # "git_ref": info.git_branch, + # } + # print(f"Update version log: [{data}]") + # CIDBCluster().insert_json(table="version_history", json_str=data) + # stores actual version data in pipline storage, to be used by jobs that need it CHVersion.store_version_data_in_ci_pipeline() diff --git a/ci/workflows/release_builds.py b/ci/workflows/release_builds.py index 46903c533907..0ea4751b8fa4 100644 --- a/ci/workflows/release_builds.py +++ b/ci/workflows/release_builds.py @@ -58,7 +58,7 @@ enable_commit_status_on_failure=True, pre_hooks=[ # "python3 ./ci/jobs/scripts/workflow_hooks/store_data.py", - # "python3 ./ci/jobs/scripts/workflow_hooks/version_log.py", + "python3 ./ci/jobs/scripts/workflow_hooks/version_log.py", ], workflow_filter_hooks=[should_skip_job], post_hooks=[], From 90bc040c030333b07bc03dd1d6455407fd583b6f Mon Sep 17 00:00:00 2001 From: strtgbb <146047128+strtgbb@users.noreply.github.com> Date: Wed, 1 Oct 2025 15:21:27 -0400 Subject: [PATCH 6/7] adjust blocking jobs --- .github/workflows/release_builds.yml | 10 +++++----- ci/workflows/release_builds.py | 16 +++++++--------- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/.github/workflows/release_builds.yml b/.github/workflows/release_builds.yml index cc34e50f8879..7136bcdbe4a2 100644 --- a/.github/workflows/release_builds.yml +++ b/.github/workflows/release_builds.yml @@ -182,7 +182,7 @@ jobs: build_amd_debug: runs-on: [self-hosted, altinity-on-demand, altinity-builder] - needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_release, build_amd_binary, build_arm_release, build_arm_binary] + needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_binary, build_arm_binary] name: "Build (amd_debug)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -276,7 +276,7 @@ jobs: build_amd_asan: runs-on: [self-hosted, altinity-on-demand, altinity-builder] - needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_release, build_amd_binary, build_arm_release, build_arm_binary] + needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_binary, build_arm_binary] name: "Build (amd_asan)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -323,7 +323,7 @@ jobs: build_amd_tsan: runs-on: [self-hosted, altinity-on-demand, altinity-builder] - needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_release, build_amd_binary, build_arm_release, build_arm_binary] + needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_binary, build_arm_binary] name: "Build (amd_tsan)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -370,7 +370,7 @@ jobs: build_amd_msan: runs-on: [self-hosted, altinity-on-demand, altinity-builder] - needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_release, build_amd_binary, build_arm_release, build_arm_binary] + needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_binary, build_arm_binary] name: "Build (amd_msan)" outputs: data: ${{ steps.run.outputs.DATA }} @@ -417,7 +417,7 @@ jobs: build_amd_ubsan: runs-on: [self-hosted, altinity-on-demand, altinity-builder] - needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_release, build_amd_binary, build_arm_release, build_arm_binary] + needs: [config_workflow, dockers_build_amd, dockers_build_arm, build_amd_binary, build_arm_binary] name: "Build (amd_ubsan)" outputs: data: ${{ steps.run.outputs.DATA }} diff --git a/ci/workflows/release_builds.py b/ci/workflows/release_builds.py index 0ea4751b8fa4..6092df1527c6 100644 --- a/ci/workflows/release_builds.py +++ b/ci/workflows/release_builds.py @@ -10,16 +10,12 @@ if "coverage" not in job.name ] -PRIORITY_BUILD_JOBS = [ +# Make sure that builds that get tested are built first +# Note that the release build job should not block or be blocked, it is long and it's dependencies are fast. +BLOCKING_BUILD_JOBS = [ job.name for job in JobConfigs.build_jobs - if any( - substr in job.name - for substr in ( - "binary", - "release", - ) - ) + if any(substr in job.name for substr in ["binary"]) ] workflow = Workflow.Config( @@ -28,7 +24,9 @@ jobs=[ *[ job.set_dependency( - PRIORITY_BUILD_JOBS if job.name not in PRIORITY_BUILD_JOBS else [] + BLOCKING_BUILD_JOBS + if job.name not in BLOCKING_BUILD_JOBS and "release" not in job.name + else [] ) for job in builds_for_release_branch ], From 30223739122a62d5e93f820abe9d5acada0feb21 Mon Sep 17 00:00:00 2001 From: strtgbb <146047128+strtgbb@users.noreply.github.com> Date: Thu, 16 Oct 2025 12:56:15 -0400 Subject: [PATCH 7/7] fixx fast build workflow: re-enable store_data, version_log relies on a side effect --- ci/workflows/release_builds.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/workflows/release_builds.py b/ci/workflows/release_builds.py index 6092df1527c6..621f7ec51d37 100644 --- a/ci/workflows/release_builds.py +++ b/ci/workflows/release_builds.py @@ -55,7 +55,7 @@ enable_cidb=True, enable_commit_status_on_failure=True, pre_hooks=[ - # "python3 ./ci/jobs/scripts/workflow_hooks/store_data.py", + "python3 ./ci/jobs/scripts/workflow_hooks/store_data.py", "python3 ./ci/jobs/scripts/workflow_hooks/version_log.py", ], workflow_filter_hooks=[should_skip_job],