Removed some synchronized

Signed-off-by: Prabhu Subramanian <[email protected]>

Author: prabhu

build.sbt

@@ -1,6 +1,6 @@
 name := "overflowdb2"
 ThisBuild / organization := "io.appthreat"
-ThisBuild / version      := "1.0.2"
+ThisBuild / version      := "2.0.0"
 ThisBuild / scalaVersion := "3.6.4"
 publish / skip := true
 

core/src/main/java/overflowdb/NodeDb.java

@@ -111,7 +111,7 @@ public Map<String, Object> propertiesMapForStorage() {
 
     for (String propertyKey : propertyKeys()) {
       final Object value = property(propertyKey);
-      /** note: not differentiating `null` and `default value` is a bug - we won't fix it for now, but want to state that as a fact here... */
+      /* note: not differentiating `null` and `default value` is a bug - we won't fix it for now, but want to state that as a fact here... */
       if (value != null && !value.equals(propertyDefaultValue(propertyKey))) results.put(propertyKey, value);
     }
 
@@ -595,7 +595,7 @@ public final <A extends Node> Iterator<A> createAdjacentNodeIteratorByOffSet(int
 
   /* Simplify hoisting of string lookups.
    * n.b. `final` so that the JIT compiler can inline it */
-  public final <A extends Node> scala.collection.Iterator<? extends Object> createAdjacentNodeScalaIteratorByOffSet(int offsetPos) {
+  public final <A extends Node> scala.collection.Iterator<?> createAdjacentNodeScalaIteratorByOffSet(int offsetPos) {
     AdjacentNodes adjacentNodesTmp = this.adjacentNodes;
     if (offsetPos != -1) {
       int start = startIndex(adjacentNodesTmp, offsetPos);

core/src/main/java/overflowdb/NodeRef.java

@@ -93,7 +93,7 @@ public final N get() {
   }
 
   /** deserialize node from disk, synchronized to ensure this only happens once in a multi-threaded setup */
-  private final synchronized N getSynchronized() throws IOException {
+  private synchronized N getSynchronized() throws IOException {
     final N ref = node;
     /* checking again, in case another thread came here first and deserialized the node from disk */
     if (ref != null) {

core/src/main/java/overflowdb/storage/OdbStorage.java

@@ -135,21 +135,21 @@ public Set<Map.Entry<Long, byte[]>> allNodes() {
     return getNodesMVMap().entrySet();
   }
 
-  public synchronized MVMap<Long, byte[]> getNodesMVMap() {
+  public MVMap<Long, byte[]> getNodesMVMap() {
     ensureMVStoreAvailable();
     if (nodesMVMap == null)
       nodesMVMap = mvstore.openMap("nodes");
     return nodesMVMap;
   }
 
-  public synchronized MVMap<String, String> getMetaDataMVMap() {
+  public MVMap<String, String> getMetaDataMVMap() {
     ensureMVStoreAvailable();
     if (metadataMVMap == null)
       metadataMVMap = mvstore.openMap("metadata");
     return metadataMVMap;
   }
 
-  public synchronized MVMap<String, Integer> getStringToIntMappings() {
+  public MVMap<String, Integer> getStringToIntMappings() {
     ensureMVStoreAvailable();
     if (stringToIntMappings == null)
       stringToIntMappings = mvstore.openMap("stringToIntMappings");
@@ -209,7 +209,7 @@ private void ensureMVStoreAvailable() {
 
   private MVStore initializeMVStore() {
     MVStore.Builder builder = new MVStore.Builder()
-        .autoCommitBufferSize(1024 * 8)
+        .autoCommitBufferSize(1024 * 64)
         .compress()
         .autoCommitDisabled();
 

core/src/main/java/overflowdb/util/NodesList.java

@@ -223,7 +223,7 @@ public int cardinality(String label) {
       return 0;
   }
 
-  public synchronized void persistAll(NodesWriter nodesWriter) {
+  public void persistAll(NodesWriter nodesWriter) {
     nodesWriter.writeAndClearBatched(Arrays.spliterator(nodes), nodes.length);
   }
 

traversal/src/main/scala/overflowdb/algorithm/DependencySequencer.scala

@@ -26,7 +26,7 @@ object DependencySequencer:
       accumulator: Seq[Set[A]],
       visited: Set[A]
     ): Seq[Set[A]] =
-        if nodes.size == 0 then
+        if nodes.isEmpty then
             accumulator
         else
             val getParents = implicitly[GetParents[A]]