update segment serializer to handle path file upload. Remove unnecesary SegmentListSerializer and replace it's usage with SegmentSerializer

Author: jirivrany

cesnet_service_path_plugin/api/serializers/segment.py

@@ -10,9 +10,12 @@
 from cesnet_service_path_plugin.models.segment import Segment
 from cesnet_service_path_plugin.utils import export_segment_paths_as_geojson
 
+from cesnet_service_path_plugin.utils import process_path_data, determine_file_format_from_extension
+from django.core.exceptions import ValidationError as DjangoValidationError
+
 
 class SegmentSerializer(NetBoxModelSerializer):
-    """Default serializer Segment - excludes heavy geometry fields"""
+    """Default serializer Segment - now with file upload support"""
 
     url = serializers.HyperlinkedIdentityField(view_name="plugins-api:cesnet_service_path_plugin-api:segment-detail")
     provider = ProviderSerializer(required=True, nested=True)
@@ -22,6 +25,13 @@ class SegmentSerializer(NetBoxModelSerializer):
     location_b = LocationSerializer(required=True, nested=True)
     circuits = CircuitSerializer(required=False, many=True, nested=True)
 
+    # Add file upload field
+    path_file = serializers.FileField(
+        required=False,
+        write_only=True,  # Only for input, not included in output
+        help_text="Upload a file containing the path geometry. Supported formats: GeoJSON (.geojson, .json), KML (.kml), KMZ (.kmz)",
+    )
+
     # Only include lightweight path info
     has_path_data = serializers.SerializerMethodField(read_only=True)
 
@@ -50,6 +60,7 @@ class Meta:
             "path_source_format",
             "path_notes",
             "has_path_data",
+            "path_file",  # Add the file field
             "tags",
         )
         brief_fields = (
@@ -65,6 +76,64 @@ class Meta:
     def get_has_path_data(self, obj):
         return obj.has_path_data()
 
+    def update(self, instance, validated_data):
+        """Handle file upload during update"""
+        path_file = validated_data.pop("path_file", None)
+
+        # Update other fields first
+        instance = super().update(instance, validated_data)
+
+        # Process uploaded file if provided
+        if path_file:
+            try:
+                # Process the uploaded file using existing utility functions
+                file_format = determine_file_format_from_extension(path_file.name)
+                path_geometry = process_path_data(path_file, file_format)
+
+                # Update instance with processed geometry
+                instance.path_geometry = path_geometry
+                instance.path_source_format = file_format
+                # path_length_km will be auto-calculated in the model's save method
+                instance.save()
+
+            except DjangoValidationError as e:
+                raise serializers.ValidationError(f"Path file error: {str(e)}")
+            except Exception as e:
+                raise serializers.ValidationError(f"Error processing file '{path_file.name}': {str(e)}")
+
+        return instance
+
+    def create(self, validated_data):
+        """Handle file upload during creation"""
+        path_file = validated_data.pop("path_file", None)
+
+        # Create instance without path data first
+        instance = super().create(validated_data)
+
+        # Process uploaded file if provided
+        if path_file:
+            try:
+                # Process the uploaded file using existing utility functions
+                file_format = determine_file_format_from_extension(path_file.name)
+                path_geometry = process_path_data(path_file, file_format)
+
+                # Update instance with processed geometry
+                instance.path_geometry = path_geometry
+                instance.path_source_format = file_format
+                # path_length_km will be auto-calculated in the model's save method
+                instance.save()
+
+            except DjangoValidationError as e:
+                # Clean up created instance if path processing fails
+                instance.delete()
+                raise serializers.ValidationError(f"Path file error: {str(e)}")
+            except Exception as e:
+                # Clean up created instance if path processing fails
+                instance.delete()
+                raise serializers.ValidationError(f"Error processing file '{path_file.name}': {str(e)}")
+
+        return instance
+
 
 class SegmentListSerializer(NetBoxModelSerializer):
     """Lightweight serializer for list views - excludes heavy geometry fields"""

cesnet_service_path_plugin/api/serializers/segment_circuit_mapping.py

@@ -1,7 +1,6 @@
 from rest_framework import serializers
 from netbox.api.serializers import NetBoxModelSerializer
-from cesnet_service_path_plugin.api.serializers.segment import SegmentListSerializer
-from cesnet_service_path_plugin.api.serializers.service_path import ServicePathSerializer
+from cesnet_service_path_plugin.api.serializers.segment import SegmentSerializer
 from cesnet_service_path_plugin.models import SegmentCircuitMapping
 from circuits.api.serializers import CircuitSerializer
 
@@ -11,7 +10,7 @@ class SegmentCircuitMappingSerializer(NetBoxModelSerializer):
         view_name="plugins-api:cesnet_service_path_plugin-api:segmentcircuitmapping-detail"
     )
     circuit = CircuitSerializer(nested=True)
-    segment = SegmentListSerializer(nested=True)
+    segment = SegmentSerializer(nested=True)
 
     class Meta:
         model = SegmentCircuitMapping

cesnet_service_path_plugin/api/serializers/service_path.py

@@ -2,15 +2,15 @@
 from netbox.api.serializers import NetBoxModelSerializer
 from rest_framework import serializers
 
-from cesnet_service_path_plugin.api.serializers.segment import SegmentListSerializer
+from cesnet_service_path_plugin.api.serializers.segment import SegmentSerializer
 from cesnet_service_path_plugin.models import ServicePath
 
 
 class ServicePathSerializer(NetBoxModelSerializer):
     url = serializers.HyperlinkedIdentityField(
         view_name="plugins-api:cesnet_service_path_plugin-api:servicepath-detail"
     )
-    segments = SegmentListSerializer(many=True, read_only=True, nested=True)
+    segments = SegmentSerializer(many=True, read_only=True, nested=True)
     circuits = CircuitSerializer(required=False, many=True, nested=True)
 
     class Meta:

cesnet_service_path_plugin/api/serializers/service_path_segment_mapping.py

@@ -1,6 +1,6 @@
 from rest_framework import serializers
 from netbox.api.serializers import NetBoxModelSerializer
-from cesnet_service_path_plugin.api.serializers.segment import SegmentListSerializer
+from cesnet_service_path_plugin.api.serializers.segment import SegmentSerializer
 from cesnet_service_path_plugin.api.serializers.service_path import (
     ServicePathSerializer,
 )
@@ -16,7 +16,7 @@ class ServicePathSegmentMappingSerializer(NetBoxModelSerializer):
     #    required=True
     # )
     service_path = ServicePathSerializer(nested=True)
-    segment = SegmentListSerializer(nested=True)
+    segment = SegmentSerializer(nested=True)
 
     class Meta:
         model = ServicePathSegmentMapping

cesnet_service_path_plugin/api/views/segment.py

@@ -20,4 +20,5 @@ def get_serializer_class(self):
             if pathdata:
                 return SegmentDetailSerializer
 
+        # Use the updated SegmentSerializer for all other actions (including create/update)
         return SegmentSerializer