Skip to content

Commit 5c38bcb

Browse files
Park Juhyungjoojis
authored andcommitted
Do not return pending transactions if includePending is not set
1 parent 3f6bc8e commit 5c38bcb

File tree

1 file changed

+19
-8
lines changed

1 file changed

+19
-8
lines changed

src/models/logic/transaction.ts

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -398,6 +398,7 @@ async function getHashesByPlatformAddress(params: {
398398
itemsPerPage: number;
399399
firstEvaluatedKey: [number, number] | null;
400400
lastEvaluatedKey: [number, number] | null;
401+
includePending: boolean | null;
401402
}): Promise<string[]> {
402403
const {
403404
address,
@@ -409,7 +410,8 @@ async function getHashesByPlatformAddress(params: {
409410

410411
const whereCond: any[] = [
411412
{
412-
address
413+
address,
414+
...(params.includePending !== true ? { isPending: false } : {})
413415
}
414416
];
415417
if (firstEvaluatedKey || lastEvaluatedKey) {
@@ -449,6 +451,7 @@ async function getHashesByAssetAddress(params: {
449451
itemsPerPage: number;
450452
firstEvaluatedKey: [number, number] | null;
451453
lastEvaluatedKey: [number, number] | null;
454+
includePending: boolean | null;
452455
}): Promise<string[]> {
453456
const {
454457
address,
@@ -462,7 +465,8 @@ async function getHashesByAssetAddress(params: {
462465
const whereCond: any[] = [
463466
{
464467
address,
465-
...(assetType && { assetType })
468+
...(assetType && { assetType }),
469+
...(params.includePending !== true ? { isPending: false } : {})
466470
}
467471
];
468472
if (firstEvaluatedKey || lastEvaluatedKey) {
@@ -502,6 +506,7 @@ async function getHashesByAssetType(params: {
502506
itemsPerPage: number;
503507
firstEvaluatedKey: [number, number] | null;
504508
lastEvaluatedKey: [number, number] | null;
509+
includePending: boolean | null;
505510
}): Promise<string[]> {
506511
const {
507512
assetType,
@@ -513,7 +518,8 @@ async function getHashesByAssetType(params: {
513518

514519
const whereCond: any[] = [
515520
{
516-
assetType
521+
assetType,
522+
...(params.includePending !== true ? { isPending: false } : {})
517523
}
518524
];
519525
if (firstEvaluatedKey || lastEvaluatedKey) {
@@ -563,7 +569,8 @@ async function getHashes(params: {
563569
page,
564570
itemsPerPage,
565571
firstEvaluatedKey,
566-
lastEvaluatedKey
572+
lastEvaluatedKey,
573+
includePending = null
567574
} = params;
568575
if (address != null && assetType != null) {
569576
return getHashesByAssetAddress({
@@ -572,7 +579,8 @@ async function getHashes(params: {
572579
page,
573580
itemsPerPage,
574581
firstEvaluatedKey,
575-
lastEvaluatedKey
582+
lastEvaluatedKey,
583+
includePending
576584
});
577585
} else if (address != null) {
578586
if (AssetAddress.check(address)) {
@@ -581,15 +589,17 @@ async function getHashes(params: {
581589
page,
582590
itemsPerPage,
583591
firstEvaluatedKey,
584-
lastEvaluatedKey
592+
lastEvaluatedKey,
593+
includePending
585594
});
586595
} else if (PlatformAddress.check(address)) {
587596
return getHashesByPlatformAddress({
588597
address,
589598
page,
590599
itemsPerPage,
591600
firstEvaluatedKey,
592-
lastEvaluatedKey
601+
lastEvaluatedKey,
602+
includePending
593603
});
594604
}
595605
throw Error(`Invalid address: ${address}`);
@@ -599,7 +609,8 @@ async function getHashes(params: {
599609
page,
600610
itemsPerPage,
601611
firstEvaluatedKey,
602-
lastEvaluatedKey
612+
lastEvaluatedKey,
613+
includePending
603614
});
604615
}
605616
const whereCond: any[] = [

0 commit comments

Comments
 (0)