refactor: Clarify collection step with Contraption Actors

With the expectation that the various method signatures do describe what they do, the "dropItem"
was exceptionally hard to doubt and gone past it several months before come to the conclusion that
maybe there are some side effects implemented where the signature may not suggest.

This does not do any functional change, but improves the readability as now the five places where
this "dropItem" was used, there is a clear indication that the item collection does happen, and
suggests that the context needed to be passed not for position only, but for the contraption
storage as well.

Author: adaliszk

src/main/java/com/simibubi/create/api/behaviour/movement/MovementBehaviour.java

@@ -66,7 +66,12 @@ default boolean mustTickWhileDisabled() {
 		return false;
 	}
 
+	@Deprecated
 	default void dropItem(MovementContext context, ItemStack stack) {
+		collectOrDropItem(context, stack);
+	}
+
+	default void collectOrDropItem(MovementContext context, ItemStack stack) {
 		ItemStack remainder;
 		if (AllConfigs.server().kinetics.moveItemsToStorage.get())
 			remainder = ItemHandlerHelper.insertItem(context.contraption.getStorage().getAllItems(), stack, false);

src/main/java/com/simibubi/create/content/contraptions/actors/harvester/HarvesterMovementBehaviour.java

@@ -90,7 +90,7 @@ public void visitNewPosition(MovementContext context, BlockPos pos) {
 				stack.shrink(1);
 				seedSubtracted.setTrue();
 			}
-			dropItem(context, stack);
+			collectOrDropItem(context, stack);
 		});
 
 		BlockState cutCrop = cutCrop(world, pos, stateVisited);

src/main/java/com/simibubi/create/content/contraptions/actors/plough/PloughMovementBehaviour.java

@@ -125,7 +125,7 @@ protected void onBlockBroken(MovementContext context, BlockPos pos, BlockState b
 					.withParameter(LootContextParams.ORIGIN, Vec3.atCenterOf(pos))
 					.withParameter(LootContextParams.THIS_ENTITY, getPlayer(context))
 					.withParameter(LootContextParams.TOOL, new ItemStack(Items.IRON_SHOVEL)))
-				.forEach(s -> dropItem(context, s));
+				.forEach(s -> collectOrDropItem(context, s));
 		}
 	}
 

src/main/java/com/simibubi/create/content/contraptions/actors/roller/RollerMovementBehaviour.java

@@ -178,7 +178,7 @@ protected void destroyBlock(MovementContext context, BlockPos breakingPos) {
 		BlockHelper.destroyBlock(context.world, breakingPos, 1f, stack -> {
 			if (noHarvest || context.world.random.nextBoolean())
 				return;
-			this.dropItem(context, stack);
+			this.collectOrDropItem(context, stack);
 		});
 
 		super.destroyBlock(context, breakingPos);

src/main/java/com/simibubi/create/content/kinetics/base/BlockBreakingMovementBehaviour.java

@@ -218,7 +218,7 @@ public void tickBreaker(MovementContext context) {
 	}
 
 	protected void destroyBlock(MovementContext context, BlockPos breakingPos) {
-		BlockHelper.destroyBlock(context.world, breakingPos, 1f, stack -> this.dropItem(context, stack));
+		BlockHelper.destroyBlock(context.world, breakingPos, 1f, stack -> this.collectOrDropItem(context, stack));
 	}
 
 	protected float getBlockBreakingSpeed(MovementContext context) {

src/main/java/com/simibubi/create/content/kinetics/deployer/DeployerMovementBehaviour.java

@@ -259,7 +259,7 @@ private void tryDisposeOfExcess(MovementContext context) {
 				if (list == inv.items && i == inv.selected && filter.test(context.world, itemstack))
 					continue;
 
-				dropItem(context, itemstack);
+				collectOrDropItem(context, itemstack);
 				list.set(i, ItemStack.EMPTY);
 			}
 		}