chore: enable memory effects pass (#1237)

* chore: enable memory effects pass

* Update src/Compiler.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: avik-pal

ext/ReactantCUDAExt.jl

@@ -1191,14 +1191,14 @@ Reactant.@reactant_overlay @noinline function (func::LLVMFunc{F,tt})(
         )
     end
 
-    location = MLIR.IR.Location()
     @assert length(restys) == length(aliases)
     call = MLIR.Dialects.enzymexla.kernel_call(
         blk_operands...,
         mlir_args;
         result_0=restys,
         fn=MLIR.IR.FlatSymbolRefAttribute(sym_name),
         output_operand_aliases=MLIR.IR.Attribute(output_operand_aliases),
+        xla_side_effect_free=MLIR.IR.UnitAttribute(),
     )
 
     argidx = 1

src/Compiler.jl

@@ -1274,6 +1274,7 @@ function compile_mlir!(
             join(
                 if raise_first
                     [
+                        "mark-func-memory-effects",
                         opt_passes,
                         kern,
                         raise_passes,
@@ -1289,6 +1290,7 @@ function compile_mlir!(
                     ]
                 else
                     [
+                        "mark-func-memory-effects",
                         opt_passes,
                         "enzyme-batch",
                         opt_passes2,
@@ -1312,9 +1314,10 @@ function compile_mlir!(
             mod,
             join(
                 if raise_first
-                    [opt_passes]
+                    ["mark-func-memory-effects", opt_passes]
                 else
                     [
+                        "mark-func-memory-effects",
                         opt_passes,
                         "enzyme-batch",
                         opt_passes2,
@@ -1336,6 +1339,7 @@ function compile_mlir!(
             join(
                 if raise_first
                     [
+                        "mark-func-memory-effects",
                         opt_passes,
                         kern,
                         raise_passes,
@@ -1350,6 +1354,7 @@ function compile_mlir!(
                     ]
                 else
                     [
+                        "mark-func-memory-effects",
                         opt_passes,
                         "enzyme-batch",
                         opt_passes2,
@@ -1372,9 +1377,10 @@ function compile_mlir!(
             mod,
             join(
                 if raise_first
-                    [opt_passes]
+                    ["mark-func-memory-effects", opt_passes]
                 else
                     [
+                        "mark-func-memory-effects",
                         opt_passes,
                         "enzyme-batch",
                         opt_passes2,
@@ -1396,6 +1402,7 @@ function compile_mlir!(
             mod,
             join(
                 [
+                    "mark-func-memory-effects",
                     opt_passes,
                     "enzyme-batch",
                     opt_passes2,
@@ -1415,6 +1422,7 @@ function compile_mlir!(
             mod,
             join(
                 [
+                    "mark-func-memory-effects",
                     "enzyme-batch",
                     enzyme_pass,
                     "canonicalize",
@@ -1431,6 +1439,7 @@ function compile_mlir!(
             join(
                 if raise_first
                     [
+                        "mark-func-memory-effects",
                         kern,
                         raise_passes,
                         "enzyme-batch",
@@ -1443,6 +1452,7 @@ function compile_mlir!(
                     ]
                 else
                     [
+                        "mark-func-memory-effects",
                         "enzyme-batch",
                         enzyme_pass,
                         "canonicalize",
@@ -1464,6 +1474,7 @@ function compile_mlir!(
             join(
                 if raise_first
                     [
+                        "mark-func-memory-effects",
                         opt_passes,
                         kern,
                         raise_passes,
@@ -1475,6 +1486,7 @@ function compile_mlir!(
                     ]
                 else
                     [
+                        "mark-func-memory-effects",
                         opt_passes,
                         "enzyme-batch",
                         opt_passes2,
@@ -1490,7 +1502,7 @@ function compile_mlir!(
             "after_enzyme",
         )
     elseif optimize === :canonicalize
-        run_pass_pipeline!(mod, "canonicalize", "canonicalize")
+        run_pass_pipeline!(mod, "mark-func-memory-effects,canonicalize", "canonicalize")
     elseif optimize === :just_batch
         run_pass_pipeline!(mod, "enzyme-batch", "enzyme-batch")
     elseif optimize isa String