@@ -36,10 +36,6 @@ function Distributed.get_local_process_id(::Distributed.MPIEnvDetector)
36
36
end
37
37
38
38
function __init__ ()
39
- # # TODO improve this, temporary hack
40
- # # when you fix it, remember to possibly make TracedType const again
41
- # Reactant.TracedType = Union{Reactant.TracedRArray,Reactant.TracedRNumber,Reactant.MissingTracedValue,TracedRequest}
42
-
43
39
libmpi_handle = MPI. API. libmpi_handle
44
40
45
41
# register MPI routines
@@ -237,21 +233,20 @@ function Base.show(io::IOty, X::TracedRequest) where {IOty<:Union{IO,IOContext}}
237
233
return print (io, " TracedRequest(" , X. paths, " )" )
238
234
end
239
235
240
- Reactant. TracedUtils. get_mlir_data (x:: TracedRequest ) = x. mlir_data
236
+ # # NOTE: Commenting out the below on the assumption that a Request will never cross the compile boundary
237
+ # # If we ever want to return a request, the below could serve as a starting point
238
+ # Reactant.TracedUtils.get_mlir_data(x::TracedRequest) = x.mlir_data
241
239
# Reactant.TracedUtils.set_mlir_data!(x::TracedRequest, data) = (x.mlir_data = data; return x)
242
240
243
- # # May need these later, but for now we assume that no request needs to pass the compile boundary
244
241
# Reactant.TracedUtils.get_paths(x::TracedRequest) = x.paths
245
242
# Reactant.TracedUtils.set_paths!(x::TracedRequest, paths) = (x.paths = paths; return x)
246
243
#
247
- # # TODO not sure how to implement this for TracedRequest
248
- # # probably just want to hardcode the types and dims?
249
244
# function Reactant.Ops.mlir_type(x::TracedRequest)::MLIR.IR.Type
250
245
# # return MLIR.IR.TensorType(collect(Int, size(x)), MLIR.IR.Type(unwrapped_eltype(x)))
251
246
# return MLIR.IR.TensorType(collect(Int, ()), MLIR.IR.Type(Int64))
252
247
# end
253
248
#
254
- # TODO if want to use this , need to somehow add TracedRequest to TracedTypes, which is currently const
249
+ # TODO for this to work properly in finalize_mlir_fn() , need to add TracedRequest to TracedTypes, currently const
255
250
# Base.@nospecializeinfer function Reactant.make_tracer(
256
251
# seen,
257
252
# @nospecialize(prev::TracedRequest),
0 commit comments