fix: empty buffers (#980)

* fix: empty buffers

* test: empty buffer check

Author: avik-pal

src/TracedUtils.jl

@@ -290,7 +290,7 @@ function make_mlir_fn(
         seen_results,
         result,
         (:result,),
-        concretein ? Reactant.TracedTrack : Reactant.TracedSetPath;
+        concretein ? Reactant.NoStopTracedTrack : Reactant.TracedSetPath;
         runtime,
     )
 
@@ -300,7 +300,7 @@ function make_mlir_fn(
             seen_results,
             traced_args[i],
             concretein ? (:resargs, i) : (),
-            Reactant.TracedTrack;
+            Reactant.NoStopTracedTrack;
             runtime,
         )
     end
@@ -311,6 +311,7 @@ function make_mlir_fn(
         (args_in_result != :all && has_argidx(v)) && continue
         push!(linear_results, v)
     end
+
     if args_in_result == :mutated
         append!(linear_results, linear_args[mutated_args])
     end

test/integration/optimisers.jl

@@ -0,0 +1,14 @@
+using Test, Reactant, Optimisers
+
+is_empty_buffer(x::ConcreteIFRTNumber) = x.data === C_NULL
+is_empty_buffer(x::ConcretePJRTNumber) = any(x === C_NULL for x in x.data)
+
+@testset "No Empty Buffers #861" begin
+    opt = Descent(Reactant.to_rarray(0.1; track_numbers=Number))
+    x = Reactant.to_rarray((ones(10), ones(3), ones(5)))
+    opt_state = @jit Optimisers.setup(opt, x)
+
+    @test !is_empty_buffer(opt_state[1].rule.eta)
+    @test !is_empty_buffer(opt_state[2].rule.eta)
+    @test !is_empty_buffer(opt_state[3].rule.eta)
+end

test/runtests.jl

@@ -74,6 +74,7 @@ const REACTANT_TEST_GROUP = lowercase(get(ENV, "REACTANT_TEST_GROUP", "all"))
         @safetestset "SpecialFunctions" include("integration/special_functions.jl")
         @safetestset "Random" include("integration/random.jl")
         @safetestset "Python" include("integration/python.jl")
+        @safetestset "Optimisers" include("integration/optimisers.jl")
     end
 
     if REACTANT_TEST_GROUP == "all" || REACTANT_TEST_GROUP == "neural_networks"