Skip to content

Commit be3871e

Browse files
authored
Use [email protected] and mark broken comms tests as such (#1177)
1 parent 2daeede commit be3871e

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

Project.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "Reactant"
22
uuid = "3c362404-f566-11ee-1572-e11a4b42c853"
33
authors = ["William Moses <[email protected]>", "Valentin Churavy <[email protected]>", "Sergio Sánchez Ramírez <[email protected]>", "Paul Berg <[email protected]>", "Avik Pal <[email protected]>", "Mosè Giordano <[email protected]>"]
4-
version = "0.2.69"
4+
version = "0.2.70"
55

66
[deps]
77
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
@@ -87,7 +87,7 @@ PythonCall = "0.9"
8787
Random = "1.10"
8888
Random123 = "1.7"
8989
ReactantCore = "0.1.9"
90-
Reactant_jll = "0.0.138"
90+
Reactant_jll = "0.0.139"
9191
ScopedValues = "1.3.0"
9292
Scratch = "1.2"
9393
Sockets = "1.10"

test/optimize_comm.jl

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,10 @@ if length(addressable_devices) ≥ 8
101101

102102
hlo = repr(@code_xla shardy_passes = :to_mhlo_shardings dus2(rx, ry))
103103
@test !contains(hlo, "all-to-all")
104-
@test !contains(hlo, "all-gather")
105-
@test contains(hlo, "collective-permute")
104+
@test !contains(hlo, "all-gather") broken =
105+
Reactant.XLA.REACTANT_XLA_RUNTIME == "PJRT"
106+
@test contains(hlo, "collective-permute") broken =
107+
Reactant.XLA.REACTANT_XLA_RUNTIME == "PJRT"
106108

107109
dus2(x, y)
108110
@jit shardy_passes = :to_mhlo_shardings dus2(rx, ry)

0 commit comments

Comments
 (0)