ci: apply suggestions from code review

Author: avik-pal

.github/workflows/CommonCI.yml

@@ -134,8 +134,6 @@ jobs:
         shell: julia --color=yes --code-coverage=user --depwarn=yes --project=. {0}
         # Only in Julia v1.10 we need to install `ReactantCore` manually.
         if: ${{ inputs.julia_version == '1.10' || inputs.julia_version == 'lts' }}
-        env:
-          JULIA_PKG_SERVER_REGISTRY_PREFERENCE: eager
 
       # Run the tests (pjrt or ifrt or both)
       - name: "Setup Runtime Preferences (PJRT)"
@@ -160,10 +158,7 @@ jobs:
         shell: julia --color=yes --code-coverage=user --depwarn=yes --project=. {0}
         env:
           ALLOW_RERESOLVE: ${{ !inputs.downgrade_testing }}
-          JULIA_PKG_SERVER_REGISTRY_PREFERENCE: eager
           REACTANT_TEST_GROUP: ${{ inputs.test_group }}
-          XLA_FLAGS: "--xla_force_host_platform_device_count=12"
-          JULIA_DEBUG: "Reactant,Reactant_jll"
 
       - name: "Setup Runtime Preferences (IFRT)"
         if: ${{ inputs.runtime == 'ifrt' || inputs.runtime == 'both' }}
@@ -187,23 +182,20 @@ jobs:
         shell: julia --color=yes --code-coverage=user --depwarn=yes --project=. {0}
         env:
           ALLOW_RERESOLVE: ${{ !inputs.downgrade_testing }}
-          JULIA_PKG_SERVER_REGISTRY_PREFERENCE: eager
           REACTANT_TEST_GROUP: ${{ inputs.test_group }}
-          XLA_FLAGS: "--xla_force_host_platform_device_count=12"
-          JULIA_DEBUG: "Reactant,Reactant_jll"
 
       - name: "Upload MLIR modules"
         uses: actions/upload-artifact@v4
         timeout-minutes: 10
-        if: ${{ always() }}
+        if: always()
         with:
           name: "mlir-${{ inputs.julia_version }}-${{ inputs.os }}-${{ inputs.runtime }}-assertions=${{ inputs.assertions }}-${{ github.event_name }}-test_group=${{ inputs.test_group }}-${{ inputs.localjll }}"
           path: "**/*.mlir"
           retention-days: 90
           overwrite: false
 
       - name: Save Julia depot cache on cancel or failure
-        if: ${{ inputs.localjll && (cancelled() || failure()) }}
+        if: cancelled() || failure()
         uses: actions/cache/save@v4
         with:
           path: |
@@ -215,3 +207,8 @@ jobs:
         with:
           files: lcov.info
           token: ${{ secrets.CODECOV_TOKEN }}
+
+env:
+  JULIA_PKG_SERVER_REGISTRY_PREFERENCE: eager
+  XLA_FLAGS: "--xla_force_host_platform_device_count=12"
+  JULIA_DEBUG: "Reactant,Reactant_jll"