Merge pull request #28 from winfriedgerlach/feature/use-newer-API-for-better-performance

cowtowncoder · web-flow · commit 4c77a0fb73db · 2025-11-09T16:58:59.000-08:00
Use newer `BigDecimal` api to avoid extra `String` allocation
diff --git a/src/main/java/org/codehaus/stax2/ri/typed/ValueDecoderFactory.java b/src/main/java/org/codehaus/stax2/ri/typed/ValueDecoderFactory.java
@@ -1074,12 +1074,7 @@ public void decode(char[] lexical, int start, int end) throws IllegalArgumentExc
         {
             int len = end-start;
             try {
-                /* !!! 21-Nov-2008, TSa: This constructor was added in JDK1.5
-                 *   so can't yet be used (As of Woodstox 4.x).
-                 *   Need to use the older constructor for now
-                 */
-                //mValue = new BigDecimal(lexical, start, len);
-                mValue = new BigDecimal(new String(lexical, start, len));
+                mValue = new BigDecimal(lexical, start, len);
             } catch (NumberFormatException nex) {
                 throw constructInvalidValue(new String(lexical, start, len));
             }

Original file line number	Diff line number	Diff line change
`@@ -1074,12 +1074,7 @@ public void decode(char[] lexical, int start, int end) throws IllegalArgumentExc`
`1074`	`1074`	`{`
`1075`	`1075`	`int len = end-start;`
`1076`	`1076`	`try {`
`1077`		`- /* !!! 21-Nov-2008, TSa: This constructor was added in JDK1.5`
`1078`		`- * so can't yet be used (As of Woodstox 4.x).`
`1079`		`- * Need to use the older constructor for now`
`1080`		`- */`
`1081`		`- //mValue = new BigDecimal(lexical, start, len);`
`1082`		`- mValue = new BigDecimal(new String(lexical, start, len));`
	`1077`	`+ mValue = new BigDecimal(lexical, start, len);`
`1083`	`1078`	`} catch (NumberFormatException nex) {`
`1084`	`1079`	`throw constructInvalidValue(new String(lexical, start, len));`
`1085`	`1080`	`}`