add API for URL fragments (#2457)

Author: rnystrom

Classes/Issues/Comments/IssueCommentSectionController.swift

@@ -85,11 +85,12 @@ final class IssueCommentSectionController: ListBindingSectionController<IssueCom
     // MARK: Private API
 
     func shareAction(sender: UIView) -> UIAlertAction? {
-        let attribute = object?.asReviewComment == true ? "#discussion_r" : "#issuecomment-"
+        let attribute = object?.asReviewComment == true ? "discussion_r" : "issuecomment-"
         guard let number = object?.number,
-            let url = URLBuilder.github().add(
-                paths: [model.owner, model.repo, "issues", model.number, attribute, number]
-                ).url
+            let url = URLBuilder.github()
+                .add(paths: [model.owner, model.repo, "issues", model.number])
+                .set(fragment: "\(attribute)\(number)")
+                .url
         else { return nil }
         weak var weakSelf = self
 

Classes/Utility/URLBuilder.swift

@@ -46,6 +46,12 @@ final class URLBuilder {
         return self
     }
 
+    @discardableResult
+    func set(fragment: String) -> URLBuilder {
+        components.fragment = fragment
+        return self
+    }
+
     var url: URL? {
         var components = self.components
         if !pathComponents.isEmpty {

FreetimeTests/URLBuilderTests.swift

@@ -67,4 +67,14 @@ class URLBuilderTests: XCTestCase {
         )
     }
 
+    func test_withAnchorSymbol() {
+        let builder = URLBuilder.github()
+            .add(paths: ["githawkapp", "githawk", "issues", "42"])
+            .set(fragment: "issuecomment-1234")
+        XCTAssertEqual(
+            builder.url!.absoluteString,
+            "https://github.com/githawkapp/githawk/issues/42#issuecomment-1234"
+        )
+    }
+
 }