[GSoC 2025] Final Report - TMVA - SOFIE Project - PrasannaKasar #1756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for earnest-hotteok-b1e1bf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
hi @maszyman |
|
Could you please review? |
maszyman
approved these changes
Oct 31, 2025
maszyman
approved these changes
Oct 31, 2025
|
Yes sure |
|
Should I tag them here? @maszyman |
|
Already did in #1756 (comment) ;-) |
|
Okay |
|
LGTM! |
sanjibansg
suggested changes
Oct 31, 2025
| layout: blog_post | ||
| logo: "TMVA - SOFIE" | ||
| intro: | | ||
| Developed a parser within SOFIE to parse Machine Learning models trained with Keras. Rewrote the existing parser, which was written in C++, in Python. Added support for parsing missing layers, such as Pooling and LayerNormalization, and wrote unit tests for the parser. |
There was a problem hiding this comment.
Suggested change
| Developed a parser within SOFIE to parse Machine Learning models trained with Keras. Rewrote the existing parser, which was written in C++, in Python. Added support for parsing missing layers, such as Pooling and LayerNormalization, and wrote unit tests for the parser. | |
| Rewrote the existing parser, which was written in C++, in Python. |
Maybe rephrase this line, this sounds a bit ambiguous. A suggestion could be, "Rewrote the existing parser in Python, which was previously written in C++".
|
|
||
| ## Work Accomplished | ||
|
|
||
| Since SOFIE's operators are written entirely in C++, we had to leverage ROOT's `Pythonization` functionality, which essentially allows us to use SOFIE's C++ objects in a Pythonic interface. The overall structure of the parser is very similar to the previous one. The sequence of operations is as follows: |
There was a problem hiding this comment.
Suggested change
| Since SOFIE's operators are written entirely in C++, we had to leverage ROOT's `Pythonization` functionality, which essentially allows us to use SOFIE's C++ objects in a Pythonic interface. The overall structure of the parser is very similar to the previous one. The sequence of operations is as follows: | |
| Since SOFIE's operators are written entirely in C++, we had to leverage ROOT's `Pythonization` functionality, which essentially allows us to bind SOFIE's C++ objects to a Pythonic interface. The overall structure of the parser is very similar to the previous one. The sequence of operations is as follows: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project: TMVA SOFIE - Enhancing Keras Parser and JAX/FLAX Integration