Skip to content

Commit 4a28a4d

Browse files
author
Vano
committed
entry symbol macro, Cmake create function consistency
1 parent 2973674 commit 4a28a4d

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

godot-cppscript.cmake

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ find_package(Python3 3.4 REQUIRED)
33
set(CPPSCRIPT_DIR ${CMAKE_CURRENT_LIST_DIR})
44

55
#TODO: make it work in parallel
6-
function(create_cppscript_target TARGET_NAME HEADER_NAME HEADERS_DIR GEN_DIR AUTO_METHODS COMPILE_DEFS INCLUDE_PATHS)
6+
function(create_cppscript_target TARGET_NAME HEADERS_LIST HEADER_NAME HEADERS_DIR GEN_DIR AUTO_METHODS COMPILE_DEFS INCLUDE_PATHS)
77
# Handle empty/NOTFOUND lists
88
if(NOT INCLUDE_PATHS)
99
set(INCLUDE_PATHS "")
@@ -19,11 +19,10 @@ function(create_cppscript_target TARGET_NAME HEADER_NAME HEADERS_DIR GEN_DIR AUT
1919
set(AUTO_METHODS_STR "False")
2020
endif()
2121

22-
file(GLOB_RECURSE HEADERS_LIST RELATIVE ${HEADERS_DIR} ${HEADERS_DIR}/*.hpp)
23-
2422
foreach(PATH ${HEADERS_LIST})
23+
file(RELATIVE_PATH PATH "${HEADERS_DIR}" "${PATH}")
2524
string(REGEX REPLACE "\.hpp$" ".gen.cpp" relative_path "${PATH}")
26-
list(APPEND SOURCES_LIST ${GEN_DIR}/${relative_path})
25+
list(APPEND SOURCES_LIST "${GEN_DIR}/${relative_path}")
2726
endforeach()
2827

2928
add_custom_command(
@@ -42,16 +41,16 @@ function(create_cppscript_target TARGET_NAME HEADER_NAME HEADERS_DIR GEN_DIR AUT
4241
"--definitions" ${COMPILE_DEFS}
4342
"--include-paths" ${CPPSCRIPT_DIR}/src ${HEADERS_DIR} ${INCLUDE_PATHS}
4443
"--"
45-
${CPPSCRIPT_HEADERS}
44+
${HEADERS_LIST}
4645

47-
DEPENDS ${CPPSCRIPT_HEADERS}
46+
DEPENDS ${HEADERS_LIST}
4847
WORKING_DIRECTORY ${CPPSCRIPT_DIR}
4948
VERBATIM
5049
COMMAND_EXPAND_LISTS
5150
COMMENT "Parsing header files..."
5251
)
5352

5453
target_sources(${TARGET_NAME} PRIVATE ${SOURCES_LIST})
55-
target_include_directories(${TARGET_NAME} PUBLIC ${HEADERS_DIR} ${CPPSCRIPT_DIR}/src)
54+
target_include_directories(${TARGET_NAME} PUBLIC ${CPPSCRIPT_DIR}/src ${HEADERS_DIR})
5655
endfunction()
5756

templates/register_types.cpp.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ void LIBRARY_DEINIT_FUNC(ModuleInitializationLevel p_level) {
5353

5454
extern "C" {
5555
// GDExtension initialization
56-
GDExtensionBool GDE_EXPORT scripts_library_init(GDExtensionInterfaceGetProcAddress p_get_proc_address, GDExtensionClassLibraryPtr p_library, GDExtensionInitialization *r_initialization) {
56+
GDExtensionBool GDE_EXPORT LIBRARY_ENTRY_SYMBOL_FUNC(GDExtensionInterfaceGetProcAddress p_get_proc_address, GDExtensionClassLibraryPtr p_library, GDExtensionInitialization *r_initialization) {
5757
godot::GDExtensionBinding::InitObject init_obj(p_get_proc_address, p_library, r_initialization);
5858

5959
init_obj.register_initializer(LIBRARY_INIT_FUNC);

templates/register_types.h.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99

1010
#define LIBRARY_INIT_FUNC initialize_ ## LIBRARY_NAME ## _module
1111
#define LIBRARY_UNINIT_FUNC uninitialize_ ## LIBRARY_NAME ## _module
12+
#define LIBRARY_ENTRY_SYMBOL_FUNC LIBRARY_NAME ## _library_init
1213

1314
void LIBRARY_INIT_FUNC(godot::ModuleInitializationLevel p_level);
1415
void LIBRARY_UNINIT_FUNC(godot::ModuleInitializationLevel p_level);

0 commit comments

Comments
 (0)