build: disable FPE by default

Author: VincentVanlaer

docs/source/developing/build-system.rst

@@ -21,7 +21,7 @@ The build system exposes several options to control the build process. If you wa
 * **WITH_GYRE**: Whether to build GYRE and include support for GYRE in MESA. Defaults to ``yes`` (any other value will disable GYRE).
 * **WITH_ADIPLS**: Whether to build ADIPLS and include support for ADIPLS in MESA. Defaults to ``yes`` (any other value will disable ADIPLS).
 * **WITH_PGSTAR**: Whether to include support for showing and saving plots with pgplot. Defaults to ``yes`` (any other value will disable pgstar/pgplot).
-* **WITH_FPE_CHECKS**: Whether to enable FPE checks for NaNs, overflows, and division by zero. Defaults to ``yes`` (any other value will disable the checks). Is it recommended to keep this set to ``yes`` at all times, as crashes would indicate bugs in either MESA or user provided code through ``run_star_extras.f90``. This option is available for compatibility with older versions of MESA.
+* **WITH_FPE_CHECKS**: Whether to enable FPE checks for NaNs, overflows, and division by zero. Defaults to ``no`` (set to ``yes`` to enable).
 
 Module build configuration
 ==========================

kap/preprocessor/spline_OPLIB_tables.py

@@ -71,6 +71,7 @@ def smooth_opac(table_path: Path):
             output.write(row)
             output.write("\n")
 
+
 opacity_file_dir = Path(sys.argv[1])
 output_file_dir = Path(sys.argv[2])
 

make/compile-settings-gnu.mk

@@ -7,9 +7,11 @@ FLAGS_CODE_SANITY := \
   -fstack-clash-protection \
   -fcheck=bounds \
   -D_FORTIFY_SOURCE=2
-FFLAGS_FP_SANITY := -finit-real=snan -finit-derived
+FFLAGS_FP_SANITY := -finit-derived
 ifeq ($(WITH_FPE_CHECKS),yes)
-FFLAGS_FP_SANITY += -ffpe-trap=invalid,overflow,zero
+FFLAGS_FP_SANITY += -ffpe-trap=invalid,overflow,zero -finit-real=snan
+else
+FFLAGS_FP_SANITY += -finit-real=zero
 endif
 FFLAGS_FORTRAN_SANITY := -std=f2008 -ffree-line-length-none -ffixed-line-length-none -Wno-unused-dummy-argument -Wno-compare-reals -Wno-do-subscript
 FLAGS_REPRO := -ffp-contract=off

make/defaults-module.mk

@@ -15,5 +15,5 @@ WITH_CRLIBM ?= yes
 WITH_GYRE ?= yes
 WITH_ADIPLS ?= yes
 WITH_PGSTAR ?= yes
-WITH_FPE_CHECKS ?= yes
+WITH_FPE_CHECKS ?= no
 PREFIX ?= $(MAKE_DIR)/..