fix: QUICClient does not need to extend EventTarget

CMCDragonkai · CMCDragonkai · commit 0cb6f0b1a758 · 2023-09-27T16:48:35.000+10:00
diff --git a/docs/classes/QUICClient.html b/docs/classes/QUICClient.html
@@ -18,8 +18,7 @@ <h1>Class QUICClient</h1></div>
 <section class="tsd-panel tsd-hierarchy">
 <h4>Hierarchy</h4>
 <ul class="tsd-hierarchy">
-<li><span class="tsd-signature-type ">CreateDestroy</span></li>
-<li><span class="tsd-signature-type ">EventTarget</span>
+<li><span class="tsd-signature-type ">CreateDestroy</span>
 <ul class="tsd-hierarchy">
 <li><span class="target">QUICClient</span></li></ul></li></ul></section><aside class="tsd-sources">
 <ul>
@@ -241,55 +240,46 @@ <h3 class="tsd-anchor-link"><span>closed</span><a href="#closed" aria-label="Per
 <li class="tsd-description">
 <h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">boolean</span></h4><aside class="tsd-sources">
 <ul>
-<li>Defined in <a href="https://github.com/MatrixAI/js-quic/blob/master/src/QUICClient.ts#L545">src/QUICClient.ts:545</a></li></ul></aside></li></ul></section>
+<li>Defined in <a href="https://github.com/MatrixAI/js-quic/blob/master/src/QUICClient.ts#L544">src/QUICClient.ts:544</a></li></ul></aside></li></ul></section>
 <section class="tsd-panel tsd-member"><a id="host" class="tsd-anchor"></a>
 <h3 class="tsd-anchor-link"><span>host</span><a href="#host" aria-label="Permalink" class="tsd-anchor-icon"><svg viewBox="0 0 24 24"><use href="#icon-anchor"></use></svg></a></h3>
 <ul class="tsd-signatures">
 <li class="tsd-signature" id="host.host-1"><span class="tsd-signature-symbol">get</span> host<span class="tsd-signature-symbol">(</span><span class="tsd-signature-symbol">)</span><span class="tsd-signature-symbol">: </span><a href="../types/Host.html" class="tsd-signature-type tsd-kind-type-alias">Host</a></li>
 <li class="tsd-description">
 <h4 class="tsd-returns-title">Returns <a href="../types/Host.html" class="tsd-signature-type tsd-kind-type-alias">Host</a></h4><aside class="tsd-sources">
 <ul>
-<li>Defined in <a href="https://github.com/MatrixAI/js-quic/blob/master/src/QUICClient.ts#L525">src/QUICClient.ts:525</a></li></ul></aside></li></ul></section>
+<li>Defined in <a href="https://github.com/MatrixAI/js-quic/blob/master/src/QUICClient.ts#L524">src/QUICClient.ts:524</a></li></ul></aside></li></ul></section>
 <section class="tsd-panel tsd-member"><a id="localHost" class="tsd-anchor"></a>
 <h3 class="tsd-anchor-link"><span>local<wbr/>Host</span><a href="#localHost" aria-label="Permalink" class="tsd-anchor-icon"><svg viewBox="0 0 24 24"><use href="#icon-anchor"></use></svg></a></h3>
 <ul class="tsd-signatures">
 <li class="tsd-signature" id="localHost.localHost-1"><span class="tsd-signature-symbol">get</span> localHost<span class="tsd-signature-symbol">(</span><span class="tsd-signature-symbol">)</span><span class="tsd-signature-symbol">: </span><a href="../types/Host.html" class="tsd-signature-type tsd-kind-type-alias">Host</a></li>
 <li class="tsd-description">
 <h4 class="tsd-returns-title">Returns <a href="../types/Host.html" class="tsd-signature-type tsd-kind-type-alias">Host</a></h4><aside class="tsd-sources">
 <ul>
-<li>Defined in <a href="https://github.com/MatrixAI/js-quic/blob/master/src/QUICClient.ts#L535">src/QUICClient.ts:535</a></li></ul></aside></li></ul></section>
+<li>Defined in <a href="https://github.com/MatrixAI/js-quic/blob/master/src/QUICClient.ts#L534">src/QUICClient.ts:534</a></li></ul></aside></li></ul></section>
 <section class="tsd-panel tsd-member"><a id="localPort" class="tsd-anchor"></a>
 <h3 class="tsd-anchor-link"><span>local<wbr/>Port</span><a href="#localPort" aria-label="Permalink" class="tsd-anchor-icon"><svg viewBox="0 0 24 24"><use href="#icon-anchor"></use></svg></a></h3>
 <ul class="tsd-signatures">
 <li class="tsd-signature" id="localPort.localPort-1"><span class="tsd-signature-symbol">get</span> localPort<span class="tsd-signature-symbol">(</span><span class="tsd-signature-symbol">)</span><span class="tsd-signature-symbol">: </span><a href="../types/Port.html" class="tsd-signature-type tsd-kind-type-alias">Port</a></li>
 <li class="tsd-description">
 <h4 class="tsd-returns-title">Returns <a href="../types/Port.html" class="tsd-signature-type tsd-kind-type-alias">Port</a></h4><aside class="tsd-sources">
 <ul>
-<li>Defined in <a href="https://github.com/MatrixAI/js-quic/blob/master/src/QUICClient.ts#L540">src/QUICClient.ts:540</a></li></ul></aside></li></ul></section>
+<li>Defined in <a href="https://github.com/MatrixAI/js-quic/blob/master/src/QUICClient.ts#L539">src/QUICClient.ts:539</a></li></ul></aside></li></ul></section>
 <section class="tsd-panel tsd-member"><a id="port" class="tsd-anchor"></a>
 <h3 class="tsd-anchor-link"><span>port</span><a href="#port" aria-label="Permalink" class="tsd-anchor-icon"><svg viewBox="0 0 24 24"><use href="#icon-anchor"></use></svg></a></h3>
 <ul class="tsd-signatures">
 <li class="tsd-signature" id="port.port-1"><span class="tsd-signature-symbol">get</span> port<span class="tsd-signature-symbol">(</span><span class="tsd-signature-symbol">)</span><span class="tsd-signature-symbol">: </span><a href="../types/Port.html" class="tsd-signature-type tsd-kind-type-alias">Port</a></li>
 <li class="tsd-description">
 <h4 class="tsd-returns-title">Returns <a href="../types/Port.html" class="tsd-signature-type tsd-kind-type-alias">Port</a></h4><aside class="tsd-sources">
 <ul>
-<li>Defined in <a href="https://github.com/MatrixAI/js-quic/blob/master/src/QUICClient.ts#L530">src/QUICClient.ts:530</a></li></ul></aside></li></ul></section></section>
+<li>Defined in <a href="https://github.com/MatrixAI/js-quic/blob/master/src/QUICClient.ts#L529">src/QUICClient.ts:529</a></li></ul></aside></li></ul></section></section>
 <section class="tsd-panel-group tsd-member-group">
 <h2>Methods</h2>
 <section class="tsd-panel tsd-member tsd-is-inherited tsd-is-external"><a id="addEventListener" class="tsd-anchor"></a>
 <h3 class="tsd-anchor-link"><span>add<wbr/>Event<wbr/>Listener</span><a href="#addEventListener" aria-label="Permalink" class="tsd-anchor-icon"><svg viewBox="0 0 24 24"><use href="#icon-anchor"></use></svg></a></h3>
 <ul class="tsd-signatures tsd-is-inherited tsd-is-external">
 <li class="tsd-signature tsd-anchor-link" id="addEventListener.addEventListener-1"><span class="tsd-kind-call-signature">add<wbr/>Event<wbr/>Listener</span><span class="tsd-signature-symbol">(</span><span class="tsd-kind-parameter">type</span>, <span class="tsd-kind-parameter">callback</span>, <span class="tsd-kind-parameter">options</span><span class="tsd-signature-symbol">?</span><span class="tsd-signature-symbol">)</span><span class="tsd-signature-symbol">: </span><span class="tsd-signature-type">void</span><a href="#addEventListener.addEventListener-1" aria-label="Permalink" class="tsd-anchor-icon"><svg viewBox="0 0 24 24"><use href="#icon-anchor"></use></svg></a></li>
 <li class="tsd-description">
-<div class="tsd-comment tsd-typography"><p>Appends an event listener for events whose type attribute value is type. The callback argument sets the callback that will be invoked when the event is dispatched.</p>
-<p>The options argument sets listener-specific options. For compatibility this can be a boolean, in which case the method behaves exactly as if the value was specified as options&#39;s capture.</p>
-<p>When set to true, options&#39;s capture prevents callback from being invoked when the event&#39;s eventPhase attribute value is BUBBLING_PHASE. When false (or not present), callback will not be invoked when event&#39;s eventPhase attribute value is CAPTURING_PHASE. Either way, callback will be invoked if event&#39;s eventPhase attribute value is AT_TARGET.</p>
-<p>When set to true, options&#39;s passive indicates that the callback will not cancel the event by invoking preventDefault(). This is used to enable performance optimizations described in § 2.8 Observing event listeners.</p>
-<p>When set to true, options&#39;s once indicates that the callback will only be invoked once after which the event listener will be removed.</p>
-<p>If an AbortSignal is passed for options&#39;s signal, then the event listener will be removed when signal is aborted.</p>
-<p>The event listener is appended to target&#39;s event listener list and is not appended if it has the same type, callback, and capture.</p>
-<p><a href="https://developer.mozilla.org/docs/Web/API/EventTarget/addEventListener">MDN Reference</a></p>
-</div>
 <div class="tsd-parameters">
 <h4 class="tsd-parameters-title">Parameters</h4>
 <ul class="tsd-parameter-list">
@@ -299,11 +289,10 @@ <h5><span class="tsd-kind-parameter">type</span>: <span class="tsd-signature-typ
 <h5><span class="tsd-kind-parameter">callback</span>: <span class="tsd-signature-type">null</span><span class="tsd-signature-symbol"> | </span><span class="tsd-signature-type ">EventListenerOrEventListenerObject</span></h5></li>
 <li>
 <h5><code class="tsd-tag ts-flagOptional">Optional</code> <span class="tsd-kind-parameter">options</span>: <span class="tsd-signature-type">boolean</span><span class="tsd-signature-symbol"> | </span><span class="tsd-signature-type ">AddEventListenerOptions</span></h5></li></ul></div>
-<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">void</span></h4>
-<div class="tsd-comment tsd-typography"></div><aside class="tsd-sources">
+<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">void</span></h4><aside class="tsd-sources">
 <p>Inherited from CreateDestroy.addEventListener</p>
 <ul>
-<li>Defined in node_modules/typescript/lib/lib.dom.d.ts:8168</li></ul></aside></li></ul></section>
+<li>Defined in node_modules/@matrixai/events/dist/Evented.d.ts:9</li></ul></aside></li></ul></section>
 <section class="tsd-panel tsd-member tsd-is-inherited"><a id="destroy" class="tsd-anchor"></a>
 <h3 class="tsd-anchor-link"><span>destroy</span><a href="#destroy" aria-label="Permalink" class="tsd-anchor-icon"><svg viewBox="0 0 24 24"><use href="#icon-anchor"></use></svg></a></h3>
 <ul class="tsd-signatures tsd-is-inherited">
@@ -321,25 +310,21 @@ <h4 class="tsd-returns-title">Returns <span class="tsd-signature-type ">Promise<
 <div class="tsd-comment tsd-typography"></div><aside class="tsd-sources">
 <p>Inherited from CreateDestroy.destroy</p>
 <ul>
-<li>Defined in <a href="https://github.com/MatrixAI/js-quic/blob/master/src/QUICClient.ts#L559">src/QUICClient.ts:559</a></li></ul></aside></li></ul></section>
+<li>Defined in <a href="https://github.com/MatrixAI/js-quic/blob/master/src/QUICClient.ts#L558">src/QUICClient.ts:558</a></li></ul></aside></li></ul></section>
 <section class="tsd-panel tsd-member tsd-is-inherited tsd-is-external"><a id="dispatchEvent" class="tsd-anchor"></a>
 <h3 class="tsd-anchor-link"><span>dispatch<wbr/>Event</span><a href="#dispatchEvent" aria-label="Permalink" class="tsd-anchor-icon"><svg viewBox="0 0 24 24"><use href="#icon-anchor"></use></svg></a></h3>
 <ul class="tsd-signatures tsd-is-inherited tsd-is-external">
 <li class="tsd-signature tsd-anchor-link" id="dispatchEvent.dispatchEvent-1"><span class="tsd-kind-call-signature">dispatch<wbr/>Event</span><span class="tsd-signature-symbol">(</span><span class="tsd-kind-parameter">event</span><span class="tsd-signature-symbol">)</span><span class="tsd-signature-symbol">: </span><span class="tsd-signature-type">boolean</span><a href="#dispatchEvent.dispatchEvent-1" aria-label="Permalink" class="tsd-anchor-icon"><svg viewBox="0 0 24 24"><use href="#icon-anchor"></use></svg></a></li>
 <li class="tsd-description">
-<div class="tsd-comment tsd-typography"><p>Dispatches a synthetic event event to target and returns true if either event&#39;s cancelable attribute value is false or its preventDefault() method was not invoked, and false otherwise.</p>
-<p><a href="https://developer.mozilla.org/docs/Web/API/EventTarget/dispatchEvent">MDN Reference</a></p>
-</div>
 <div class="tsd-parameters">
 <h4 class="tsd-parameters-title">Parameters</h4>
 <ul class="tsd-parameter-list">
 <li>
 <h5><span class="tsd-kind-parameter">event</span>: <span class="tsd-signature-type ">Event</span></h5></li></ul></div>
-<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">boolean</span></h4>
-<div class="tsd-comment tsd-typography"></div><aside class="tsd-sources">
+<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">boolean</span></h4><aside class="tsd-sources">
 <p>Inherited from CreateDestroy.dispatchEvent</p>
 <ul>
-<li>Defined in node_modules/typescript/lib/lib.dom.d.ts:8174</li></ul></aside></li></ul></section>
+<li>Defined in node_modules/@matrixai/events/dist/Evented.d.ts:11</li></ul></aside></li></ul></section>
 <section class="tsd-panel tsd-member tsd-is-protected"><a id="handleEventQUICClientClose" class="tsd-anchor"></a>
 <h3 class="tsd-anchor-link"><code class="tsd-tag ts-flagProtected">Protected</code> <span>handle<wbr/>EventQUICClient<wbr/>Close</span><a href="#handleEventQUICClientClose" aria-label="Permalink" class="tsd-anchor-icon"><svg viewBox="0 0 24 24"><use href="#icon-anchor"></use></svg></a></h3>
 <ul class="tsd-signatures tsd-is-protected">
@@ -492,9 +477,6 @@ <h3 class="tsd-anchor-link"><span>remove<wbr/>Event<wbr/>Listener</span><a href=
 <ul class="tsd-signatures tsd-is-inherited tsd-is-external">
 <li class="tsd-signature tsd-anchor-link" id="removeEventListener.removeEventListener-1"><span class="tsd-kind-call-signature">remove<wbr/>Event<wbr/>Listener</span><span class="tsd-signature-symbol">(</span><span class="tsd-kind-parameter">type</span>, <span class="tsd-kind-parameter">callback</span>, <span class="tsd-kind-parameter">options</span><span class="tsd-signature-symbol">?</span><span class="tsd-signature-symbol">)</span><span class="tsd-signature-symbol">: </span><span class="tsd-signature-type">void</span><a href="#removeEventListener.removeEventListener-1" aria-label="Permalink" class="tsd-anchor-icon"><svg viewBox="0 0 24 24"><use href="#icon-anchor"></use></svg></a></li>
 <li class="tsd-description">
-<div class="tsd-comment tsd-typography"><p>Removes the event listener in target&#39;s event listener list with the same type, callback, and options.</p>
-<p><a href="https://developer.mozilla.org/docs/Web/API/EventTarget/removeEventListener">MDN Reference</a></p>
-</div>
 <div class="tsd-parameters">
 <h4 class="tsd-parameters-title">Parameters</h4>
 <ul class="tsd-parameter-list">
@@ -504,11 +486,10 @@ <h5><span class="tsd-kind-parameter">type</span>: <span class="tsd-signature-typ
 <h5><span class="tsd-kind-parameter">callback</span>: <span class="tsd-signature-type">null</span><span class="tsd-signature-symbol"> | </span><span class="tsd-signature-type ">EventListenerOrEventListenerObject</span></h5></li>
 <li>
 <h5><code class="tsd-tag ts-flagOptional">Optional</code> <span class="tsd-kind-parameter">options</span>: <span class="tsd-signature-type">boolean</span><span class="tsd-signature-symbol"> | </span><span class="tsd-signature-type ">EventListenerOptions</span></h5></li></ul></div>
-<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">void</span></h4>
-<div class="tsd-comment tsd-typography"></div><aside class="tsd-sources">
+<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">void</span></h4><aside class="tsd-sources">
 <p>Inherited from CreateDestroy.removeEventListener</p>
 <ul>
-<li>Defined in node_modules/typescript/lib/lib.dom.d.ts:8180</li></ul></aside></li></ul></section>
+<li>Defined in node_modules/@matrixai/events/dist/Evented.d.ts:10</li></ul></aside></li></ul></section>
 <section class="tsd-panel tsd-member"><a id="createQUICClient" class="tsd-anchor"></a>
 <h3 class="tsd-anchor-link"><code class="tsd-tag ts-flagStatic">Static</code> <span>createQUICClient</span><a href="#createQUICClient" aria-label="Permalink" class="tsd-anchor-icon"><svg viewBox="0 0 24 24"><use href="#icon-anchor"></use></svg></a></h3>
 <ul class="tsd-signatures">
diff --git a/src/QUICClient.ts b/src/QUICClient.ts
@@ -34,7 +34,7 @@ interface QUICClient extends CreateDestroy {}
   eventDestroy: events.EventQUICClientDestroy,
   eventDestroyed: events.EventQUICClientDestroyed,
 })
-class QUICClient extends EventTarget {
+class QUICClient {
   /**
    * Creates a QUIC client.
    *
@@ -512,7 +512,6 @@ class QUICClient extends EventTarget {
     connection: QUICConnection;
     logger: Logger;
   }) {
-    super();
     this.logger = logger;
     this.socket = socket;
     this.isSocketShared = isSocketShared;
