icingadb-redis template is missing some variables that my current configuration has

[wilsons-doj]

I'm wondering if these features are no longer needed or if they should be added to the template? Thanks

diff -U0 <(curl -sL https://raw.githubusercontent.com/Icinga/ansible-collection-icinga/ae45fa9e7f84ce1a8d74fe772f81b95f66f0a67a/roles/icingadb_redis/templates/icingadb-redis.conf.j2 | grep -vE '^ *(#|\{(%-?|\{) |$)' | cut -d' ' -f1 | sort) <( grep -vE '^ *(#|\{(%-?|\{) |$)' /etc/icingadb-redis/icingadb-redis.conf | cut -d' ' -f1 | sort)

--- /dev/fd/63  2025-01-22 09:43:33.291764853 -0800
+++ /dev/fd/62  2025-01-22 09:43:33.291764853 -0800
@@ -0,0 +1 @@
+acllog-max-len
@@ -4,0 +6 @@
+aof-timestamp-enabled
@@ -5,0 +8 @@
+appenddirname
@@ -12,0 +16,3 @@
+client-output-buffer-limit
+client-output-buffer-limit
+daemonize
@@ -15,0 +22 @@
+disable-thp
@@ -17,2 +24,2 @@
-hash-max-ziplist-entries
-hash-max-ziplist-value
+hash-max-listpack-entries
+hash-max-listpack-value
@@ -20,0 +28 @@
+jemalloc-bg-thread
@@ -24,0 +33,2 @@
+lazyfree-lazy-user-del
+lazyfree-lazy-user-flush
@@ -26 +36 @@
-list-max-ziplist-size
+list-max-listpack-size
@@ -29 +38,0 @@
-lua-time-limit
@@ -31,0 +41,2 @@
+oom-score-adj
+oom-score-adj-values
@@ -33,0 +45 @@
+proc-title-template
@@ -36,0 +49 @@
+rdb-del-sync-files
@@ -38,0 +52 @@
+repl-diskless-load
@@ -40,0 +55 @@
+repl-diskless-sync-max-replicas
@@ -45,2 +59,0 @@
-requirepass
-save
@@ -47,0 +61 @@
+set-proc-title
@@ -53 +66,0 @@
-supervised
@@ -57,6 +70,2 @@
-tls-ca-cert-file
-tls-cert-file
-tls-key-file
-tls-port
-zset-max-ziplist-entries
-zset-max-ziplist-value
+zset-max-listpack-entries
+zset-max-listpack-value

[oxzi]

Thanks for creating this issue.

Recently, the packaging of icingadb-redis changed, now shipping both a "vanilla" baseline configuration file and an overwrite configuration file.

root@1e8c3af037a6:/# grep '^ExecStart=' /lib/systemd/system/icingadb-redis.service
ExecStart=/usr/bin/icingadb-redis-server /usr/share/icingadb-redis/icingadb-redis-systemd.conf

root@1e8c3af037a6:/# cat /usr/share/icingadb-redis/icingadb-redis-systemd.conf
# Defaults
port 6380
dir /var/lib/icingadb-redis

# DO NOT EDIT THE CURRENT FILE! Edit the following one instead if needed:
include /etc/icingadb-redis/icingadb-redis.conf

# Overrides needed for systemd unit
daemonize no
supervised systemd

This makes at least the following Ansible-configured option obsolete, as it will be overridden:
https://github.com/Icinga/ansible-collection-icinga/blob/ae45fa9e7f84ce1a8d74fe772f81b95f66f0a67a/roles/icingadb_redis/templates/icingadb-redis.conf.j2#L16

To not have to update the Redis configuration in this repository for each Redis update, I would suggest moving all overwrites into its own configuration file /etc/icingadb-redis/icingadb-redis.ansible.conf and include it in the last line of /etc/icingadb-redis/icingadb-redis.conf.

[wilsons-doj]

Thanks. I guess this is an invite for a pr based on the vanilla config and add a template that processes key/value pairs to create extra options?

[wilsons-doj]

PR submitted #361

[wilsons-doj]

Oh, I was thinking about taking the docs from the vanilla config and optionally inserting them or something, but it just didn't seem necessary. It's an easy fix if y'all want that though.