Apply clang-tidy fixes

Author: Spartan322

src/openvic-simulation/dataloader/Dataloader.cpp

@@ -149,7 +149,7 @@ Dataloader::path_vector_t Dataloader::_lookup_files_in_dir(
 	path_vector_t ret;
 	struct file_entry_t {
 		fs::path file;
-		fs::path const* root;
+		fs::path const* root = nullptr;
 	};
 	string_map_t<file_entry_t> found_files;
 	for (fs::path const& root : roots) {

src/openvic-simulation/dataloader/NodeTools.hpp

@@ -249,10 +249,10 @@ using namespace std::string_view_literals;
 				ONE_OR_MORE = _MUST_APPEAR | _CAN_REPEAT
 			} expected_count;
 			node_callback_t callback;
-			size_t count;
+			size_t count = 0;
 
 			dictionary_entry_t(expected_count_t new_expected_count, node_callback_t&& new_callback)
-				: expected_count { new_expected_count }, callback { MOV(new_callback) }, count { 0 } {}
+				: expected_count { new_expected_count }, callback { MOV(new_callback) } {}
 
 			constexpr bool must_appear() const {
 				return static_cast<uint8_t>(expected_count) & static_cast<uint8_t>(expected_count_t::_MUST_APPEAR);

src/openvic-simulation/defines/AIDefines.cpp

@@ -3,46 +3,7 @@
 using namespace OpenVic;
 using namespace OpenVic::NodeTools;
 
-AIDefines::AIDefines()
-  : colony_weight {},
-	administrator_weight {},
-	industryworker_weight {},
-	educator_weight {},
-	soldier_weight {},
-	soldier_fraction {},
-	capitalist_fraction {},
-	production_weight {},
-	spam_penalty {},
-	one_side_max_warscore {},
-	pop_project_investment_max_budget_factor {},
-	relation_limit_no_alliance_offer {},
-	naval_supply_penalty_limit {},
-	chance_build_railroad {},
-	chance_build_naval_base {},
-	chance_build_fort {},
-	chance_invest_pop_proj {},
-	chance_foreign_invest {},
-	tws_awareness_score_low_cap {},
-	tws_awareness_score_aspect {},
-	peace_base_reluctance {},
-	peace_time_duration {},
-	peace_time_factor {},
-	peace_time_factor_no_goals {},
-	peace_war_exhaustion_factor {},
-	peace_war_direction_factor {},
-	peace_war_direction_winning_mult {},
-	peace_force_balance_factor {},
-	peace_ally_base_reluctance_mult {},
-	peace_ally_time_mult {},
-	peace_ally_war_exhaustion_mult {},
-	peace_ally_war_direction_mult {},
-	peace_ally_force_balance_mult {},
-	aggression_base {},
-	aggression_unciv_bonus {},
-	fleet_size {},
-	min_fleets {},
-	max_fleets {},
-	time_before_disband {} {}
+AIDefines::AIDefines() {}
 
 std::string_view AIDefines::get_name() const {
 	return "ai";

src/openvic-simulation/defines/AIDefines.hpp

@@ -47,9 +47,9 @@ namespace OpenVic {
 		fixed_point_t PROPERTY(peace_ally_force_balance_mult);
 		fixed_point_t PROPERTY(aggression_base);
 		fixed_point_t PROPERTY(aggression_unciv_bonus);
-		size_t PROPERTY(fleet_size);
-		size_t PROPERTY(min_fleets);
-		size_t PROPERTY(max_fleets);
+		size_t PROPERTY(fleet_size, 0);
+		size_t PROPERTY(min_fleets, 0);
+		size_t PROPERTY(max_fleets, 0);
 		Timespan PROPERTY(time_before_disband);
 
 		AIDefines();

src/openvic-simulation/defines/CountryDefines.cpp

@@ -3,94 +3,7 @@
 using namespace OpenVic;
 using namespace OpenVic::NodeTools;
 
-CountryDefines::CountryDefines()
-  : nationalism_duration {},
-	rebels_hold_capital_success_duration {}, // NOT USED
-	rebel_success_duration {},
-	base_country_tax_efficiency {},
-	base_country_admin_efficiency {},
-	gold_to_cash_rate {},
-	gold_to_worker_pay_rate {},
-	great_power_rank {},
-	lose_great_power_grace_days {},
-	infamy_containment_limit {},
-	max_bureaucracy_percentage {},
-	bureaucracy_percentage_increment {},
-	min_crimefight_percent {},
-	max_crimefight_percent {},
-	admin_efficiency_crimefight_percent {},
-	conservative_increase_after_reform {},
-	campaign_event_base_duration {},
-	campaign_event_min_duration {}, // NOT USED
-	campaign_event_state_duration_modifier {}, // NOT USED
-	campaign_duration {},
-	secondary_power_rank {},
-	colony_to_state_prestige_gain {},
-	colonial_liferating {},
-	base_greatpower_daily_influence {},
-	ai_support_reform {},
-	base_monthly_diplopoints {},
-	diplomat_travel_duration {},
-	province_overseas_penalty {},
-	noncore_tax_penalty {},
-	base_tariff_efficiency {},
-	colony_formed_prestige {},
-	created_cb_valid_time {},
-	loyalty_boost_on_party_win {},
-	movement_radicalism_base {},
-	movement_radicalism_passed_reform_effect {},
-	movement_radicalism_nationalism_factor {},
-	suppression_points_gain_base {},
-	suppress_bureaucrat_factor {},
-	wrong_reform_militancy_impact {},
-	suppression_radicalisation_hit {},
-	country_investment_industrial_score_factor {},
-	unciv_tech_spread_max {},
-	unciv_tech_spread_min {},
-	min_delay_duration_between_reforms {},
-	economic_reform_uh_factor {},
-	military_reform_uh_factor {},
-	wrong_reform_radical_impact {},
-	tech_year_span {},
-	tech_factor_vassal {},
-	max_suppression {},
-	prestige_hit_on_break_country {},
-	min_mobilize_limit {},
-	pop_growth_country_cache_days {},
-	newspaper_printing_frequency {},
-	newspaper_timeout_period {},
-	newspaper_max_tension {},
-	naval_base_supply_score_base {},
-	naval_base_supply_score_empty {},
-	naval_base_non_core_supply_score {},
-	colonial_points_from_supply_factor {},
-	colonial_points_for_non_core_base {},
-	mobilization_speed_base {},
-	mobilization_speed_rails_mult {},
-	colonization_interest_lead {},
-	colonization_influence_lead {},
-	colonization_duration {},
-	colonization_days_between_investment {},
-	colonization_days_for_initial_investment {},
-	colonization_protectorate_province_maintenance {},
-	colonization_colony_province_maintenance {},
-	colonization_colony_industry_maintenance {},
-	colonization_colony_railway_maintenance {},
-	colonization_interest_cost_initial {},
-	colonization_interest_cost_neighbor_modifier {},
-	colonization_interest_cost {},
-	colonization_influence_cost {},
-	colonization_extra_guard_cost {},
-	colonization_release_dominion_cost {},
-	colonization_create_state_cost {},
-	colonization_create_protectorate_cost {},
-	colonization_create_colony_cost {},
-	colonization_colony_state_distance {},
-	colonization_influence_temperature_per_day {},
-	colonization_influence_temperature_per_level {},
-	party_loyalty_hit_on_war_loss {},
-	research_points_on_conquer_mult {},
-	max_research_points {} {}
+CountryDefines::CountryDefines() {}
 
 std::string_view CountryDefines::get_name() const {
 	return "country";

src/openvic-simulation/defines/CountryDefines.hpp

@@ -20,7 +20,7 @@ namespace OpenVic {
 		fixed_point_t PROPERTY(base_country_admin_efficiency);
 		fixed_point_t PROPERTY(gold_to_cash_rate);
 		fixed_point_t PROPERTY(gold_to_worker_pay_rate);
-		size_t PROPERTY(great_power_rank);
+		size_t PROPERTY(great_power_rank, 0);
 		Timespan PROPERTY(lose_great_power_grace_days);
 		fixed_point_t PROPERTY(infamy_containment_limit);
 		fixed_point_t PROPERTY(max_bureaucracy_percentage);
@@ -33,9 +33,9 @@ namespace OpenVic {
 		Timespan PROPERTY(campaign_event_min_duration); // NOT USED
 		Timespan PROPERTY(campaign_event_state_duration_modifier); // NOT USED
 		Timespan PROPERTY(campaign_duration);
-		size_t PROPERTY(secondary_power_rank);
+		size_t PROPERTY(secondary_power_rank, 0);
 		fixed_point_t PROPERTY(colony_to_state_prestige_gain);
-		ProvinceInstance::life_rating_t PROPERTY(colonial_liferating);
+		ProvinceInstance::life_rating_t PROPERTY(colonial_liferating, 0);
 		fixed_point_t PROPERTY(base_greatpower_daily_influence);
 		fixed_point_t PROPERTY(ai_support_reform);
 		fixed_point_t PROPERTY(base_monthly_diplopoints);
@@ -64,7 +64,7 @@ namespace OpenVic {
 		fixed_point_t PROPERTY(tech_factor_vassal);
 		fixed_point_t PROPERTY(max_suppression);
 		fixed_point_t PROPERTY(prestige_hit_on_break_country);
-		size_t PROPERTY(min_mobilize_limit);
+		size_t PROPERTY(min_mobilize_limit, 0);
 		Timespan PROPERTY(pop_growth_country_cache_days);
 		Timespan PROPERTY(newspaper_printing_frequency);
 		Timespan PROPERTY(newspaper_timeout_period);

src/openvic-simulation/defines/Define.cpp

@@ -5,7 +5,7 @@
 using namespace OpenVic;
 using namespace OpenVic::NodeTools;
 
-DefineManager::DefineManager() : start_date {}, end_date {} {}
+DefineManager::DefineManager() {}
 
 bool DefineManager::load_defines_file(ast::NodeCPtr root) {
 	bool ret = expect_dictionary_keys(