Skip to content

Commit 03bfcae

Browse files
committed
increment version
1 parent d62e09c commit 03bfcae

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@ All releases must adhere to [SemVer 2](https://semver.org/) naming convention an
1111
## PHPMarkup [Unreleased]
1212
Released: TBA. Notable changes:
1313

14+
## PHPMarkup 4.2.5
15+
Released: 2021-10-08. Notable changes:
16+
* Fixed: QA tests.
17+
1418
## PHPMarkup 4.2.4
1519
Released: 2021-10-08. Notable changes:
1620
* Added: InnerXML sanitization.

CONTRIBUTING.md

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,26 +4,25 @@ First off, thanks for taking the time to contribute!
44

55
For local package development use [Docker](https://www.docker.com/products/docker-desktop):
66

7-
Build Test container
7+
**Step 1**) Pull code and build Test container
88
```
99
git clone https://github.com/Ouxsoft/phpmarkup.git
1010
cd phpmarkup
1111
docker build --target test --tag phpmarkup:latest -f Dockerfile .
1212
docker run -it --mount type=bind,source="$(pwd)"/,target=/application/ phpmarkup:latest composer install
1313
```
1414

15-
Run Automated Unit Tests using local volume
16-
```
17-
docker run -it --mount type=bind,source="$(pwd)"/,target=/application/ phpmarkup:latest composer test
18-
```
15+
**Step 2**) Make code changes.
1916

20-
Run Automated Benchmark Tests using local volume
17+
**Step 3**) Run Automated QA using local volume
2118
```
22-
docker run -it --mount type=bind,source="$(pwd)"/,target=/application/ phpmarkup:latest ./vendor/bin/phpbench run tests/src/Benchmark --report=default
19+
docker run -it --mount type=bind,source="$(pwd)"/,target=/application/ phpmarkup:latest composer qa
2320
```
2421

25-
Rebuild Docs
22+
**Step 4**) Rebuild Docs
2623
```
2724
docker build --target docs --tag phpmarkup:docs-latest -f Dockerfile .
2825
docker run -it --mount type=bind,source="$(pwd)"/,target=/app/ phpmarkup:docs-latest bash -c "cd /app/docs && doxygen Doxyfile && doxyphp2sphinx Ouxsoft::PHPMarkup"
2926
```
27+
28+
**Step 5**) Submit PR

src/Engine.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -395,7 +395,7 @@ public function sanitizeXml(string $xml): string
395395
// strip args
396396
$xml = preg_replace("/<arg.*?>(.*)?<\/arg>/im", '', $xml);
397397
// strip INDEX_ATTRIBUTE
398-
$xml = $this->stripAttribute($xml, [self::INDEX_ATTRIBUTE]);
398+
$xml = $this->stripAttributes($xml, [self::INDEX_ATTRIBUTE]);
399399

400400
return $xml;
401401
}

0 commit comments

Comments
 (0)