refactor: endpoint + specs

Author: naqvis

spec/controllers/zones_spec.cr

@@ -25,7 +25,7 @@ module PlaceOS::Api
 
         result.success?.should be_true
         zones = Array(Hash(String, JSON::Any)).from_json(result.body)
-        zone_ids = zones.map { |z| z["id"].as_s }
+        zone_ids = zones.map(&.["id"].as_s)
         zone_ids.should contain(child1.id)
         zone_ids.should contain(child2.id)
 
@@ -62,7 +62,7 @@ module PlaceOS::Api
 
         result.success?.should be_true
         zones = Array(Hash(String, JSON::Any)).from_json(result.body)
-        zone_ids = zones.map { |z| z["id"].as_s }
+        zone_ids = zones.map(&.["id"].as_s)
         zone_ids.should contain(child1.id)
         zone_ids.should contain(child2.id)
         zone_ids.should_not contain(child3.id)

src/placeos-rest-api/controllers/zones.cr

@@ -94,10 +94,10 @@ module PlaceOS::Api
     ###############################################################################################
 
     # list the configured zones
-    @[AC::Route::GET("/", converters: {tags: ConvertStringArray})]
+    @[AC::Route::GET("/", converters: {tags: ConvertStringArray, parent_id: ConvertStringArray})]
     def index(
       @[AC::Param::Info(description: "only return zones who have this zone as a parent (supports comma-separated list)", example: "zone-1234,zone-5678")]
-      parent_id : String? = nil,
+      parent_id : Array(String)? = nil,
       @[AC::Param::Info(description: "return zones with particular tags", example: "building,level")]
       tags : Array(String)? = nil,
     ) : Array(::PlaceOS::Model::Zone)
@@ -107,7 +107,7 @@ module PlaceOS::Api
 
       # Limit results to the children of these parents (OR logic)
       if parent = parent_id
-        parent_ids = parent.split(',').map(&.strip).reject(&.empty?)
+        parent_ids = parent.map(&.strip).reject(&.empty?)
         query.should({
           "parent_id" => parent_ids,
         })