Move all super().destroy() calls to the end

Author: timhoffm

lib/matplotlib/backends/backend_nbagg.py

@@ -137,12 +137,12 @@ def _create_comm(self):
         return comm
 
     def destroy(self):
-        super().destroy()
         self._send_event('close')
         # need to copy comms as callbacks will modify this list
         for comm in list(self.web_sockets):
             comm.on_close()
         self.clearup_closed()
+        super().destroy()
 
     def clearup_closed(self):
         """Clear up any closed Comms."""

lib/matplotlib/backends/backend_qt.py

@@ -664,7 +664,6 @@ def show(self):
             self.window.raise_()
 
     def destroy(self, *args):
-        super().destroy()
         # check for qApp first, as PySide deletes it in its atexit handler
         if QtWidgets.QApplication.instance() is None:
             return
@@ -674,6 +673,7 @@ def destroy(self, *args):
         if self.toolbar:
             self.toolbar.destroy()
         self.window.close()
+        super().destroy()
 
     def get_window_title(self):
         return self.window.windowTitle()

lib/matplotlib/backends/backend_wx.py

@@ -1007,12 +1007,12 @@ def show(self):
     def destroy(self, *args):
         # docstring inherited
         _log.debug("%s - destroy()", type(self))
-        super().destroy()
         frame = self.frame
         if frame:  # Else, may have been already deleted, e.g. when closing.
             # As this can be called from non-GUI thread from plt.close use
             # wx.CallAfter to ensure thread safety.
             wx.CallAfter(frame.Close)
+        super().destroy()
 
     def full_screen_toggle(self):
         # docstring inherited