Adjust PauseAnimator fix and add 989onan as author

Extracts the private Float wrapper to an internal, generic Box wrapper

Author: Banane9

CommunityBugFixCollection/Box.cs

@@ -0,0 +1,24 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace CommunityBugFixCollection
+{
+    internal sealed class Box<T>
+        where T : struct
+    {
+        public T Value { get; set; }
+
+        public Box(T value)
+        {
+            Value = value;
+        }
+
+        public Box()
+        { }
+
+        public static implicit operator Box<T>(T value) => new(value);
+
+        public static implicit operator T(Box<T> box) => box.Value;
+    }
+}

CommunityBugFixCollection/CommunityBugFixCollection.csproj

@@ -10,7 +10,7 @@
     <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
     <PackageId>CommunityBugFixCollection</PackageId>
     <Title>Community Bug-Fix Collection</Title>
-    <Authors>Banane9; Nytra; art0007i; LeCloutPanda; goat; __Choco__; LJ</Authors>
+    <Authors>Banane9; Nytra; art0007i; LeCloutPanda; goat; __Choco__; LJ; 989onan</Authors>
     <Version>0.6.0-beta</Version>
     <Description>This MonkeyLoader mod for Resonite that fixes various small Resonite-issues that are still open.</Description>
     <PackageReadmeFile>README.md</PackageReadmeFile>

CommunityBugFixCollection/Contributors.cs

@@ -20,5 +20,7 @@ internal static class Contributors
         public static string[] LJ { get; } = ["LJ"];
 
         public static string[] Nytra { get; } = ["Nytra"];
+
+        public static string[] Onan { get; } = ["989onan"];
     }
 }

CommunityBugFixCollection/PauseAnimatorUpdates.cs

@@ -11,25 +11,9 @@ namespace CommunityBugFixCollection
     [HarmonyPatch(typeof(Animator), nameof(Animator.OnCommonUpdate))]
     internal sealed class PauseAnimatorUpdates : ResoniteBugFixMonkey<PauseAnimatorUpdates>
     {
-        public override IEnumerable<string> Authors => Contributors.Banane9;
+        private static readonly ConditionalWeakTable<Animator, Box<float>> _lastPositionByAnimator = new();
 
-        private class Float
-        {
-            public float Value;
-
-            public Float(float value)
-            {
-                Value = value;
-            }
-
-            public Float()
-            {
-                Value = 0f;
-            }
-        }
-
-
-        private static readonly ConditionalWeakTable<Animator, Float> _hasChangedPlayhead = new();
+        public override IEnumerable<string> Authors { get; } = [.. Contributors.Banane9, .. Contributors.Onan];
 
         private static bool Prefix(Animator __instance)
         {
@@ -41,11 +25,17 @@ private static bool Prefix(Animator __instance)
             if (!__instance._fieldMappersValid)
                 __instance.GenerateFieldMappers();
 
+            if (!_lastPositionByAnimator.TryGetValue(__instance, out var lastPosition))
+            {
+                // Make sure that initial state is always applied,
+                // since playback position can't be < 0
+                lastPosition = -1;
+                _lastPositionByAnimator.Add(__instance, lastPosition);
+            }
 
-            if (_hasChangedPlayhead.GetOrCreateValue(__instance).Value != __instance._playback.Position)
+            if (lastPosition != __instance.Position)
             {
-                var position = __instance.Position;
-                _hasChangedPlayhead.GetOrCreateValue(__instance).Value = __instance.Position;
+                var position = lastPosition.Value = __instance.Position;
 
                 foreach (var fieldMapper in __instance._fieldMappers)
                     fieldMapper.Set(position);
@@ -54,6 +44,4 @@ private static bool Prefix(Animator __instance)
             return false;
         }
     }
-
-    
 }