fix: flaky tests fix (#2037)

## Description
This PR aims to fix flaky tests


## Motivation
Background on use case, changes needed


## Fixes:
Please provide a list of the fixes implemented in this PR

* Items added


## Changes:
Please provide a list of the changes implemented by this PR

* changes made


## Tests included
- [ ] Included for each change/fix?
- [ ] Passing? (Merge will not be approved unless this is checked) 

## Documentation
- [ ] swagger documentation updated \[required\]
- [ ] official documentation updated \[nice-to-have\]

### official documentation info
If you have updated the official documentation, please provide PR # and
URL of the pages where the updates are included

## Backend version
- [ ] Does it require a specific version of the backend
- which version of the backend is required:

## Summary by Sourcery

Tests:
- Add a comment to mark the pre-configured conditions test as flaky in
the datasets-general Cypress suite

Author: Junjiequan

.github/workflows/test.yml

@@ -129,6 +129,7 @@ jobs:
         uses: cypress-io/github-action@v6
         with:
           config-file: cypress.config.ts
+          browser: chrome
           install-command: npm install --omit peer
       - name: docker logs
         if: ${{ failure() }}

cypress/e2e/datasets/datasets-general.cy.js

@@ -231,37 +231,36 @@ describe("Datasets general", () => {
           },
         },
         isPublished: true,
-      }).then(() => {
-        cy.readFile("CI/e2e/frontend.config.e2e.json").then((baseConfig) => {
-          const testConfig = {
-            ...baseConfig,
-            defaultDatasetsListSettings: {
-              ...baseConfig.defaultDatasetsListSettings,
-              conditions: [
-                {
-                  condition: {
-                    lhs: "outgassing_values_after_1h",
-                    relation: "GREATER_THAN",
-                    rhs: 1,
-                    unit: "",
-                    unitsOptions: [
-                      "mbar l/s/cm^2",
-                      "Pa m^3/s/m^2",
-                      "bar m^3/s/m^2",
-                    ],
-                  },
-                  enabled: false,
+      });
+      cy.readFile("CI/e2e/frontend.config.e2e.json").then((baseConfig) => {
+        const testConfig = {
+          ...baseConfig,
+          defaultDatasetsListSettings: {
+            ...baseConfig.defaultDatasetsListSettings,
+            conditions: [
+              {
+                condition: {
+                  lhs: "outgassing_values_after_1h",
+                  relation: "GREATER_THAN",
+                  rhs: 1,
+                  unit: "",
+                  unitsOptions: [
+                    "mbar l/s/cm^2",
+                    "Pa m^3/s/m^2",
+                    "bar m^3/s/m^2",
+                  ],
                 },
-              ],
-            },
-          };
-
-          cy.intercept("GET", "**/admin/config", testConfig).as("getConfig");
-          cy.visit("/datasets");
-          cy.wait("@getConfig", { timeout: 20000 });
-          cy.finishedLoading();
-        });
+                enabled: false,
+              },
+            ],
+          },
+        };
+
+        cy.intercept("GET", "**/admin/config", testConfig).as("getConfig");
       });
+      cy.visit("/datasets");
+      cy.wait("@getConfig", { timeout: 20000 });
+      cy.finishedLoading();
     });
 
     it("should display limited options in units dropdown", () => {
@@ -319,7 +318,7 @@ describe("Datasets general", () => {
 
         cy.intercept("GET", "**/admin/config", testConfig).as("getConfig");
         cy.visit("/datasets");
-        cy.wait("@getConfig", { timeout: 10000 });
+        cy.wait("@getConfig");
         cy.finishedLoading();
       });
     });
@@ -342,38 +341,37 @@ describe("Datasets general", () => {
           extra_entry_end_time: { type: "number", value: 2, unit: "" },
         },
         isPublished: true,
-      }).then(() => {
-        cy.readFile("CI/e2e/frontend.config.e2e.json").then((baseConfig) => {
-          const relationsToTest = [
-            { relation: "GREATER_THAN", rhs: 1 },
-            { relation: "LESS_THAN", rhs: 3 },
-            { relation: "EQUAL_TO_NUMERIC", rhs: 2 },
-            { relation: "GREATER_THAN_OR_EQUAL", rhs: 2 },
-            { relation: "LESS_THAN_OR_EQUAL", rhs: 2 },
-            { relation: "RANGE", rhs: [1, 3] },
-          ];
-          const testConfig = {
-            ...baseConfig,
-            defaultDatasetsListSettings: {
-              ...baseConfig.defaultDatasetsListSettings,
-              conditions: relationsToTest.map(({ relation, rhs }) => ({
-                condition: {
-                  lhs: "extra_entry_end_time",
-                  relation,
-                  rhs,
-                  unit: "",
-                },
-                enabled: true,
-              })),
-            },
-          };
-
-          cy.intercept("GET", "**/admin/config", testConfig).as("getConfig");
-          cy.visit("/datasets");
-          cy.wait("@getConfig", { timeout: 20000 });
-          cy.finishedLoading();
-        });
       });
+
+      cy.readFile("CI/e2e/frontend.config.e2e.json").then((baseConfig) => {
+        const relationsToTest = [
+          { relation: "GREATER_THAN", rhs: 1 },
+          { relation: "LESS_THAN", rhs: 3 },
+          { relation: "EQUAL_TO_NUMERIC", rhs: 2 },
+          { relation: "GREATER_THAN_OR_EQUAL", rhs: 2 },
+          { relation: "LESS_THAN_OR_EQUAL", rhs: 2 },
+          { relation: "RANGE", rhs: [1, 3] },
+        ];
+        const testConfig = {
+          ...baseConfig,
+          defaultDatasetsListSettings: {
+            ...baseConfig.defaultDatasetsListSettings,
+            conditions: relationsToTest.map(({ relation, rhs }) => ({
+              condition: {
+                lhs: "extra_entry_end_time",
+                relation,
+                rhs,
+                unit: "",
+              },
+              enabled: true,
+            })),
+          },
+        };
+
+        cy.intercept("GET", "**/admin/config", testConfig).as("getConfig");
+      });
+      cy.visit("/datasets");
+      cy.wait("@getConfig");
     });
 
     it("should check if pre-configured conditions are applied", () => {

cypress/e2e/mainPage/main-page.cy.js

@@ -67,9 +67,6 @@ describe("Main Page", () => {
 
   describe("Main page configuration as authenticated user", () => {
     it("should visit main page correctly configured", () => {
-      const username = Cypress.env("username");
-      const password = Cypress.env("password");
-
       cy.visit("/");
       cy.finishedLoading();
 
@@ -94,7 +91,7 @@ describe("Main Page", () => {
         "button.mat-mdc-menu-item:nth-child(2) > span:nth-child(2) > span:nth-child(1)",
       ).should("contain", "Files");
 
-      cy.get("div.main-menu").click();
+      cy.get("body").type("{esc}");
 
       cy.get('[data-cy="login-button"]').should("not.exist");
       cy.get(".user-button").should("exist");

cypress/e2e/published-data/published-data.cy.js

@@ -140,7 +140,10 @@ describe("Datasets general", () => {
 
       cy.isLoading();
 
-      cy.get(".dataset-table mat-row input[type='checkbox']").last().click();
+      cy.get(".dataset-table mat-row input[type='checkbox']")
+        .last()
+        .and("not.be.disabled")
+        .click();
 
       cy.get("#addToBatchButton").click();