Skip to content

using subset_tunables leads to bounds error with ForwardDiff for a DAE #3925

@SebastianM-C

Description

@SebastianM-C

Describe the bug 🐞

Using subset_tunables for a DAE seems to cause out of bounds issues in ForwardDiff. I'm not sure yet what is it about the system that leads to the error, I tried with a simpler system, like rober, but that worked.

Expected behavior

No AD issues.

Minimal Reproducible Example 👇

using ModelingToolkit
using ModelingToolkit: D_nounits as D, t_nounits as t
using ModelingToolkitStandardLibrary.Electrical, ModelingToolkitStandardLibrary.Blocks
using SymbolicIndexingInterface
using OrdinaryDiffEqRosenbrock, OrdinaryDiffEqNonlinearSolve
using DifferentiationInterface: DifferentiationInterface as DI
using ADTypes, ForwardDiff

function circuit_model()
    # V = 10.0
    @named resistor1 = Resistor(R=5.0)
    @named resistor2 = Resistor(R=2.0)
    @named capacitor1 = Capacitor(C=2.4)
    @named capacitor2 = Capacitor(C=60.0)
    @named source = Voltage()
    @named input_signal = Sine(frequency=1.0)
    @named ground = Ground()
    @named ampermeter = CurrentSensor()

    eqs = [connect(input_signal.output, source.V)
        connect(source.p, capacitor1.n, capacitor2.n)
        connect(source.n, resistor1.p, resistor2.p, ground.g)
        connect(resistor1.n, capacitor1.p, ampermeter.n)
        connect(resistor2.n, capacitor2.p, ampermeter.p)]

    @named circuit_model = System(eqs, t,
        systems=[
            resistor1, resistor2, capacitor1, capacitor2,
            source, input_signal, ground, ampermeter
        ])
end

model = circuit_model()
sys = mtkcompile(model)

tunable_parameters(sys)

sub_sys = subset_tunables(sys, [sys.capacitor2.C])

tunable_parameters(sub_sys)

prob = ODEProblem(sub_sys, [sys.capacitor2.v => 0.0], (0, 3.)) # if we replace with sys, it works

setter = setsym_oop(prob, [sys.capacitor2.C]);

function loss(x, ps)
    setter, prob = ps
    u0, p = setter(prob, x)
    new_prob = remake(prob; u0, p)
    sol = solve(new_prob, Rodas5P())
    sum(sol)
end

loss([3.], (setter, prob))

DI.gradient(Base.Fix2(loss, (setter, prob)), AutoForwardDiff(), [3.])

# [0.1488262706875249] with sys

Error & Stacktrace ⚠️

ERROR: BoundsError: attempt to access 0-element Vector{ForwardDiff.Dual{ForwardDiff.Tag{Base.Fix2{typeof(loss), Tuple{SymbolicIndexingInterface.FullSetter{Nothing, SymbolicIndexingInterface.OOPSetter{false, System, Vector{ModelingToolkit.ParameterIndex{SciMLStructures.Tunable, Int64}}}, Vector{Int64}, Vector{Int64}}, ODEProblem{Vector{Float64}, Tuple{Float64, Float64}, true, MTKParameters{Vector{Float64}, Vector{Float64}, Tuple{}, Tuple{Vector{Float64}}, Tuple{}, Tuple{}}, ODEFunction{true, SciMLBase.FullSpecialize, ModelingToolkit.GeneratedFunctionWrapper{(2, 3, true), RuntimeGeneratedFunctions.RuntimeGeneratedFunction{(:__mtk_arg_1, :___mtkparameters___, :t), ModelingToolkit.var"#_RGF_ModTag", ModelingToolkit.var"#_RGF_ModTag", (0x4a958fe5, 0xb6de9619, 0x0cc458c5, 0x5d2d4807, 0x17ca1973), Nothing}, RuntimeGeneratedFunctions.RuntimeGeneratedFunction{(:ˍ₋out, :__mtk_arg_1, :___mtkparameters___, :t), ModelingToolkit.var"#_RGF_ModTag", ModelingToolkit.var"#_RGF_ModTag", (0x6e3d7e66, 0x9b1e1f65, 0xa8f8936c, 0x48723c58, 0x40b0d81e), Nothing}}, LinearAlgebra.Diagonal{Float64, Vector{Float64}}, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, ModelingToolkit.ObservedFunctionCache{System}, Nothing, System, SciMLBase.OverrideInitData{NonlinearProblem{Vector{Float64}, true, MTKParameters{Vector{Float64}, StaticArraysCore.SizedVector{0, Float64, Vector{Float64}}, Tuple{}, Tuple{Vector{Float64}}, Tuple{}, Tuple{}}, NonlinearFunction{true, SciMLBase.FullSpecialize, ModelingToolkit.GeneratedFunctionWrapper{(2, 2, true), RuntimeGeneratedFunctions.RuntimeGeneratedFunction{(:__mtk_arg_1, :___mtkparameters___), ModelingToolkit.var"#_RGF_ModTag", ModelingToolkit.var"#_RGF_ModTag", (0xefcec2bc, 0x8b95e632, 0x54d5a048, 0xce971a10, 0x2c031cdf), Nothing}, RuntimeGeneratedFunctions.RuntimeGeneratedFunction{(:ˍ₋out, :__mtk_arg_1, :___mtkparameters___), ModelingToolkit.var"#_RGF_ModTag", ModelingToolkit.var"#_RGF_ModTag", (0xbb7542fd, 0xb4c34c00, 0x9c2f4327, 0xdad6164a, 0x3d81d0ec), Nothing}}, LinearAlgebra.UniformScaling{Bool}, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, ModelingToolkit.ObservedFunctionCache{System}, Nothing, System, Nothing, Nothing}, Base.Pairs{Symbol, Union{}, Nothing, @NamedTuple{}}, SciMLBase.StandardNonlinearProblem}, typeof(ModelingToolkit.update_initializeprob!), ComposedFunction{ComposedFunction{typeof(identity), typeof(ModelingToolkit.safe_float)}, SymbolicIndexingInterface.TimeIndependentObservedFunction{ModelingToolkit.GeneratedFunctionWrapper{(2, 2, true), RuntimeGeneratedFunctions.RuntimeGeneratedFunction{(:__mtk_arg_1, :___mtkparameters___), ModelingToolkit.var"#_RGF_ModTag", ModelingToolkit.var"#_RGF_ModTag", (0x701228fa, 0xc36cdf38, 0xf3d3de00, 0xf1715dbf, 0x4f4fa3fe), Nothing}, RuntimeGeneratedFunctions.RuntimeGeneratedFunction{(:ˍ₋out, :__mtk_arg_1, :___mtkparameters___), ModelingToolkit.var"#_RGF_ModTag", ModelingToolkit.var"#_RGF_ModTag", (0x63d44048, 0xf3a71f90, 0xe0141661, 0xc71a0f12, 0x9b1bea1b), Nothing}}}}, ModelingToolkit.var"#initprobpmap_split#929"{ModelingToolkit.var"#_getter#925"{Tuple{ComposedFunction{ModelingToolkit.PConstructorApplicator{typeof(identity)}, ModelingToolkit.ObservedWrapper{false, ModelingToolkit.GeneratedFunctionWrapper{(2, 2, true), RuntimeGeneratedFunctions.RuntimeGeneratedFunction{(:__mtk_arg_1, :___mtkparameters___), ModelingToolkit.var"#_RGF_ModTag", ModelingToolkit.var"#_RGF_ModTag", (0x7adb7991, 0x24e4c4a0, 0xbae59bd5, 0x96e594cb, 0x2b624d7b), Nothing}, RuntimeGeneratedFunctions.RuntimeGeneratedFunction{(:ˍ₋out, :__mtk_arg_1, :___mtkparameters___), ModelingToolkit.var"#_RGF_ModTag", ModelingToolkit.var"#_RGF_ModTag", (0xcc979e39, 0x9cdf9eaf, 0x4269bf54, 0xd90a9d70, 0x23795037), Nothing}}}}, ComposedFunction{ModelingToolkit.PConstructorApplicator{typeof(identity)}, ModelingToolkit.ObservedWrapper{false, ModelingToolkit.GeneratedFunctionWrapper{(2, 2, true), RuntimeGeneratedFunctions.RuntimeGeneratedFunction{(:__mtk_arg_1, :___mtkparameters___), ModelingToolkit.var"#_RGF_ModTag", ModelingToolkit.var"#_RGF_ModTag", (0x49618b0a, 0xf913a713, 0x5dabdb0e, 0x23ed2361, 0x2301e093), Nothing}, RuntimeGeneratedFunctions.RuntimeGeneratedFunction{(:ˍ₋out, :__mtk_arg_1, :___mtkparameters___), ModelingToolkit.var"#_RGF_ModTag", ModelingToolkit.var"#_RGF_ModTag", (0x120b508e, 0xe68ad2c8, 0xf64c394b, 0xf892e8af, 0xeeb3a1ec), Nothing}}}}, Returns{Tuple{}}, ComposedFunction{Base.Fix1{typeof(broadcast), ModelingToolkit.PConstructorApplicator{typeof(identity)}}, SymbolicIndexingInterface.MultipleGetters{Nothing, Tuple{SymbolicIndexingInterface.MultipleGetters{Nothing, Vector{SymbolicIndexingInterface.GetParameterIndex{ModelingToolkit.ParameterIndex{SciMLStructures.Constants, Tuple{Int64, Int64}}}}}}}}, Returns{Tuple{}}}}}, ModelingToolkit.InitializationMetadata{ModelingToolkit.ReconstructInitializeprob{ModelingToolkit.var"#_getter#925"{Tuple{ComposedFunction{ModelingToolkit.PConstructorApplicator{typeof(identity)}, ModelingToolkit.ObservedWrapper{true, ModelingToolkit.GeneratedFunctionWrapper{(2, 3, true), RuntimeGeneratedFunctions.RuntimeGeneratedFunction{(:__mtk_arg_1, :___mtkparameters___, :t), ModelingToolkit.var"#_RGF_ModTag", ModelingToolkit.var"#_RGF_ModTag", (0x71085f51, 0x954f0eba, 0xb00e0553, 0xa24119d0, 0xb467312f), Nothing}, RuntimeGeneratedFunctions.RuntimeGeneratedFunction{(:ˍ₋out, :__mtk_arg_1, :___mtkparameters___, :t), ModelingToolkit.var"#_RGF_ModTag", ModelingToolkit.var"#_RGF_ModTag", (0x53919177, 0xb501ec4f, 0x735da260, 0xc5c8429f, 0x54edd9f0), Nothing}}}}, Returns{StaticArraysCore.SizedVector{0, Float64, Vector{Float64}}}, Returns{Tuple{}}, ComposedFunction{Base.Fix1{typeof(broadcast), ModelingToolkit.PConstructorApplicator{typeof(identity)}}, SymbolicIndexingInterface.MultipleParametersGetter{SymbolicIndexingInterface.IndexerNotTimeseries, Tuple{SymbolicIndexingInterface.MultipleParametersGetter{SymbolicIndexingInterface.IndexerNotTimeseries, Vector{SymbolicIndexingInterface.GetParameterIndex{ModelingToolkit.ParameterIndex{SciMLStructures.Constants, Tuple{Int64, Int64}}}}, Nothing}}, Nothing}}, Returns{Tuple{}}}}, ComposedFunction{typeof(identity), SymbolicIndexingInterface.TimeDependentObservedFunction{ContinuousTimeseries, ModelingToolkit.GeneratedFunctionWrapper{(2, 3, true), RuntimeGeneratedFunctions.RuntimeGeneratedFunction{(:__mtk_arg_1, :___mtkparameters___, :t), ModelingToolkit.var"#_RGF_ModTag", ModelingToolkit.var"#_RGF_ModTag", (0xe977bfde, 0xb09e2a6f, 0xd56f4513, 0xd5275597, 0x186a4594), Nothing}, RuntimeGeneratedFunctions.RuntimeGeneratedFunction{(:ˍ₋out, :__mtk_arg_1, :___mtkparameters___, :t), ModelingToolkit.var"#_RGF_ModTag", ModelingToolkit.var"#_RGF_ModTag", (0xd74f0623, 0x7f1f65d1, 0x34d18205, 0xb0cdf94e, 0x588a8a51), Nothing}}, true}}}, ModelingToolkit.GetUpdatedU0{SymbolicIndexingInterface.TimeIndependentObservedFunction{ModelingToolkit.GeneratedFunctionWrapper{(2, 2, true), RuntimeGeneratedFunctions.RuntimeGeneratedFunction{(:__mtk_arg_1, :___mtkparameters___), ModelingToolkit.var"#_RGF_ModTag", ModelingToolkit.var"#_RGF_ModTag", (0x064c3e1c, 0xb533c8a0, 0xbf2a929d, 0xfd4532f8, 0x2b6a049b), Nothing}, RuntimeGeneratedFunctions.RuntimeGeneratedFunction{(:ˍ₋out, :__mtk_arg_1, :___mtkparameters___), ModelingToolkit.var"#_RGF_ModTag", ModelingToolkit.var"#_RGF_ModTag", (0x00c4c052, 0x03a8819b, 0x97238ec6, 0x5c501afe, 0xacb7a5ed), Nothing}}}, SymbolicIndexingInterface.MultipleParametersGetter{SymbolicIndexingInterface.IndexerNotTimeseries, Vector{SymbolicIndexingInterface.GetParameterIndex{ModelingToolkit.ParameterIndex{SciMLStructures.Initials, Int64}}}, Nothing}}, ModelingToolkit.SetInitialUnknowns{SymbolicIndexingInterface.MultipleSetters{Vector{SymbolicIndexingInterface.ParameterHookWrapper{SymbolicIndexingInterface.SetParameterIndex{ModelingToolkit.ParameterIndex{SciMLStructures.Initials, Int64}}, SymbolicUtils.BasicSymbolic{Real}}}}}}, Val{true}}, Nothing}, Base.Pairs{Symbol, Union{}, Nothing, @NamedTuple{}}, SciMLBase.StandardODEProblem}}}, Float64}, Float64, 1}} at index [2]
Stacktrace:
  [1] throw_boundserror(A::Vector{ForwardDiff.Dual{ForwardDiff.Tag{Base.Fix2{}, Float64}, Float64, 1}}, I::Tuple{Int64})
    @ Base ./essentials.jl:15
  [2] getindex
    @ ./essentials.jl:919 [inlined]
  [3] getindex
    @ ~/.julia/packages/StaticArrays/DsPgf/src/SizedArray.jl:92 [inlined]
  [4] macro expansion
    @ ~/.julia/packages/SymbolicUtils/N76BL/src/code.jl:411 [inlined]
  [5] macro expansion
    @ ~/.julia/packages/Symbolics/FHhXE/src/build_function.jl:366 [inlined]
  [6] macro expansion
    @ ~/.julia/packages/RuntimeGeneratedFunctions/2SjTC/src/RuntimeGeneratedFunctions.jl:161 [inlined]
  [7] macro expansion
    @ ./none:0 [inlined]
  [8] generated_callfunc
    @ ./none:0 [inlined]
  [9] (::RuntimeGeneratedFunctions.RuntimeGeneratedFunction{…})(::Vector{…}, ::MTKParameters{…})
    @ RuntimeGeneratedFunctions ~/.julia/packages/RuntimeGeneratedFunctions/2SjTC/src/RuntimeGeneratedFunctions.jl:148
 [10] macro expansion
    @ ~/.julia/packages/ModelingToolkit/H1QXB/src/systems/codegen_utils.jl:-1 [inlined]
 [11] _generated_call
    @ ~/.julia/packages/ModelingToolkit/H1QXB/src/systems/codegen_utils.jl:353 [inlined]
 [12] GeneratedFunctionWrapper
    @ ~/.julia/packages/ModelingToolkit/H1QXB/src/systems/codegen_utils.jl:350 [inlined]
 [13] TimeIndependentObservedFunction
    @ ~/.julia/packages/SymbolicIndexingInterface/sZ3a9/src/state_indexing.jl:142 [inlined]
 [14] AbstractStateGetIndexer
    @ ~/.julia/packages/SymbolicIndexingInterface/sZ3a9/src/value_provider_interface.jl:166 [inlined]
 [15] (::ModelingToolkit.GetUpdatedU0{…})(prob::ODEProblem{…}, initprob::NonlinearProblem{…})
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/H1QXB/src/systems/problem_utils.jl:1057
 [16] get_updated_symbolic_problem(sys::System, prob::ODEProblem{…}; u0::Vector{…}, p::MTKParameters{…}, kw::@Kwargs{})
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/H1QXB/src/systems/nonlinear/initializesystem.jl:810
 [17] get_updated_symbolic_problem
    @ ~/.julia/packages/ModelingToolkit/H1QXB/src/systems/nonlinear/initializesystem.jl:782 [inlined]
 [18] get_concrete_problem(prob::ODEProblem{…}, isadapt::Bool; kwargs::@Kwargs{})
    @ DiffEqBase ~/.julia/packages/DiffEqBase/dqv41/src/solve.jl:760
 [19] get_concrete_problem
    @ ~/.julia/packages/DiffEqBase/dqv41/src/solve.jl:758 [inlined]
 [20] solve_up(prob::ODEProblem{…}, sensealg::Nothing, u0::Vector{…}, p::MTKParameters{…}, args::Rodas5P{…}; originator::SciMLBase.ChainRulesOriginator, kwargs::@Kwargs{})
    @ DiffEqBase ~/.julia/packages/DiffEqBase/dqv41/src/solve.jl:677
 [21] solve_up
    @ ~/.julia/packages/DiffEqBase/dqv41/src/solve.jl:660 [inlined]
 [22] solve(prob::ODEProblem{…}, args::Rodas5P{…}; sensealg::Nothing, u0::Nothing, p::Nothing, wrap::Val{…}, kwargs::@Kwargs{})
    @ DiffEqBase ~/.julia/packages/DiffEqBase/dqv41/src/solve.jl:555
 [23] solve(prob::ODEProblem{…}, args::Rodas5P{…})
    @ DiffEqBase ~/.julia/packages/DiffEqBase/dqv41/src/solve.jl:545
 [24] loss(x::Vector{ForwardDiff.Dual{…}}, ps::Tuple{SymbolicIndexingInterface.FullSetter{…}, ODEProblem{…}})
    @ Main ~/dev/subset_tunables_bug.jl:118
 [25] Fix
    @ ./operators.jl:1194 [inlined]
 [26] vector_mode_dual_eval!
    @ ~/.julia/packages/ForwardDiff/fKFOu/src/apiutils.jl:24 [inlined]
 [27] vector_mode_gradient(f::Base.Fix2{…}, x::Vector{…}, cfg::ForwardDiff.GradientConfig{…})
    @ ForwardDiff ~/.julia/packages/ForwardDiff/fKFOu/src/gradient.jl:98
 [28] gradient
    @ ~/.julia/packages/ForwardDiff/fKFOu/src/gradient.jl:20 [inlined]
 [29] gradient(f::Base.Fix2{…}, x::Vector{…}, cfg::ForwardDiff.GradientConfig{…})
    @ ForwardDiff ~/.julia/packages/ForwardDiff/fKFOu/src/gradient.jl:17
 [30] gradient(f::Base.Fix2{typeof(loss), Tuple{SymbolicIndexingInterface.FullSetter{…}, ODEProblem{…}}}, x::Vector{Float64})
    @ ForwardDiff ~/.julia/packages/ForwardDiff/fKFOu/src/gradient.jl:17
 [31] gradient(::Base.Fix2{typeof(loss), Tuple{…}}, ::AutoForwardDiff{nothing, Nothing}, ::Vector{Float64})
    @ DifferentiationInterfaceForwardDiffExt ~/.julia/packages/DifferentiationInterface/TuoGH/ext/DifferentiationInterfaceForwardDiffExt/onearg.jl:352
 [32] top-level scope
    @ ~/dev/subset_tunables_bug.jl:124
Some type information was truncated. Use `show(err)` to see complete types.

Environment (please complete the following information):

  • Output of using Pkg; Pkg.status()
(jl_bDvWBM) pkg> st
Status `/tmp/jl_bDvWBM/Project.toml`
  [47edcb42] ADTypes v1.17.0
  [a0c0ee7d] DifferentiationInterface v0.7.7
  [f6369f11] ForwardDiff v1.2.0
  [961ee093] ModelingToolkit v10.22.0
  [16a59e39] ModelingToolkitStandardLibrary v2.25.0
  [127b3ac7] OrdinaryDiffEqNonlinearSolve v1.14.1
  [43230ef6] OrdinaryDiffEqRosenbrock v1.17.0
  [2efcf032] SymbolicIndexingInterface v0.3.43
  • Output of using Pkg; Pkg.status(; mode = PKGMODE_MANIFEST)
(jl_bDvWBM) pkg> st -m
Status `/tmp/jl_bDvWBM/Manifest.toml`
  [47edcb42] ADTypes v1.17.0
  [1520ce14] AbstractTrees v0.4.5
  [7d9f7c33] Accessors v0.1.42
  [79e6a3ab] Adapt v4.3.0
  [66dad0bd] AliasTables v1.1.3
  [ec485272] ArnoldiMethod v0.4.0
  [4fba245c] ArrayInterface v7.20.0
  [4c555306] ArrayLayouts v1.11.2
  [e2ed5e7c] Bijections v0.2.2
  [62783981] BitTwiddlingConvenienceFunctions v0.1.6
  [8e7c35d0] BlockArrays v1.7.2
  [70df07ce] BracketingNonlinearSolve v1.3.0
  [2a0fbf3d] CPUSummary v0.2.7
  [d360d2e6] ChainRulesCore v1.26.0
  [fb6a15b2] CloseOpenIntervals v0.1.13
⌅ [861a8166] Combinatorics v1.0.2
  [a80b9123] CommonMark v0.9.1
  [38540f10] CommonSolve v0.2.4
  [bbf7d656] CommonSubexpressions v0.3.1
  [f70d9fcc] CommonWorldInvalidations v1.0.0
  [34da2185] Compat v4.18.0
  [b152e2b5] CompositeTypes v0.1.4
  [a33af91c] CompositionsBase v0.1.2
  [2569d6c7] ConcreteStructs v0.2.3
  [187b0558] ConstructionBase v1.6.0
  [adafc99b] CpuId v0.3.1
  [9a962f9c] DataAPI v1.16.0
⌅ [864edb3b] DataStructures v0.18.22
  [2b5f629d] DiffEqBase v6.189.1
  [459566f4] DiffEqCallbacks v4.9.0
  [77a26b50] DiffEqNoiseProcess v5.24.1
  [163ba53b] DiffResults v1.1.0
  [b552c78f] DiffRules v1.15.1
  [a0c0ee7d] DifferentiationInterface v0.7.7
  [8d63f2c5] DispatchDoctor v0.4.26
  [31c24e10] Distributions v0.25.120
  [ffbed154] DocStringExtensions v0.9.5
  [5b8099bc] DomainSets v0.7.16
  [7c1d4256] DynamicPolynomials v0.6.3
  [06fc5a27] DynamicQuantities v1.8.0
  [4e289a0a] EnumX v1.0.5
  [f151be2c] EnzymeCore v0.8.13
  [e2ba6199] ExprTools v0.1.10
  [55351af7] ExproniconLite v0.10.14
  [7034ab61] FastBroadcast v0.3.5
  [9aa1b823] FastClosures v0.3.2
  [a4df4552] FastPower v1.1.3
  [1a297f60] FillArrays v1.14.0
  [64ca27bc] FindFirstFunctions v1.4.2
  [6a86dc24] FiniteDiff v2.28.1
  [1fa38f19] Format v1.3.7
  [f6369f11] ForwardDiff v1.2.0
  [069b7b12] FunctionWrappers v1.1.3
  [77dc65aa] FunctionWrappersWrappers v0.1.3
  [d9f16b24] Functors v0.5.2
  [46192b85] GPUArraysCore v0.2.0
  [c27321d9] Glob v1.3.1
  [86223c79] Graphs v1.13.1
  [34004b35] HypergeometricFunctions v0.3.28
  [615f187c] IfElse v0.1.1
  [3263718b] ImplicitDiscreteSolve v1.2.0
  [d25df0c9] Inflate v0.1.5
  [18e54dd8] IntegerMathUtils v0.1.3
  [8197267c] IntervalSets v0.7.11
  [3587e190] InverseFunctions v0.1.17
  [92d709cd] IrrationalConstants v0.2.4
  [82899510] IteratorInterfaceExtensions v1.0.0
  [692b3bcd] JLLWrappers v1.7.1
  [ae98c720] Jieko v0.2.1
  [98e50ef6] JuliaFormatter v2.1.6
⌅ [70703baa] JuliaSyntax v0.4.10
  [ccbc3e58] JumpProcesses v9.19.1
  [ba0b0d4f] Krylov v0.10.1
  [b964fa9f] LaTeXStrings v1.4.0
  [23fbe1c1] Latexify v0.16.10
  [10f19ff3] LayoutPointers v0.1.17
  [5078a376] LazyArrays v2.6.2
  [87fe0de2] LineSearch v0.1.4
  [d3d80556] LineSearches v7.4.0
⌃ [7ed4a6bd] LinearSolve v3.28.0
  [2ab3a3ac] LogExpFunctions v0.3.29
  [d8e11817] MLStyle v0.4.17
  [1914dd2f] MacroTools v0.5.16
  [d125e4d3] ManualMemory v0.1.8
  [bb5d69b7] MaybeInplace v0.1.4
  [e1d29d7a] Missings v1.2.0
  [961ee093] ModelingToolkit v10.22.0
  [16a59e39] ModelingToolkitStandardLibrary v2.25.0
  [2e0e35c7] Moshi v0.3.7
  [46d2c3a1] MuladdMacro v0.2.4
⌃ [102ac46a] MultivariatePolynomials v0.5.9
  [d8a4904e] MutableArithmetics v1.6.4
  [d41bc354] NLSolversBase v7.10.0
  [77ba4419] NaNMath v1.1.3
  [8913a72c] NonlinearSolve v4.10.0
  [be0214bd] NonlinearSolveBase v1.14.0
  [5959db7a] NonlinearSolveFirstOrder v1.7.0
  [9a2c21bd] NonlinearSolveQuasiNewton v1.8.0
  [26075421] NonlinearSolveSpectralMethods v1.3.0
  [6fe1bfb0] OffsetArrays v1.17.0
  [429524aa] Optim v1.13.2
  [bac558e1] OrderedCollections v1.8.1
  [bbf590c4] OrdinaryDiffEqCore v1.34.0
  [4302a76b] OrdinaryDiffEqDifferentiation v1.16.0
  [127b3ac7] OrdinaryDiffEqNonlinearSolve v1.14.1
  [43230ef6] OrdinaryDiffEqRosenbrock v1.17.0
  [90014a1f] PDMats v0.11.35
  [d96e819e] Parameters v0.12.3
  [e409e4f3] PoissonRandom v0.4.6
  [f517fe37] Polyester v0.7.18
  [1d0040c9] PolyesterWeave v0.2.2
  [85a6dd25] PositiveFactorizations v0.2.4
  [d236fae5] PreallocationTools v0.4.34
  [aea7be01] PrecompileTools v1.3.3
  [21216c6a] Preferences v1.5.0
  [27ebfcd6] Primes v0.5.7
  [43287f4e] PtrArrays v1.3.0
  [1fd47b50] QuadGK v2.11.2
  [74087812] Random123 v1.7.1
  [e6cf234a] RandomNumbers v1.6.0
  [3cdcf5f2] RecipesBase v1.3.4
  [731186ca] RecursiveArrayTools v3.37.1
  [189a3867] Reexport v1.2.2
  [ae029012] Requires v1.3.1
  [ae5879a3] ResettableStacks v1.1.1
  [79098fc4] Rmath v0.8.0
  [7e49a35a] RuntimeGeneratedFunctions v0.5.15
  [9dfe8606] SCCNonlinearSolve v1.4.0
  [94e857df] SIMDTypes v0.1.0
  [0bca4576] SciMLBase v2.117.1
  [19f34311] SciMLJacobianOperators v0.1.11
  [c0aeaf25] SciMLOperators v1.7.1
  [431bcebd] SciMLPublic v1.0.0
  [53ae85a6] SciMLStructures v1.7.0
  [efcf1570] Setfield v1.1.2
  [727e6d20] SimpleNonlinearSolve v2.7.0
  [699a6c99] SimpleTraits v0.9.5
  [ce78b400] SimpleUnPack v1.1.0
  [a2af1166] SortingAlgorithms v1.2.2
  [0a514795] SparseMatrixColorings v0.4.21
  [276daf66] SpecialFunctions v2.5.1
  [aedffcd0] Static v1.2.0
  [0d7ed370] StaticArrayInterface v1.8.0
  [90137ffa] StaticArrays v1.9.15
  [1e83bf80] StaticArraysCore v1.4.3
  [10745b16] Statistics v1.11.1
  [82ae8749] StatsAPI v1.7.1
  [2913bbd2] StatsBase v0.34.6
  [4c63d2b9] StatsFuns v1.5.0
  [7792a7ef] StrideArraysCore v0.5.8
  [2efcf032] SymbolicIndexingInterface v0.3.43
  [19f23fe9] SymbolicLimits v0.2.3
  [d1185830] SymbolicUtils v3.32.0
  [0c5d862f] Symbolics v6.54.0
  [ed4db957] TaskLocalValues v0.1.3
  [8ea1fca8] TermInterface v2.0.0
  [1c621080] TestItems v1.0.0
  [8290d209] ThreadingUtilities v0.5.5
  [a759f4b9] TimerOutputs v0.5.29
  [410a4b4d] Tricks v0.1.12
  [781d530d] TruncatedStacktraces v1.4.0
  [5c2747f8] URIs v1.6.1
  [3a884ed6] UnPack v1.0.2
  [1986cc42] Unitful v1.24.0
  [a7c27f48] Unityper v0.1.6
  [61579ee1] Ghostscript_jll v9.55.1+0
  [1d5cc7b8] IntelOpenMP_jll v2025.2.0+0
  [aacddb02] JpegTurbo_jll v3.1.3+0
  [856f044c] MKL_jll v2025.2.0+0
  [efe28fd5] OpenSpecFun_jll v0.5.6+0
  [f50d1b31] Rmath_jll v0.5.1+0
  [1317d2d5] oneTBB_jll v2022.0.0+0
  [0dad84c5] ArgTools v1.1.2
  [56f22d72] Artifacts v1.11.0
  [2a0f44e3] Base64 v1.11.0
  [ade2ca70] Dates v1.11.0
  [8ba89e20] Distributed v1.11.0
  [f43a241f] Downloads v1.6.0
  [7b1f6079] FileWatching v1.11.0
  [9fa8497b] Future v1.11.0
  [b77e0a4c] InteractiveUtils v1.11.0
  [ac6e5ff7] JuliaSyntaxHighlighting v1.12.0
  [4af54fe1] LazyArtifacts v1.11.0
  [b27032c2] LibCURL v0.6.4
  [76f85450] LibGit2 v1.11.0
  [8f399da3] Libdl v1.11.0
  [37e2e46d] LinearAlgebra v1.12.0
  [56ddb016] Logging v1.11.0
  [d6f4376e] Markdown v1.11.0
  [a63ad114] Mmap v1.11.0
  [ca575930] NetworkOptions v1.3.0
  [44cfe95a] Pkg v1.12.0
  [de0858da] Printf v1.11.0
  [9a3f8284] Random v1.11.0
  [ea8e919c] SHA v0.7.0
  [9e88b42a] Serialization v1.11.0
  [1a1011a3] SharedArrays v1.11.0
  [6462fe0b] Sockets v1.11.0
  [2f01184e] SparseArrays v1.12.0
  [f489334b] StyledStrings v1.11.0
  [4607b0f0] SuiteSparse
  [fa267f1f] TOML v1.0.3
  [a4e569a6] Tar v1.10.0
  [8dfed614] Test v1.11.0
  [cf7118a7] UUIDs v1.11.0
  [4ec0a83e] Unicode v1.11.0
  [e66e0078] CompilerSupportLibraries_jll v1.3.0+1
  [deac9b47] LibCURL_jll v8.11.1+1
  [e37daf67] LibGit2_jll v1.9.0+0
  [29816b5a] LibSSH2_jll v1.11.3+1
  [14a3606d] MozillaCACerts_jll v2025.5.20
  [4536629a] OpenBLAS_jll v0.3.29+0
  [05823500] OpenLibm_jll v0.8.7+0
  [458c3c95] OpenSSL_jll v3.5.1+0
  [bea87d4a] SuiteSparse_jll v7.8.3+2
  [83775a58] Zlib_jll v1.3.1+2
  [8e850b90] libblastrampoline_jll v5.13.1+1
  [8e850ede] nghttp2_jll v1.64.0+1
  [3f19e933] p7zip_jll v17.5.0+2
Info Packages marked with ⌃ and ⌅ have new versions available. Those with ⌃ may be upgradable, but those with ⌅ are restricted by compatibility constraints from upgrading. To see why use `status --outdated -m`
  • Output of versioninfo()
Julia Version 1.12.0-rc2
Commit 72cbf019d04 (2025-09-06 12:00 UTC)
Build Info:
  Official https://julialang.org release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 32 × Intel(R) Core(TM) i9-14900K
  WORD_SIZE: 64
  LLVM: libLLVM-18.1.7 (ORCJIT, alderlake)
  GC: Built with stock GC
Threads: 32 default, 1 interactive, 32 GC (on 32 virtual cores)
Environment:
  JULIA_EDITOR = code
  JULIA_VSCODE_REPL = 1

Additional context

Adding an infiltration point in function (o::TimeIndependentObservedFunction)(::IsTimeseriesTrait, prob) in SII shows some interesting things.

The RGF that errors is

infil> o.obsfn.f_oop
RuntimeGeneratedFunction(#=in ModelingToolkit=#, #=using ModelingToolkit=#, :((__mtk_arg_1, ___mtkparameters___)->#= /home/sebastian/.julia/packages/Symbolics/FHhXE/src/build_function.jl:366 =# @inbounds(begin
              #= /home/sebastian/.julia/packages/Symbolics/FHhXE/src/build_function.jl:366 =#
              begin
                  #= /home/sebastian/.julia/packages/SymbolicUtils/N76BL/src/code.jl:409 =#
                  #= /home/sebastian/.julia/packages/SymbolicUtils/N76BL/src/code.jl:410 =#
                  #= /home/sebastian/.julia/packages/SymbolicUtils/N76BL/src/code.jl:411 =#
                  begin
                      __mtk_arg_2 = ___mtkparameters___[1]
                      __mtk_arg_3 = ___mtkparameters___[2]
                      begin
                          var"##cse#1" = (<)(__mtk_arg_2[2], __mtk_arg_3[2])
                          var"##cse#2" = (*)(-1, __mtk_arg_3[2])
                          var"##cse#3" = (+)(var"##cse#2", __mtk_arg_2[2])
                          var"##cse#4" = (*)((*)(6.283185307179586, __mtk_arg_3[1]), var"##cse#3")
                          var"##cse#5" = (+)(var"##cse#4", __mtk_arg_3[9])
                          var"##cse#6" = NaNMath.sin(var"##cse#5")
                          var"##cse#7" = (*)(__mtk_arg_3[10], var"##cse#6")
                          var"##cse#8" = if var"##cse#1"
                                  0
                              else
                                  var"##cse#7"
                              end
                          var"##cse#9" = (+)(__mtk_arg_3[4], var"##cse#8")
                          var"input_signal₊output₊u(t)" = var"##cse#9"
                          var"capacitor2₊v(t)" = __mtk_arg_2[53]
                          var"##cse#10" = __mtk_arg_1[1]
                          var"##cse#11" = (*)(var"##cse#10", __mtk_arg_2[1])
                          var"capacitor2₊i(t)" = var"##cse#11"
                          var"##cse#12" = var"input_signal₊output₊u(t)"
                          var"##cse#13" = (*)(-1, var"##cse#12")
                          var"##cse#14" = var"capacitor2₊v(t)"
                          var"##cse#15" = (*)(-1, var"##cse#14")
                          var"##cse#16" = (+)(var"##cse#13", var"##cse#15")
                          var"resistor1₊v(t)" = var"##cse#16"
                          var"##cse#17" = var"resistor1₊v(t)"
                          var"resistor2₊v(t)" = var"##cse#17"
                          var"##cse#18" = var"resistor1₊v(t)"
                          var"##cse#19" = (/)(var"##cse#18", __mtk_arg_3[6])
                          var"resistor1₊i(t)" = var"##cse#19"
                          var"##cse#20" = var"resistor2₊v(t)"
                          var"##cse#21" = (/)(var"##cse#20", __mtk_arg_3[11])
                          var"resistor2₊i(t)" = var"##cse#21"
                          var"##cse#22" = var"capacitor2₊i(t)"
                          var"##cse#23" = (*)(-1, var"##cse#22")
                          var"##cse#24" = var"resistor2₊i(t)"
                          var"##cse#25" = var"resistor1₊i(t)"
                          var"##cse#26" = (+)((+)(var"##cse#23", var"##cse#24"), var"##cse#25")
                          var"capacitor1₊i(t)" = var"##cse#26"
                          var"##cse#27" = var"capacitor1₊i(t)"
                          begin
                              #= /home/sebastian/.julia/packages/SymbolicUtils/N76BL/src/code.jl:510 =#
                              (SymbolicUtils.Code.create_array)(Array, nothing, Val{1}(), Val{(1,)}(), var"##cse#27")
                          end
                      end
                  end
              end
          end)))

and

infil> prob.p[2]
0-element StaticArraysCore.SizedVector{0, ForwardDiff.Dual{...}} with indices SOneTo(0)

If we inspect what does the indexing do,

infil> Main.@code_lowered prob.p[2]
CodeInfo(
1 ─ %1  = ModelingToolkit.:(==)
│   %2  =   dynamic (%1)(idx, 1)
└──       goto #4 if not %2
2 ─ %4  =   dynamic Base.getproperty(ps, :tunable)
└──       return %4
3 ─       goto #9
4 ─ %7  = ModelingToolkit.:(==)
│   %8  =   dynamic (%7)(idx, 2)
└──       goto #7 if not %8
5 ─ %10 =   dynamic Base.getproperty(ps, :initials)
└──       return %10
6 ─       goto #9
7 ─ %13 = ModelingToolkit.:(==)
│   %14 =   dynamic (%13)(idx, 3)
└──       goto #9 if not %14
8 ─ %16 =   dynamic Base.getproperty(ps, :constant)
│   %17 =   dynamic Base.getindex(%16, 1)
└──       return %17
9 ┄ %19 = ModelingToolkit.throw
│   %20 = ModelingToolkit.BoundsError
│   %21 =   dynamic (%20)(ps, idx)
│   %22 =   dynamic (%19)(%21)
└──       return %22
)

we see that the order is tunable, initials, constant.

Now we exit and return to the original problem, and we have

julia> prob.p.constant
([1.0, 0.0, 0.0, 0.0, 300.15, 5.0, 0.0, 300.15, 0.0, 1.0, 2.0, 2.4],)

and

julia> prob.f.initialization_data.initializeprob.p.constant
([1.0, 0.0, 0.0, 0.0, 300.15, 5.0, 0.0, 300.15, 0.0, 1.0, 2.0, 2.4],)

but, the important detail is

julia> prob.f.initialization_data.initializeprob.p[2]
12-element Vector{Float64}:
   1.0
   0.0
   0.0
   0.0
 300.15
   5.0
   0.0
 300.15
   0.0
   1.0
   2.0
   2.4

julia> @code_lowered prob.f.initialization_data.initializeprob.p[2]
CodeInfo(
1 ─ %1  = ModelingToolkit.:(==)
│   %2  =   dynamic (%1)(idx, 1)
└──       goto #4 if not %2
2 ─ %4  =   dynamic Base.getproperty(ps, :tunable)
└──       return %4
3 ─       goto #6
4 ─ %7  = ModelingToolkit.:(==)
│   %8  =   dynamic (%7)(idx, 2)
└──       goto #6 if not %8
5 ─ %10 =   dynamic Base.getproperty(ps, :constant)
│   %11 =   dynamic Base.getindex(%10, 1)
└──       return %11
6 ┄ %13 = ModelingToolkit.throw
│   %14 = ModelingToolkit.BoundsError
│   %15 =   dynamic (%14)(ps, idx)
│   %16 =   dynamic (%13)(%15)
└──       return %16
)

so the codegen here is in the order tunable and then constant.

What ends up happening is that we access the wrong portion in the MTKParameters (the initials instead of the constant)!

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions