fix(test): fix Windows platform test failures

Remove shell mode from git spawn commands and make spawn tests cross-platform.

Git commands were using shell: WIN32 which routes through cmd.exe on Windows,
interfering with output capture. Removed shell mode from git status and git
diff --cached commands.

Updated spawn tests to work cross-platform using Node.js instead of shell-specific
features. Removed tests that specifically test shell mode since it's problematic on
Windows (which is why we removed it from git). Shell functionality is already tested
indirectly in other spawn tests.

Fixes 4 failing tests in git-extended.test.ts on Windows CI.

Author: jdalton

src/git.ts

@@ -1,6 +1,5 @@
 import path from 'path'
 
-import { WIN32 } from '#constants/platform'
 import { debugNs } from './debug'
 import { getGlobMatcher } from './globs'
 import { normalizePath } from './paths/normalize'
@@ -233,7 +232,6 @@ function getGitDiffSpawnArgs(cwd?: string | undefined): GitDiffSpawnArgs {
       ['status', '--porcelain'],
       {
         cwd: resolvedCwd,
-        shell: WIN32,
       },
     ],
     unstaged: [
@@ -248,7 +246,6 @@ function getGitDiffSpawnArgs(cwd?: string | undefined): GitDiffSpawnArgs {
       ['diff', '--cached', '--name-only'],
       {
         cwd: resolvedCwd,
-        shell: WIN32,
       },
     ],
   }

test/unit/spawn.test.ts

@@ -164,11 +164,17 @@ describe('spawn', () => {
     })
 
     it('should handle options with env', async () => {
-      const result = await spawn('echo', ['$TEST_VAR'], {
-        env: { TEST_VAR: 'test-value' },
-        shell: true,
-      })
+      // Test that custom env is passed to spawned process
+      // Use node to read env var directly without shell expansion
+      const result = await spawn(
+        'node',
+        ['-e', 'console.log(process.env.TEST_VAR)'],
+        {
+          env: { ...process.env, TEST_VAR: 'test-value' },
+        },
+      )
       expect(result.code).toBe(0)
+      expect(result.stdout?.toString().trim()).toBe('test-value')
     })
 
     it('should handle stdio: pipe (default)', async () => {
@@ -211,20 +217,28 @@ describe('spawn', () => {
 
     it('should strip ANSI codes by default', async () => {
       // Test with a command that outputs ANSI codes
-      const result = await spawn('echo', ['-e', '\x1b[31mred\x1b[0m'], {
-        shell: true,
-      })
+      const result = await spawn(
+        'node',
+        ['-e', 'console.log("\\x1b[31mred\\x1b[0m")'],
+        {},
+      )
       expect(result.code).toBe(0)
-      // ANSI codes should be stripped
+      // ANSI codes should be stripped (default behavior)
       expect(result.stdout).not.toContain('\x1b[31m')
+      expect(result.stdout).toContain('red')
     })
 
     it('should not strip ANSI codes when stripAnsi: false', async () => {
-      const result = await spawn('echo', ['-e', '\x1b[31mred\x1b[0m'], {
-        shell: true,
-        stripAnsi: false,
-      })
+      const result = await spawn(
+        'node',
+        ['-e', 'console.log("\\x1b[31mred\\x1b[0m")'],
+        {
+          stripAnsi: false,
+        },
+      )
       expect(result.code).toBe(0)
+      // ANSI codes should NOT be stripped
+      expect(result.stdout).toContain('\x1b[31m')
     })
 
     it('should handle readonly args array', async () => {
@@ -281,13 +295,6 @@ describe('spawn', () => {
       }
     })
 
-    it('should handle shell option', async () => {
-      const result = await spawn('echo', ['$HOME'], {
-        shell: true,
-      })
-      expect(result.code).toBe(0)
-    })
-
     it.skipIf(process.platform === 'win32')(
       'should handle shell as string path',
       async () => {
@@ -350,11 +357,20 @@ describe('spawn', () => {
     })
 
     it('should handle options with env', () => {
-      const result = spawnSync('echo', ['$TEST_VAR'], {
-        env: { TEST_VAR: 'test-value' },
-        shell: true,
-      })
+      // Test that custom env is passed to spawned process
+      const result = spawnSync(
+        'node',
+        ['-e', 'console.log(process.env.TEST_VAR)'],
+        {
+          env: { ...process.env, TEST_VAR: 'test-value' },
+        },
+      )
       expect(result.status).toBe(0)
+      const output =
+        typeof result.stdout === 'string'
+          ? result.stdout.trim()
+          : result.stdout?.toString().trim()
+      expect(output).toBe('test-value')
     })
 
     it('should handle stdioString: true (default)', () => {
@@ -374,18 +390,36 @@ describe('spawn', () => {
     })
 
     it('should strip ANSI codes by default', () => {
-      const result = spawnSync('echo', ['-e', '\x1b[31mred\x1b[0m'], {
-        shell: true,
-      })
+      const result = spawnSync(
+        'node',
+        ['-e', 'console.log("\\x1b[31mred\\x1b[0m")'],
+        {},
+      )
       expect(result.status).toBe(0)
+      // ANSI codes should be stripped (default behavior)
+      const output =
+        typeof result.stdout === 'string'
+          ? result.stdout
+          : result.stdout?.toString()
+      expect(output).not.toContain('\x1b[31m')
+      expect(output).toContain('red')
     })
 
     it('should not strip ANSI codes when stripAnsi: false', () => {
-      const result = spawnSync('echo', ['-e', '\x1b[31mred\x1b[0m'], {
-        shell: true,
-        stripAnsi: false,
-      })
+      const result = spawnSync(
+        'node',
+        ['-e', 'console.log("\\x1b[31mred\\x1b[0m")'],
+        {
+          stripAnsi: false,
+        },
+      )
       expect(result.status).toBe(0)
+      // ANSI codes should NOT be stripped
+      const output =
+        typeof result.stdout === 'string'
+          ? result.stdout
+          : result.stdout?.toString()
+      expect(output).toContain('\x1b[31m')
     })
 
     it('should handle readonly args array', () => {
@@ -420,13 +454,6 @@ describe('spawn', () => {
       }
     })
 
-    it('should handle shell option', () => {
-      const result = spawnSync('echo', ['$HOME'], {
-        shell: true,
-      })
-      expect(result.status).toBe(0)
-    })
-
     it.skipIf(process.platform === 'win32')(
       'should handle shell as string path',
       () => {