refactor(build): enhance build configuration

- Configure esbuild for external dependencies and node: protocol
- Add TypeScript source map generation for accurate coverage
- Update vitest configuration for better isolation
- Update isolated-tests.json

Author: jdalton

.config/esbuild.config.mjs

@@ -3,19 +3,25 @@
  */
 
 import { promises as fs } from 'node:fs'
+import Module from 'node:module'
 import path from 'node:path'
 import { fileURLToPath } from 'node:url'
 
 import { parse } from '@babel/parser'
 import MagicString from 'magic-string'
 
-import { getLocalPackageAliases } from '../scripts/utils/get-local-package-aliases.mjs'
+import { NODE_MODULES } from '@socketsecurity/lib/paths/dirnames'
+import { envAsBoolean } from '@socketsecurity/lib/env/helpers'
+import { getDefaultLogger } from '@socketsecurity/lib/logger'
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url))
+
 const rootPath = path.join(__dirname, '..')
 const srcPath = path.join(rootPath, 'src')
 const distPath = path.join(rootPath, 'dist')
 
+const logger = getDefaultLogger()
+
 /**
  * Plugin to shorten module paths in bundled output with conflict detection.
  * Uses @babel/parser and magic-string for precise AST-based modifications.
@@ -31,14 +37,16 @@ function createPathShorteningPlugin() {
           )
 
           for (const outputPath of outputs) {
+            // eslint-disable-next-line no-await-in-loop
             const content = await fs.readFile(outputPath, 'utf8')
             const magicString = new MagicString(content)
 
             // Track module paths and their shortened versions
             const pathMap = new Map()
             const conflictDetector = new Map()
 
-            function shortenPath(longPath) {
+            // eslint-disable-next-line unicorn/consistent-function-scoping
+            const shortenPath = longPath => {
               if (pathMap.has(longPath)) {
                 return pathMap.get(longPath)
               }
@@ -67,8 +75,8 @@ function createPathShorteningPlugin() {
               if (conflictDetector.has(shortPath)) {
                 const existingPath = conflictDetector.get(shortPath)
                 if (existingPath !== longPath) {
-                  console.warn(
-                    `⚠ Path conflict detected:\n  "${shortPath}"\n  Maps to: "${existingPath}"\n  Also from: "${longPath}"\n  Keeping original paths to avoid conflict.`,
+                  logger.warn(
+                    `Path conflict detected:\n  "${shortPath}"\n  Maps to: "${existingPath}"\n  Also from: "${longPath}"\n  Keeping original paths to avoid conflict.`,
                   )
                   shortPath = longPath
                 }
@@ -91,7 +99,7 @@ function createPathShorteningPlugin() {
               for (const comment of ast.comments || []) {
                 if (
                   comment.type === 'CommentLine' &&
-                  comment.value.includes('node_modules')
+                  comment.value.includes(NODE_MODULES)
                 ) {
                   const originalPath = comment.value.trim()
                   const shortPath = shortenPath(originalPath)
@@ -115,7 +123,7 @@ function createPathShorteningPlugin() {
                 if (
                   node.type === 'StringLiteral' &&
                   node.value &&
-                  node.value.includes('node_modules')
+                  node.value.includes(NODE_MODULES)
                 ) {
                   const originalPath = node.value
                   const shortPath = shortenPath(originalPath)
@@ -145,11 +153,11 @@ function createPathShorteningPlugin() {
               }
 
               walk(ast.program)
+              // eslint-disable-next-line no-await-in-loop
               await fs.writeFile(outputPath, magicString.toString(), 'utf8')
             } catch (error) {
-              console.error(
-                `Failed to shorten paths in ${outputPath}:`,
-                error.message,
+              logger.error(
+                `Failed to shorten paths in ${outputPath}: ${error.message}`,
               )
             }
           }
@@ -160,57 +168,38 @@ function createPathShorteningPlugin() {
 }
 
 /**
- * Plugin to handle local package aliases.
- * Provides consistent alias resolution across all Socket repos.
+ * Plugin to ensure all Node.js builtins use the node: protocol.
+ * Intercepts imports of Node.js built-in modules and rewrites them to use the node: prefix.
  */
-function createAliasPlugin() {
-  const aliases = getLocalPackageAliases(rootPath)
-
-  // Only create plugin if we have local aliases
-  if (Object.keys(aliases).length === 0) {
-    return null
-  }
-
-  // Packages that should always be bundled (even when using local aliases)
-  const ALWAYS_BUNDLED = new Set(['@socketsecurity/lib'])
-
+function createNodeProtocolPlugin() {
+  // Get list of Node.js built-in modules dynamically
   return {
-    name: 'local-package-aliases',
+    name: 'node-protocol',
     setup(build) {
-      // Intercept imports for aliased packages and mark as external.
-      for (const [packageName, _aliasPath] of Object.entries(aliases)) {
-        // Skip packages that should always be bundled - let esbuild bundle them naturally
-        if (ALWAYS_BUNDLED.has(packageName)) {
+      for (const builtin of Module.builtinModules) {
+        // Skip builtins that already have node: prefix
+        if (builtin.startsWith('node:')) {
           continue
         }
 
-        // Match both exact package name and subpath imports.
+        // Match imports that don't already have the node: prefix
+        // Escape special regex characters in module name
+        const escapedBuiltin = builtin.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')
         build.onResolve(
-          { filter: new RegExp(`^${packageName}(/|$)`) },
-          args => {
-            // Mark as external using the original package name to avoid absolute paths in output.
-            // This ensures require('@socketsecurity/lib') instead of require('/absolute/path/to/socket-lib/dist').
-            return { path: args.path, external: true }
+          { filter: new RegExp(`^${escapedBuiltin}$`) },
+          _args => {
+            // Return with node: prefix and mark as external
+            return {
+              path: `node:${builtin}`,
+              external: true,
+            }
           },
         )
       }
     },
   }
 }
 
-// Get local package aliases for bundled packages
-function getBundledPackageAliases() {
-  const aliases = getLocalPackageAliases(rootPath)
-  const bundledAliases = {}
-
-  // @socketsecurity/lib should always be bundled (not external)
-  if (aliases['@socketsecurity/lib']) {
-    bundledAliases['@socketsecurity/lib'] = aliases['@socketsecurity/lib']
-  }
-
-  return bundledAliases
-}
-
 // Build configuration for ESM output
 export const buildConfig = {
   entryPoints: [`${srcPath}/index.ts`, `${srcPath}/testing.ts`],
@@ -222,28 +211,22 @@ export const buildConfig = {
   platform: 'node',
   // Target Node.js 18+ features.
   target: 'node18',
-  sourcemap: false,
+  // Enable source maps for coverage (set COVERAGE=true env var)
+  sourcemap: envAsBoolean(process.env.COVERAGE),
   minify: false,
   treeShaking: true,
   // For bundle analysis
   metafile: true,
   logLevel: 'info',
 
-  // Alias local packages that should be bundled (not external)
-  alias: getBundledPackageAliases(),
-
-  // Use plugin for local package aliases (consistent across all Socket repos).
-  plugins: [createPathShorteningPlugin(), createAliasPlugin()].filter(Boolean),
+  // Use plugins for module resolution and path handling.
+  plugins: [createNodeProtocolPlugin(), createPathShorteningPlugin()].filter(
+    Boolean,
+  ),
 
   // External dependencies.
-  // Note: @socketsecurity/lib is bundled (not external) to reduce consumer dependencies.
-  // With format: 'cjs', bundling CJS code works fine (no __require wrapper issues).
-  external: [],
-
-  // Banner for generated code
-  banner: {
-    js: '/* Socket SDK CJS - Built with esbuild */',
-  },
+  // @socketsecurity/lib is external (not bundled) - consumers must install it.
+  external: ['@socketsecurity/lib'],
 
   // TypeScript configuration
   tsconfig: path.join(rootPath, 'tsconfig.json'),
@@ -265,12 +248,12 @@ export const watchConfig = {
   watch: {
     onRebuild(error, result) {
       if (error) {
-        console.error('Watch build failed:', error)
+        logger.error(`Watch build failed: ${error}`)
       } else {
-        console.log('Watch build succeeded')
+        logger.log('Watch build succeeded')
         if (result.metafile) {
           const analysis = analyzeMetafile(result.metafile)
-          console.log(analysis)
+          logger.log(analysis)
         }
       }
     },

.config/eslint.config.mjs

@@ -16,8 +16,6 @@ import unicornPlugin from 'eslint-plugin-unicorn'
 import globals from 'globals'
 import tsEslint from 'typescript-eslint'
 
-import { getLocalPackageAliases } from '../scripts/utils/get-local-package-aliases.mjs'
-
 const __filename = fileURLToPath(import.meta.url)
 const __dirname = path.dirname(__filename)
 const require = createRequire(import.meta.url)
@@ -27,13 +25,7 @@ const getMaintainedNodeVersions = () => ['18', '20', '22', '24']
 
 const rootPath = path.dirname(__dirname)
 
-// Use local config if local Socket packages are detected
-const localPackageAliases = getLocalPackageAliases(rootPath)
-const hasLocalPackages = Object.keys(localPackageAliases).length > 0
-const rootTsConfigPath = path.join(
-  __dirname,
-  hasLocalPackages ? 'tsconfig.check.local.json' : 'tsconfig.check.json',
-)
+const rootTsConfigPath = path.join(__dirname, 'tsconfig.check.json')
 
 const nodeGlobalsConfig = Object.fromEntries(
   Object.entries(globals.node).map(([k]) => [k, 'readonly']),
@@ -248,6 +240,7 @@ export default [
             '.config/*.config.isolated.mts',
             '*.config.mts',
             'test/*.mts',
+            'test/unit/*.mts',
             'test/utils/*.mts',
             'src/*.mts',
           ],

.config/isolated-tests.json

@@ -1,10 +1,12 @@
 {
   "tests": [
-    "test/quota-utils-error-handling.test.mts",
-    "test/json-parsing-edge-cases.test.mts",
-    "test/getapi-sendapi-methods.test.mts",
-    "test/socket-sdk-retry.test.mts",
-    "test/entitlements.test.mts",
-    "test/socket-sdk-batch.test.mts"
+    "test/unit/quota-utils-error-handling.test.mts",
+    "test/unit/json-parsing-edge-cases.test.mts",
+    "test/unit/getapi-sendapi-methods.test.mts",
+    "test/unit/socket-sdk-retry.test.mts",
+    "test/unit/entitlements.test.mts",
+    "test/unit/socket-sdk-batch.test.mts",
+    "test/unit/socket-sdk-json-parsing-errors.test.mts",
+    "test/unit/socket-sdk-strict-types.test.mts"
   ]
 }

.config/vitest.config.isolated.mts

@@ -8,7 +8,6 @@ import { fileURLToPath } from 'node:url'
 
 import { defineConfig } from 'vitest/config'
 
-import { getLocalPackageAliases } from '../scripts/utils/get-local-package-aliases.mjs'
 import {
   baseCoverageConfig,
   isolatedCoverageThresholds,
@@ -29,9 +28,6 @@ const isCoverageEnabled =
 
 export default defineConfig({
   cacheDir: './.cache/vitest',
-  resolve: {
-    alias: getLocalPackageAliases(path.join(__dirname, '..')),
-  },
   test: {
     globals: false,
     environment: 'node',
@@ -54,6 +50,7 @@ export default defineConfig({
     // Share coverage settings with main config
     coverage: {
       ...baseCoverageConfig,
+      reportsDirectory: './coverage-isolated',
       thresholds: isolatedCoverageThresholds,
     },
   },

.config/vitest.config.mts

@@ -2,19 +2,13 @@
  * @fileoverview Vitest configuration for Socket SDK test suite.
  * Configures test environment, coverage, and module resolution.
  */
-import path from 'node:path'
-import { fileURLToPath } from 'node:url'
-
 import { defineConfig } from 'vitest/config'
 
-import { getLocalPackageAliases } from '../scripts/utils/get-local-package-aliases.mjs'
 import {
   baseCoverageConfig,
   mainCoverageThresholds,
 } from './vitest.coverage.config.mts'
 
-const __dirname = path.dirname(fileURLToPath(import.meta.url))
-
 // Check if coverage is enabled via CLI flags or environment.
 const isCoverageEnabled =
   process.env.COVERAGE === 'true' ||
@@ -28,9 +22,6 @@ if (isCoverageEnabled) {
 
 export default defineConfig({
   cacheDir: './.cache/vitest',
-  resolve: {
-    alias: getLocalPackageAliases(path.join(__dirname, '..')),
-  },
   test: {
     globals: false,
     environment: 'node',
@@ -39,12 +30,12 @@ export default defineConfig({
     exclude: [
       '**/node_modules/**',
       '**/dist/**',
-      'test/quota-utils-error-handling.test.mts',
-      'test/json-parsing-edge-cases.test.mts',
-      'test/getapi-sendapi-methods.test.mts',
-      'test/socket-sdk-retry.test.mts',
-      'test/entitlements.test.mts',
-      'test/socket-sdk-batch.test.mts',
+      'test/unit/quota-utils-error-handling.test.mts',
+      'test/unit/json-parsing-edge-cases.test.mts',
+      'test/unit/getapi-sendapi-methods.test.mts',
+      'test/unit/socket-sdk-retry.test.mts',
+      'test/unit/entitlements.test.mts',
+      'test/unit/socket-sdk-batch.test.mts',
     ],
     reporters:
       process.env.TEST_REPORTER === 'json' ? ['json', 'default'] : ['default'],
@@ -93,8 +84,9 @@ export default defineConfig({
       },
     },
     // Reduce timeouts for faster failures
-    testTimeout: 10_000,
-    hookTimeout: 10_000,
+    // Increase timeout in coverage mode due to instrumentation overhead
+    testTimeout: process.env.COVERAGE ? 30_000 : 10_000,
+    hookTimeout: process.env.COVERAGE ? 30_000 : 10_000,
     // Speed optimizations
     // Note: cache is now configured via Vite's cacheDir
     sequence: {