cleanup

Author: 0xRigel-squads

programs/squads_smart_account_program/src/errors.rs

@@ -204,6 +204,10 @@ pub enum SmartAccountError {
     SpendingLimitInvariantCustomPeriodNegative,
     #[msg("Spending limit policy invariant violation: cannot have duplicate destinations for the same mint")]
     SpendingLimitPolicyInvariantDuplicateDestinations,
+    #[msg("Spending limit invariant violation: last reset must be between start and expiration")]
+    SpendingLimitInvariantLastResetOutOfBounds,
+    #[msg("Spending limit invariant violation: last reset must be greater than start")]
+    SpendingLimitInvariantLastResetSmallerThanStart,
 
     // ===============================================
     // Internal Fund Transfer Policy Errors

programs/squads_smart_account_program/src/state/policies/implementations/program_interaction.rs

@@ -641,7 +641,7 @@ impl PolicyTrait for ProgramInteractionPolicy {
     ) -> Result<()> {
         match &payload.transaction_payload {
             ProgramInteractionTransactionPayload::AsyncTransaction(..) => {
-                self.execute_payload(args, payload, accounts)
+                self.execute_payload_async(args, payload, accounts)
             }
             ProgramInteractionTransactionPayload::SyncTransaction(..) => {
                 self.execute_payload_sync(args, payload, accounts)
@@ -656,7 +656,7 @@ impl PolicyTrait for ProgramInteractionPolicy {
 
 impl ProgramInteractionPolicy {
     /// Execute an async transaction through the policy
-    fn execute_payload<'info>(
+    fn execute_payload_async<'info>(
         &mut self,
         args: ProgramInteractionExecutionArgs,
         payload: &ProgramInteractionPayload,

programs/squads_smart_account_program/src/state/policies/implementations/settings_change.rs

@@ -227,7 +227,7 @@ impl PolicyTrait for SettingsChangePolicy {
                             SmartAccountError::SettingsChangeAddSignerViolation
                         );
                     }
-                    // If None, any permissions can used
+                    // If None, any permissions can be used
                     if let Some(allowed_permissions) = allowed_permissions {
                         require!(
                             &new_signer.permissions == allowed_permissions,
@@ -380,7 +380,7 @@ impl SettingsChangePolicy {
             settings,
             rent_payer: Some(rent_payer),
             system_program: Some(system_program),
-            program: program,
+            program,
         })
     }
 }

programs/squads_smart_account_program/src/state/policies/mod.rs

@@ -1,20 +1,7 @@
-//! Policy system for smart accounts
-//!
-//! This module provides a unified policy framework for smart accounts, allowing
-//! different types of policies to be executed through a common consensus mechanism.
-//!
-//! ## Structure
-//!
-//! - `core/`: Core policy framework (Policy struct, traits, payloads)
-//! - `implementations/`: Specific policy implementations
-//! - `tests/`: Test modules for framework and implementations
-
 pub mod implementations;
 pub mod policy_core;
-pub mod tests;
 mod utils;
 
 pub use policy_core::*;
 
-// Re-export implementations for convenience
 pub use implementations::*;

programs/squads_smart_account_program/src/state/policies/tests/execution_pattern.rs

@@ -278,12 +278,12 @@ impl SpendingLimitV2 {
             require!(
                 self.usage.last_reset >= self.time_constraints.start
                     && self.usage.last_reset <= expiration,
-                SmartAccountError::SpendingLimitInvariantRemainingAmountGreaterThanMaxPerPeriod
+                SmartAccountError::SpendingLimitInvariantLastResetOutOfBounds
             );
         } else {
             require!(
                 self.usage.last_reset >= self.time_constraints.start,
-                SmartAccountError::SpendingLimitInvariantRemainingAmountGreaterThanMaxPerPeriod
+                SmartAccountError::SpendingLimitInvariantLastResetSmallerThanStart
             );
         }