EM-344-mcu-can-enter-a-scheduled-infinite-loop-somewhere-causing-high-power-consumption-no-communication-while-not-triggering-a-watchdog-reset

Author: nielsheirman

stack/framework/CMakeLists.txt

@@ -39,6 +39,9 @@ FRAMEWORK_HEADER_DEFINE(NUMBER FRAMEWORK_SCHEDULER_MAX_TASKS)
 SET(FRAMEWORK_SCHEDULER_LP_MODE "0" CACHE STRING "The low power mode to use. Only change this if you know exactly what you are doing")
 FRAMEWORK_HEADER_DEFINE(NUMBER FRAMEWORK_SCHEDULER_LP_MODE)
 
+SET(FRAMEWORK_SCHEDULER_MAX_ACTIVE_TIME "0" CACHE STRING "Defines the maximum time in seconds the scheduler can be active. When this time is exceeded the processor will assert. Set to 0 to disable this feature")
+FRAMEWORK_HEADER_DEFINE(NUMBER FRAMEWORK_SCHEDULER_MAX_ACTIVE_TIME)
+
 # when the current platform is using jlink we enable logging by default
 IF(JLINK_DEVICE)
   SET(FRAMEWORK_LOG_ENABLED "TRUE" CACHE BOOL "Select whether to enable or disable the generation of logs")

stack/framework/components/scheduler/scheduler.c

@@ -528,7 +528,7 @@ __LINK_C void scheduler_run()
 		uint8_t executed_tasks = 0;
 		watchdog_wakeup = false;
 #endif
-#if defined FRAMEWORK_USE_POWER_TRACKING
+#if (defined FRAMEWORK_USE_POWER_TRACKING || FRAMEWORK_SCHEDULER_MAX_ACTIVE_TIME > 0)
 		timer_tick_t wakeup_time = timer_get_counter_value();
 #endif
 		while(NG(current_priority) < NUM_PRIORITIES)
@@ -545,15 +545,18 @@ __LINK_C void scheduler_run()
 #endif
 				check_structs_are_valid();
 #if defined(FRAMEWORK_LOG_ENABLED) && defined(FRAMEWORK_SCHED_LOG_ENABLED)
-        timer_tick_t start = timer_get_counter_value();
-        log_print_string("SCHED start %p at %i", NG(m_info)[id].task, start);
+				timer_tick_t start = timer_get_counter_value();
+				log_print_string("SCHED start %p at %i", NG(m_info)[id].task, start);
 #endif
-		current_task_id = id;
-        NG(m_info)[id].task(NG(m_info)[id].arg);
+				current_task_id = id;
+				NG(m_info)[id].task(NG(m_info)[id].arg);
+		#if FRAMEWORK_SCHEDULER_MAX_ACTIVE_TIME > 0
+				assert(timer_get_current_time_difference(wakeup_time) < FRAMEWORK_SCHEDULER_MAX_ACTIVE_TIME * TIMER_TICKS_PER_SEC);
+		#endif
 #if defined(FRAMEWORK_LOG_ENABLED) && defined(FRAMEWORK_SCHED_LOG_ENABLED)
-        timer_tick_t stop = timer_get_counter_value();
-        timer_tick_t duration = stop - start;
-        log_print_string("SCHED stop %p at %i took %i", NG(m_info)[id].task, stop, duration);
+				timer_tick_t stop = timer_get_counter_value();
+				timer_tick_t duration = stop - start;
+				log_print_string("SCHED stop %p at %i took %i", NG(m_info)[id].task, stop, duration);
 #endif
 			}
 			//this needs to be done atomically since otherwise we risk decrementing the current priority

stack/modules/alp/alp_layer.c

@@ -757,8 +757,8 @@ static void process_async(void* arg)
     alp_interface_config_t forward_interface_config;
     alp_command_t* resp_command = alp_layer_command_alloc(false, false);
     if(resp_command == NULL) {
-        log_print_error_string("process async: alloc command failed for the response command, retrying later");
-        fifo_put(&command_fifo, (uint8_t*)&command, sizeof(alp_command_t*));
+        log_print_error_string("process async: alloc command failed for the response command, dropping command");
+        free_command(command);
         return;
     }
     static alp_action_t action;

stack/modules/alp/serial_interface.c

@@ -67,6 +67,12 @@ static void serial_interface_cmd_handler(fifo_t* cmd_fifo)
     end_atomic();
 
     alp_command_t* command = alp_layer_command_alloc(false, false);
+    if(command == NULL)
+    {
+        log_print_error_string("serial_interface_cmd_handler: unable to allocate alp command");
+        return;
+
+    }
     command->origin_itf_id = ALP_ITF_ID_SERIAL;
     alp_append_interface_status(command, &serial_itf_status);
     fifo_put(&command->alp_command_fifo, alp_command, alp_command_len);