Removed Translation Downloader & Updates

* Removed Translation Downloader
* Updated maven workflow
* Updated dependency reduced

Author: Francisco Solis

.github/workflows/maven.yml

@@ -49,9 +49,8 @@ jobs:
     - name: Build, Test & Deoploy with Maven
       run: mvn -B clean package test deploy --file pom.xml
       # Now we store the artifact in the action
-    - name: Store Artifact
-    - run: mkdir -p ./artifacts
-    - run: cp target/SuperCoreAPI.jar ./artifacts/
+    - name: Create & Copy artifact
+    - run: mkdir -p ./artifacts && cp target/SuperCoreAPI.jar ./artifacts/
     - uses: actions/upload-artifact@v2
       with:
         name: SuperCoreAPI

dependency-reduced-pom.xml

@@ -4,7 +4,7 @@
   <groupId>xyz.theprogramsrc</groupId>
   <artifactId>SuperCoreAPI</artifactId>
   <name>SuperCoreAPI</name>
-  <version>5.2.2-SNAPSHOT</version>
+  <version>5.2.2</version>
   <description>The best way to create a plugin.</description>
   <url>https://github.com/TheProgramSrc/SuperCoreAPI</url>
   <build>

src/main/java/xyz/theprogramsrc/supercoreapi/global/translations/Base.java

@@ -62,9 +62,6 @@ public enum Base implements TranslationPack{
     GENERAL_SET_PREFIX_NAME("GUI.GeneralSettings.Items.Prefix.Name","&aSet Prefix"),
     GENERAL_SET_PREFIX_DESCRIPTION("GUI.GeneralSettings.Items.Prefix.Lore","&7Current Prefix: &r{Prefix}"),
 
-    GENERAL_TOGGLE_TRANSLATION_DOWNLOADER_NAME("GUI.GeneralSettings.Items.TranslationDownloader.Name","&aToggle Translation Downloader"),
-    GENERAL_TOGGLE_TRANSLATION_DOWNLOADER_DESCRIPTION("GUI.GeneralSettings.Items.TranslationDownloader.Lore","&7Current Status: &9{Status}"),
-
     SETTINGS_TOGGLE_UPDATER_NAME("GUI.GeneralSettings.Items.ToggleUpdater.Name","&aToggle Updater"),
     SETTINGS_TOGGLE_UPDATER_DESCRIPTION("GUI.GeneralSettings.Items.ToggleUpdater.Lore","&7Current Status: &9{Status}"),
 

src/main/java/xyz/theprogramsrc/supercoreapi/global/translations/TranslationDownloader.java

@@ -1,15 +1,16 @@
 package xyz.theprogramsrc.supercoreapi.global.translations;
 
+import java.io.File;
+
 import com.google.gson.JsonArray;
 import com.google.gson.JsonElement;
 import com.google.gson.JsonObject;
 import com.google.gson.JsonParser;
+
 import xyz.theprogramsrc.supercoreapi.SuperPlugin;
 import xyz.theprogramsrc.supercoreapi.global.utils.Utils;
 import xyz.theprogramsrc.supercoreapi.global.utils.files.FileUtils;
 
-import java.io.File;
-
 public class TranslationDownloader {
 
     /**
@@ -18,8 +19,9 @@ public class TranslationDownloader {
      * @param username The GitHub Username
      * @param repository The GitHub Repository
      * @param folder The folder of the Translations
+     * @deprecated due to new translation system
      */
-    public static void downloadFromGitHub(final SuperPlugin<?> core, final String username, final String repository, final String folder){
+    @Deprecated public static void downloadFromGitHub(final SuperPlugin<?> core, final String username, final String repository, final String folder){
         JsonParser parser = new JsonParser();
         try{
             String url = "https://api.github.com/repos/{Username}/{Repository}/contents/{Folder}";
@@ -52,8 +54,9 @@ public static void downloadFromGitHub(final SuperPlugin<?> core, final String us
      * @param core The Plugin
      * @param directUrl The DirectURl (This API doesn't support redirection)
      * @param fileName The name of the file to save
+     * @deprecated due to new translation system
      */
-    public static void downloadTranslation(final SuperPlugin<?> core, String directUrl, String fileName){
+    @Deprecated public static void downloadTranslation(final SuperPlugin<?> core, String directUrl, String fileName){
         try{
             File file = new File(core.getTranslationsFolder(), fileName.endsWith(".lang") ? fileName : (fileName+".lang"));
             file.delete();

src/main/java/xyz/theprogramsrc/supercoreapi/spigot/gui/precreated/settings/precreated/GeneralConfigurationSettingPane.java

@@ -3,16 +3,13 @@
 import com.cryptomorin.xseries.XMaterial;
 
 import xyz.theprogramsrc.supercoreapi.global.translations.Base;
-import xyz.theprogramsrc.supercoreapi.global.utils.Utils;
 import xyz.theprogramsrc.supercoreapi.spigot.dialog.Dialog;
 import xyz.theprogramsrc.supercoreapi.spigot.gui.objets.GuiEntry;
 import xyz.theprogramsrc.supercoreapi.spigot.gui.precreated.settings.SettingPane;
 import xyz.theprogramsrc.supercoreapi.spigot.items.SimpleItem;
 
 public class GeneralConfigurationSettingPane extends SettingPane {
 
-    private final boolean hasDownloader = this.getPlugin().getPluginDataStorage().contains("TranslationDownloader");
-
     @Override
     public String getDisplayName() {
         return Base.GENERAL.toString();
@@ -31,27 +28,13 @@ public SimpleItem getDisplayItem() {
     @Override
     public GuiEntry[] getButtons() {
         return new GuiEntry[]{
-            this.getToggleTranslationButton(),
             this.getChangePrefixButton()
         };
     }
 
     @Override
     public int[] getContainerSlots() {
-        return this.hasDownloader ? new int[]{12,14} : new int[]{13};
-    }
-
-    private GuiEntry getToggleTranslationButton(){
-        SimpleItem item = new SimpleItem(XMaterial.ANVIL)
-                .setDisplayName("&a" + Base.GENERAL_TOGGLE_TRANSLATION_DOWNLOADER_NAME)
-                .setLore(
-                        "&7",
-                        "&7" + Base.GENERAL_TOGGLE_TRANSLATION_DOWNLOADER_DESCRIPTION
-                ).addPlaceholder("{Status}", Utils.parseEnabledBoolean(this.getPlugin().getPluginDataStorage().getBoolean("TranslationDownloader")));
-        return new GuiEntry(item, a-> {
-            this.getPlugin().getPluginDataStorage().set("TranslationDownloader", !this.hasDownloader);
-            a.gui.open();
-        });
+        return new int[]{13};
     }
 
     private GuiEntry getChangePrefixButton(){

src/main/java/xyz/theprogramsrc/supercoreapi/spigot/guis/precreated/settings/precreated/GeneralConfigurationSettingPane.java

@@ -5,7 +5,6 @@
 import com.cryptomorin.xseries.XMaterial;
 
 import xyz.theprogramsrc.supercoreapi.global.translations.Base;
-import xyz.theprogramsrc.supercoreapi.global.utils.Utils;
 import xyz.theprogramsrc.supercoreapi.spigot.dialog.Dialog;
 import xyz.theprogramsrc.supercoreapi.spigot.guis.GUIButton;
 import xyz.theprogramsrc.supercoreapi.spigot.guis.objects.GUIRows;
@@ -17,8 +16,6 @@
  */
 @Deprecated public class GeneralConfigurationSettingPane extends SettingPane {
 
-    private final boolean hasDownloader = this.getPlugin().getPluginDataStorage().contains("TranslationDownloader");
-
     @Override
     public String getDisplayName() {
         return Base.GENERAL.toString();
@@ -37,36 +34,20 @@ public SimpleItem getDisplayItem() {
     @Override
     public GUIButton[] getButtons() {
         LinkedList<GUIButton> buttons = new LinkedList<>();
-        if(this.hasDownloader){
-            buttons.add(this.getToggleTranslationDownloaderButton());
-        }
         buttons.add(this.getChangePrefixButton());
         return buttons.toArray(new GUIButton[0]);
     }
 
     @Override
     public int[] getContainerSlots() {
-        return this.hasDownloader ? new int[]{12,14} : new int[]{13};
+        return new int[]{13};
     }
 
     @Override
     public GUIRows getRows() {
         return GUIRows.THREE;
     }
 
-    private GUIButton getToggleTranslationDownloaderButton(){
-        SimpleItem item = new SimpleItem(XMaterial.ANVIL)
-                .setDisplayName("&a" + Base.GENERAL_TOGGLE_TRANSLATION_DOWNLOADER_NAME)
-                .setLore(
-                        "&7",
-                        "&7" + Base.GENERAL_TOGGLE_TRANSLATION_DOWNLOADER_DESCRIPTION
-                ).addPlaceholder("{Status}", Utils.parseEnabledBoolean(this.getPlugin().getPluginDataStorage().getBoolean("TranslationDownloader")));
-        return new GUIButton(item, a->{
-            this.getPlugin().getPluginDataStorage().toggle("TranslationDownloader");
-            a.openGUI();
-        });
-    }
-
     private GUIButton getChangePrefixButton(){
         SimpleItem item = new SimpleItem(XMaterial.NAME_TAG)
                 .setDisplayName("&a" + Base.GENERAL_SET_PREFIX_NAME)