Skip to content

Commit de0e06e

Browse files
authored
Merge pull request #61 from TryShape/accessibility-issues
accessibility issues
2 parents 35cc4a9 + 87f0fdd commit de0e06e

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

components/core/Landing.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@ const Landing = ({ setOpen, user, setUser }) => {
428428
return(
429429
<div>
430430
<BannerHeader fixed="top" expand="md">
431-
<Navbar.Brand><Logo><div className="sr-only">TryShape</div></Logo></Navbar.Brand>
431+
<Navbar.Brand><Logo><span className="sr-only">TryShape</span></Logo></Navbar.Brand>
432432
<Navbar.Toggle>
433433
<FiMenu color="var(--color-neutral-10" size="24px"/>
434434
</Navbar.Toggle>
@@ -523,7 +523,7 @@ const Landing = ({ setOpen, user, setUser }) => {
523523
<FileSupportCards>
524524
<FileSupportCardItem>
525525
<div className="card-icon">
526-
<img src={IconSvg} />
526+
<img src={IconSvg} alt="Icon for SVG File Type" />
527527
</div>
528528
<h3 className="card-title">SVG</h3>
529529
<p className="card-desc">
@@ -533,7 +533,7 @@ const Landing = ({ setOpen, user, setUser }) => {
533533
</FileSupportCardItem>
534534
<FileSupportCardItem>
535535
<div className="card-icon">
536-
<img src={IconPngJpg} />
536+
<img src={IconPngJpg} alt="Icon for PNG and JPG File Types"/>
537537
</div>
538538
<h3 className="card-title">PNG and JPEG</h3>
539539
<p className="card-desc">
@@ -543,7 +543,7 @@ const Landing = ({ setOpen, user, setUser }) => {
543543
</FileSupportCardItem>
544544
<FileSupportCardItem>
545545
<div className="card-icon">
546-
<img src={IconCss} />
546+
<img src={IconCss} alt="Icon for CSS Snippets"/>
547547
</div>
548548
<h3 className="card-title">CSS Snippet</h3>
549549
<p className="card-desc">
@@ -557,11 +557,11 @@ const Landing = ({ setOpen, user, setUser }) => {
557557
<SectionContact id="contact">
558558
<Container>
559559
<SocialLinks>
560-
<a href="https://github.com/TryShape" target="_blank" rel="noopener noreferrer"><FiGithub /></a>
561-
<a href="https://twitter.com/tapasadhikary" target="_blank" rel="noopener noreferrer"><FiTwitter /></a>
562-
<a href="https://www.linkedin.com/in/tapasadhikary/" target="_blank" rel="noopener noreferrer"><FiLinkedin /></a>
563-
<a href="https://www.youtube.com/c/TapasAdhikary/featured" rel="noopener noreferrer"><FiYoutube /></a>
564-
<a href="mailto:[email protected]" rel="noopener noreferrer"><FiMail /></a>
560+
<a href="https://github.com/TryShape" target="_blank" rel="noopener noreferrer"><FiGithub /><span className="sr-only">GitHub</span></a>
561+
<a href="https://twitter.com/tapasadhikary" target="_blank" rel="noopener noreferrer"><FiTwitter /><span className="sr-only">Twitter</span></a>
562+
<a href="https://www.linkedin.com/in/tapasadhikary/" target="_blank" rel="noopener noreferrer"><FiLinkedin /><span className="sr-only">Linkedin</span></a>
563+
<a href="https://www.youtube.com/c/TapasAdhikary/featured" rel="noopener noreferrer"><FiYoutube /><span className="sr-only">Youtube</span></a>
564+
<a href="mailto:[email protected]" rel="noopener noreferrer"><FiMail /><span className="sr-only">Email</span></a>
565565
</SocialLinks>
566566
<SectionContactCredits className="text-center"><small>TryShape is an opensource project developed by <a href="https://tapasadhikary.com/" target="_blank">Tapas Adhikary</a> and friends.</small></SectionContactCredits>
567567
</Container>

components/utils/ShapeList.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ const ShapeActions = styled.div`
116116
justify-content: space-between;
117117
`;
118118

119-
const ShapeName = styled.h4`
119+
const ShapeName = styled.h2`
120120
display: flex;
121121
justify-content: flex-start;
122122
align-items: center;
@@ -163,7 +163,7 @@ const ShapeCreditsOwner = styled.div`
163163
const ShapeCreditsDate = styled.small`
164164
margin-top: 0.3rem;
165165
font-size: var(--fs-sm);
166-
color: var(--color-neutral-50);
166+
color: var(--color-neutral-60);
167167
line-height: 1;
168168
`;
169169

pages/_document.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export default class MyDocument extends Document {
2121

2222
render() {
2323
return (
24-
<Html>
24+
<Html lang="en">
2525
<Head>
2626
{/* Step 5: Output the styles in the head */}
2727
{this.props.styleTags}

0 commit comments

Comments
 (0)