Fix sandbox configuration serialization and add comprehensive logging

Author: Kanishka

src/controllers/configuration.js

@@ -85,7 +85,16 @@ function ConfigurationController(ctx) {
     if (!configuration) {
       return notFound('Configuration not found');
     }
-    return ok(ConfigurationDto.toJSON(configuration));
+    // eslint-disable-next-line no-console
+    console.log('[getLatest] Configuration version:', configuration.getVersion());
+    // eslint-disable-next-line no-console
+    console.log('[getLatest] Configuration state:', configuration.state);
+    // eslint-disable-next-line no-console
+    console.log('[getLatest] Configuration state.sandboxAudits:', configuration.state?.sandboxAudits);
+    const result = ConfigurationDto.toJSON(configuration);
+    // eslint-disable-next-line no-console
+    console.log('[getLatest] DTO result includes sandboxAudits:', !!result.sandboxAudits);
+    return ok(result);
   };
 
   /**
@@ -118,11 +127,17 @@ function ConfigurationController(ctx) {
 
       // Update sandbox configurations for each audit type
       Object.keys(sandboxConfigs).forEach((auditType) => {
+        // eslint-disable-next-line no-console
+        console.log(`Updating sandbox config for audit type: ${auditType}`, sandboxConfigs[auditType]);
         config.updateSandboxAuditConfig(auditType, sandboxConfigs[auditType]);
       });
 
       // Save the updated configuration
+      // eslint-disable-next-line no-console
+      console.log('Saving updated configuration with sandbox audits:', config.state?.sandboxAudits);
       await config.save();
+      // eslint-disable-next-line no-console
+      console.log('[updateSandboxConfig] Configuration saved successfully');
 
       return ok({
         message: 'Sandbox configurations updated successfully',

src/dto/configuration.js

@@ -20,19 +20,20 @@ export const ConfigurationDto = {
    * @returns {{
    * }}
    */
-  toJSON: (configuration) => ({
-    version: configuration.getVersion(),
-    jobs: configuration.getJobs(),
-    ...(configuration.getHandlers() ? { handlers: configuration.getHandlers() } : {}),
-    queues: configuration.getQueues(),
-    ...(configuration.getSlackRoles() ? { slackRoles: configuration.getSlackRoles() } : {}),
-    ...(configuration.getEnabledSandboxAudits && configuration.getEnabledSandboxAudits().length > 0
-      ? {
-        sandboxAudits: configuration.getEnabledSandboxAudits().reduce((acc, auditType) => {
-          acc[auditType] = configuration.getSandboxAuditConfig(auditType);
-          return acc;
-        }, {}),
-      }
-      : {}),
-  }),
+  toJSON: (configuration) => {
+    // eslint-disable-next-line no-console
+    console.log('[ConfigurationDto] Configuration state?.sandboxAudits:', configuration.state?.sandboxAudits);
+
+    const result = {
+      version: configuration.getVersion(),
+      jobs: configuration.getJobs(),
+      ...(configuration.getHandlers() ? { handlers: configuration.getHandlers() } : {}),
+      queues: configuration.getQueues(),
+      ...(configuration.getSlackRoles() ? { slackRoles: configuration.getSlackRoles() } : {}),
+      ...(configuration.state?.sandboxAudits
+        ? { sandboxAudits: configuration.state.sandboxAudits }
+        : {}),
+    };
+    return result;
+  },
 };

test/controllers/configurations.test.js

@@ -89,6 +89,14 @@ describe('Configurations Controller', () => {
         if (auditType === 'meta-tags') return { expire: '15' };
         return null;
       },
+      state: {
+        sandboxAudits: {
+          enabledAudits: {
+            cwv: { expire: '10' },
+            'meta-tags': { expire: '15' },
+          },
+        },
+      },
     },
   ];