tests: add resource reordering test (#872)

Author: algorandskiy

src/main/java/com/algorand/algosdk/builder/transaction/ApplicationBaseTransactionBuilder.java

@@ -4,7 +4,6 @@
 import com.algorand.algosdk.transaction.AccessConverter;
 import com.algorand.algosdk.transaction.AppBoxReference;
 import com.algorand.algosdk.transaction.AppResourceRef;
-import com.algorand.algosdk.transaction.ResourceRef;
 import com.algorand.algosdk.transaction.Transaction;
 import com.algorand.algosdk.util.Encoder;
 
@@ -14,27 +13,27 @@
 
 @SuppressWarnings("unchecked")
 public abstract class ApplicationBaseTransactionBuilder<T extends ApplicationBaseTransactionBuilder<T>> extends TransactionBuilder<T> implements ApplicationCallReferencesSetter<T> {
-    
+
     /**
      * Represents a holding reference for asset holdings of an account.
      */
     public static class HoldingReference {
         public final Address address;
         public final long assetId;
-        
+
         public HoldingReference(Address address, long assetId) {
             this.address = address;
             this.assetId = assetId;
         }
     }
-    
+
     /**
      * Represents a locals reference for local state of an account in an app.
      */
     public static class LocalsReference {
         public final Address address;
         public final long appId;
-        
+
         public LocalsReference(Address address, long appId) {
             this.address = address;
             this.appId = appId;
@@ -68,7 +67,7 @@ protected void applyTo(Transaction txn) {
         // Check if advanced features are being used
         boolean hasAdvancedFeatures = (holdings != null && !holdings.isEmpty()) ||
                                      (locals != null && !locals.isEmpty());
-        
+
         if (useAccess) {
             // Using access field mode - translate all references into access list
             List<AppResourceRef> allRefs = new ArrayList<>();
@@ -78,19 +77,19 @@ protected void applyTo(Transaction txn) {
                     allRefs.add(AppResourceRef.forAddress(account));
                 }
             }
-            
+
             if (foreignApps != null && !foreignApps.isEmpty()) {
                 for (Long appId : foreignApps) {
                     allRefs.add(AppResourceRef.forApp(appId));
                 }
             }
-            
+
             if (foreignAssets != null && !foreignAssets.isEmpty()) {
                 for (Long assetId : foreignAssets) {
                     allRefs.add(AppResourceRef.forAsset(assetId));
                 }
             }
-            
+
             if (appBoxReferences != null && !appBoxReferences.isEmpty()) {
                 for (AppBoxReference boxRef : appBoxReferences) {
                     allRefs.add(AppResourceRef.forBox(boxRef.getAppId(), boxRef.getName()));
@@ -102,23 +101,23 @@ protected void applyTo(Transaction txn) {
                     allRefs.add(AppResourceRef.forHolding(holdingRef.address, holdingRef.assetId));
                 }
             }
-            
+
             if (locals != null && !locals.isEmpty()) {
                 for (LocalsReference localsRef : locals) {
                     allRefs.add(AppResourceRef.forLocals(localsRef.address, localsRef.appId));
                 }
             }
 
             txn.access = AccessConverter.convertToResourceRefs(allRefs, sender, applicationId);
-            
+
         } else {
             // Using legacy fields mode
             if (hasAdvancedFeatures) {
                 throw new IllegalArgumentException(
                     "Holdings and locals references require useAccess=true as they cannot be represented in legacy transaction format"
                 );
             }
-            
+
             // Use legacy fields directly
             if (accounts != null) txn.accounts = accounts;
             if (foreignApps != null) txn.foreignApps = foreignApps;
@@ -203,8 +202,8 @@ public T boxReferences(List<AppBoxReference> boxReferences) {
     /**
      * Set asset holding references that need to be accessible in this transaction.
      * Holdings references allow the transaction to access asset balances of specific accounts.
-     * 
-     * Note: Holdings references are only available when useAccess=true as they cannot be 
+     *
+     * Note: Holdings references are only available when useAccess=true as they cannot be
      * represented in legacy transaction format.
      */
     public T holdings(List<HoldingReference> holdings) {
@@ -215,8 +214,8 @@ public T holdings(List<HoldingReference> holdings) {
     /**
      * Set local state references that need to be accessible in this transaction.
      * Locals references allow the transaction to access local state of specific accounts in specific apps.
-     * 
-     * Note: Locals references are only available when useAccess=true as they cannot be 
+     *
+     * Note: Locals references are only available when useAccess=true as they cannot be
      * represented in legacy transaction format.
      */
     public T locals(List<LocalsReference> locals) {

src/test/java/com/algorand/algosdk/transaction/TestTransaction.java

@@ -1,8 +1,10 @@
 package com.algorand.algosdk.transaction;
 
 import com.algorand.algosdk.account.Account;
+import com.algorand.algosdk.builder.transaction.ApplicationBaseTransactionBuilder.HoldingReference;
 import com.algorand.algosdk.crypto.*;
 import com.algorand.algosdk.mnemonic.Mnemonic;
+import com.algorand.algosdk.unit.utils.TestingUtils;
 import com.algorand.algosdk.util.Encoder;
 import com.algorand.algosdk.util.TestUtil;
 import com.fasterxml.jackson.databind.ObjectMapper;
@@ -14,6 +16,7 @@
 import java.math.BigInteger;
 import java.nio.charset.StandardCharsets;
 import java.security.NoSuchAlgorithmException;
+import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Base64;
 
@@ -1121,4 +1124,44 @@ public void testApplicationCallRejectVersion() throws Exception {
         assertThat(txExplicitZeroJson).doesNotContain("aprv");
     }
 
+    @Test
+    public void testApplicationCallAccessOrdering() throws Exception {
+        Address from = new Address("BH55E5RMBD4GYWXGX5W5PJ5JAHPGM5OXKDQH5DC4O2MGI7NW4H6VOE4CP4");
+        byte[] gh = Encoder.decodeFromBase64("SGO1GKSzyE7IEPItTxCByw9x8FmnrCDexi9/cOUJOiI=");
+
+        Address addr1 = new Address("FDMKB5D72THLYSJEBHBDHUE7XFRDOM5IHO44SOJ7AWPD6EZMWOQ2WKN7HQ");
+        HoldingReference holding = new HoldingReference(addr1, 123L);
+
+        Transaction tx = Transaction.ApplicationCallTransactionBuilder()
+                .sender(from)
+                .applicationId(111L)
+                .firstValid(322575)
+                .lastValid(322575)
+                .genesisHash(gh)
+                .holdings(Arrays.asList(holding))
+                .useAccess(true)
+                .build();
+
+        // Verify access field ordering
+        assertThat(tx.access.size()).isEqualTo(3);
+        assertThat(tx.access.get(2).holding.addressIndex).isEqualTo(1);  // index=1
+
+        // Make a deep copy
+        String encoded = Encoder.encodeToBase64(Encoder.encodeToMsgPack(tx));
+        Transaction tx2 = Encoder.decodeFromMsgPack(encoded, tx.getClass());
+        assertEqual(tx, tx2);
+
+        // Reorder holdings
+        ArrayList<ResourceRef> reorderedAccess = new ArrayList<>();
+        reorderedAccess.add(tx.access.get(2)); // index=1
+        reorderedAccess.add(tx.access.get(0)); // index=0
+        reorderedAccess.add(tx.access.get(1)); // index=2
+        tx.access = reorderedAccess;
+
+        TestUtil.serializeDeserializeCheck(tx);
+
+        encoded = Encoder.encodeToBase64(Encoder.encodeToMsgPack(tx));
+        Transaction decoded = Encoder.decodeFromMsgPack(encoded, tx.getClass());
+        assertEqual(tx2, decoded);
+    }
 }