From ec8b8e9b410f42d91a58f9fcbdcd218c730f764a Mon Sep 17 00:00:00 2001 From: EC2 Default User Date: Tue, 16 Aug 2022 07:52:36 +0000 Subject: [PATCH 1/5] fix advanced_functionality/causal-inference/causal-inference-container.ipynb --- .../causal-inference/causal-inference-container.ipynb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/advanced_functionality/causal-inference/causal-inference-container.ipynb b/advanced_functionality/causal-inference/causal-inference-container.ipynb index 7dbd3a41fe..bf6d9efbab 100644 --- a/advanced_functionality/causal-inference/causal-inference-container.ipynb +++ b/advanced_functionality/causal-inference/causal-inference-container.ipynb @@ -176,6 +176,8 @@ "metadata": {}, "outputs": [], "source": [ + "! mkdir data\n", + "\n", "# S3 bucket where the training data is located.\n", "data_bucket = f\"sagemaker-sample-files\"\n", "data_prefix = \"datasets/tabular/uci_heart_failure/\"\n", From ba8d5ce83194b16233a2cca4ed7970b7e63bf705 Mon Sep 17 00:00:00 2001 From: atqy Date: Tue, 16 Aug 2022 10:48:55 +0000 Subject: [PATCH 2/5] fix login command --- .../causal-inference/causal-inference-container.ipynb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/advanced_functionality/causal-inference/causal-inference-container.ipynb b/advanced_functionality/causal-inference/causal-inference-container.ipynb index bf6d9efbab..4d20017487 100644 --- a/advanced_functionality/causal-inference/causal-inference-container.ipynb +++ b/advanced_functionality/causal-inference/causal-inference-container.ipynb @@ -108,7 +108,7 @@ "fi\n", "\n", "# Get the login command from ECR and execute it directly\n", - "aws ecr get-login-password --region ${region}|docker login --username AWS --password-stdin ${fullname}\n", + "!$(aws ecr get-login --region $region --registry-ids $account --no-include-email)\n", "\n", "# Build the docker image locally with the image name and then push it to ECR\n", "# with the full name.\n", From 6fbd27dfddc2a21da524c51b09cb88e7dd4ba008 Mon Sep 17 00:00:00 2001 From: atqy Date: Tue, 16 Aug 2022 11:09:38 +0000 Subject: [PATCH 3/5] fix login --- .../causal-inference/causal-inference-container.ipynb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/advanced_functionality/causal-inference/causal-inference-container.ipynb b/advanced_functionality/causal-inference/causal-inference-container.ipynb index 4d20017487..208549e10a 100644 --- a/advanced_functionality/causal-inference/causal-inference-container.ipynb +++ b/advanced_functionality/causal-inference/causal-inference-container.ipynb @@ -108,7 +108,7 @@ "fi\n", "\n", "# Get the login command from ECR and execute it directly\n", - "!$(aws ecr get-login --region $region --registry-ids $account --no-include-email)\n", + "$(aws ecr get-login --region $region --registry-ids $account --no-include-email)\n", "\n", "# Build the docker image locally with the image name and then push it to ECR\n", "# with the full name.\n", From 90e4d2f0603feed27604189fea90a7805100fc7b Mon Sep 17 00:00:00 2001 From: atqy Date: Tue, 16 Aug 2022 11:45:47 +0000 Subject: [PATCH 4/5] fix login --- .../causal-inference-container.ipynb | 3 +++ .../causal-inference/container/ecr_policy.json | 15 +++++++++++++++ 2 files changed, 18 insertions(+) create mode 100644 advanced_functionality/causal-inference/container/ecr_policy.json diff --git a/advanced_functionality/causal-inference/causal-inference-container.ipynb b/advanced_functionality/causal-inference/causal-inference-container.ipynb index 208549e10a..c3057e629c 100644 --- a/advanced_functionality/causal-inference/causal-inference-container.ipynb +++ b/advanced_functionality/causal-inference/causal-inference-container.ipynb @@ -107,6 +107,9 @@ " aws ecr create-repository --repository-name \"${algorithm_name}\" > /dev/null\n", "fi\n", "\n", + "# attach policy allowing sagemaker to pull and push this image\n", + "aws ecr set-repository-policy --repository-name $algorithm_name --policy-text \"$( cat ./ecr_policy.json )\"\n", + "\n", "# Get the login command from ECR and execute it directly\n", "$(aws ecr get-login --region $region --registry-ids $account --no-include-email)\n", "\n", diff --git a/advanced_functionality/causal-inference/container/ecr_policy.json b/advanced_functionality/causal-inference/container/ecr_policy.json new file mode 100644 index 0000000000..edf4643909 --- /dev/null +++ b/advanced_functionality/causal-inference/container/ecr_policy.json @@ -0,0 +1,15 @@ +{ + "Version": "2008-10-17", + "Statement": [ + { + "Sid": "allowSageMakerToPullAndPush", + "Effect": "Allow", + "Principal": { + "Service": "sagemaker.amazonaws.com" + }, + "Action": [ + "ecr:*", + ] + } + ] +} \ No newline at end of file From 8dcf7dc6ff9caec0f2faf440c233048a594c0484 Mon Sep 17 00:00:00 2001 From: atqy Date: Tue, 16 Aug 2022 11:53:23 +0000 Subject: [PATCH 5/5] fix login --- .../causal-inference-container.ipynb | 3 --- .../causal-inference/container/ecr_policy.json | 15 --------------- 2 files changed, 18 deletions(-) delete mode 100644 advanced_functionality/causal-inference/container/ecr_policy.json diff --git a/advanced_functionality/causal-inference/causal-inference-container.ipynb b/advanced_functionality/causal-inference/causal-inference-container.ipynb index c3057e629c..208549e10a 100644 --- a/advanced_functionality/causal-inference/causal-inference-container.ipynb +++ b/advanced_functionality/causal-inference/causal-inference-container.ipynb @@ -107,9 +107,6 @@ " aws ecr create-repository --repository-name \"${algorithm_name}\" > /dev/null\n", "fi\n", "\n", - "# attach policy allowing sagemaker to pull and push this image\n", - "aws ecr set-repository-policy --repository-name $algorithm_name --policy-text \"$( cat ./ecr_policy.json )\"\n", - "\n", "# Get the login command from ECR and execute it directly\n", "$(aws ecr get-login --region $region --registry-ids $account --no-include-email)\n", "\n", diff --git a/advanced_functionality/causal-inference/container/ecr_policy.json b/advanced_functionality/causal-inference/container/ecr_policy.json deleted file mode 100644 index edf4643909..0000000000 --- a/advanced_functionality/causal-inference/container/ecr_policy.json +++ /dev/null @@ -1,15 +0,0 @@ -{ - "Version": "2008-10-17", - "Statement": [ - { - "Sid": "allowSageMakerToPullAndPush", - "Effect": "Allow", - "Principal": { - "Service": "sagemaker.amazonaws.com" - }, - "Action": [ - "ecr:*", - ] - } - ] -} \ No newline at end of file