Fix CreateFleet output parsing

Fix CreateFleet output parsing because ResponseMetadata is at root level of the CreateFleet output and not inside the Errors list

Signed-off-by: Luca Carrogu <[email protected]>

Author: lukeseawalker

src/slurm_plugin/fleet_manager.py

@@ -319,7 +319,7 @@ def _launch_instances(self, launch_params):
                 logger.log(
                     log_level,
                     "Error in CreateFleet request (%s): %s - %s",
-                    err.get("ResponseMetadata").get("RequestId"),
+                    response.get("ResponseMetadata", {}).get("RequestId"),
                     err.get("ErrorCode"),
                     err.get("ErrorMessage"),
                 )
@@ -331,7 +331,7 @@ def _launch_instances(self, launch_params):
 
             return {"Instances": instances}
         except ClientError as e:
-            logger.error("Failed CreateFleet request: %s", e.response.get("ResponseMetadata").get("RequestId"))
+            logger.error("Failed CreateFleet request: %s", e.response.get("ResponseMetadata", {}).get("RequestId"))
             raise e
 
     def _get_instances_info(self, instance_ids: list):

tests/slurm_plugin/test_fleet_manager.py

@@ -368,7 +368,13 @@ def test_evaluate_launch_params(
                 [
                     MockedBoto3Request(
                         method="create_fleet",
-                        response={"Instances": [{"InstanceIds": ["i-12345", "i-23456"]}]},
+                        response={
+                            "Instances": [{"InstanceIds": ["i-12345", "i-23456"]}],
+                            "Errors": [
+                                {"ErrorCode": "InsufficientInstanceCapacity", "ErrorMessage": "Insufficient capacity."}
+                            ],
+                            "ResponseMetadata": {"RequestId": "1234-abcde"},
+                        },
                         expected_params=_mocked_create_fleet_params(
                             "queue1", "fleet-spot", 1, "capacity-optimized", "spot"
                         ),
@@ -420,7 +426,13 @@ def test_evaluate_launch_params(
                 [
                     MockedBoto3Request(
                         method="create_fleet",
-                        response={"Instances": [{"InstanceIds": ["i-12345"]}]},
+                        response={
+                            "Instances": [{"InstanceIds": ["i-12345"]}],
+                            "Errors": [
+                                {"ErrorCode": "InsufficientInstanceCapacity", "ErrorMessage": "Insufficient capacity."}
+                            ],
+                            "ResponseMetadata": {"RequestId": "1234-abcde"},
+                        },
                         expected_params=_mocked_create_fleet_params(
                             "queue2", "fleet-ondemand", 1, "lowest-price", "on-demand"
                         ),