Skip to content

Commit b690c43

Browse files
metrizableChoiByungWook
authored andcommitted
fix: patch socket call and update flake8 violations (#15)
1 parent c4c2a8a commit b690c43

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

test/integration/local/test_smdataparallel.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,15 @@
1212
# language governing permissions and limitations under the License.
1313
from __future__ import absolute_import
1414

15-
import json
1615
import os
17-
import tarfile
1816

1917
import pytest
2018
from sagemaker.pytorch import PyTorch
2119

2220
from integration import resources_path
2321
from utils.local_mode_utils import assert_files_exist
2422

23+
2524
# TODO: Enable the test once SMDataParallel DLC is publicly accessibly
2625
@pytest.mark.skip(reason="SMDataParallel DLC is not publicly accessible")
2726
@pytest.mark.skip_cpu

test/integration/sagemaker/test_smdataparallel.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@
1212
# language governing permissions and limitations under the License.
1313
from __future__ import absolute_import
1414

15-
import json
1615
import os
17-
import tarfile
1816

1917
import pytest
2018
from sagemaker.pytorch import PyTorch
@@ -30,7 +28,9 @@
3028
"instances, train_instance_type",
3129
[(1, "ml.p3.16xlarge"), (2, "ml.p3.16xlarge"), (1, "ml.p3dn.24xlarge"), (2, "ml.p3dn.24xlarge")],
3230
)
33-
def test_smdataparallel_training(instances, train_instance_type, sagemaker_session, image_uri, framework_version, tmpdir):
31+
def test_smdataparallel_training(
32+
instances, train_instance_type, sagemaker_session, image_uri, framework_version, tmpdir
33+
):
3434
default_bucket = sagemaker_session.default_bucket()
3535
output_path = "s3://" + os.path.join(default_bucket, "pytorch/smdataparallel")
3636

test/unit/test_train.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ def test_train(run_entry_point, training_env):
7272

7373

7474
@patch("sagemaker_training.entry_point.run")
75+
@patch('socket.gethostbyname', MagicMock())
7576
def test_train_smdataparallel(run_module, training_env):
7677
training_env.additional_framework_parameters["sagemaker_distributed_dataparallel_enabled"] = True
7778

0 commit comments

Comments
 (0)