Skip to content

Commit 1e6c084

Browse files
committed
update command buffer emulation layer to latest spec version
The command buffer emulation layer will support setting deferred kernel arguments, but will not properly handle the new FINALIZED state.
1 parent d79c921 commit 1e6c084

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

layers/10_cmdbufemu/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ It works by intercepting calls to `clGetExtensionFunctionAddressForPlatform` to
77
If a query succeeds by default then the layer does nothing and simply returns the queried function pointer as-is.
88
If the query is unsuccessful however, then the layer returns its own function pointer, which will record the contents of the command buffer for later playback.
99

10-
This command buffer emulation layer currently implements v0.9.4 of the `cl_khr_command_buffer` extension and v0.9.0 of the `cl_khr_command_buffer_mutable_dispatch` extension.
10+
This command buffer emulation layer currently implements v0.9.7 of the `cl_khr_command_buffer` extension and v0.9.5 of the `cl_khr_command_buffer_mutable_dispatch` extension.
1111
The functionality in this emulation layer is sufficient to run the command buffer samples in this repository.
1212

1313
Please note that the emulated command buffers are intended to be functional, but unlike a native implementation, they may not provide any performance benefit over similar code without using command buffers.
@@ -40,4 +40,5 @@ The following environment variables can modify the behavior of the command buffe
4040
This section describes some of the limitations of the emulated `cl_khr_command_buffer` functionality:
4141

4242
* Some error conditions are not properly checked for and returned.
43+
* Deferred kernel arguments are supported, but the `CL_COMMAND_BUFFER_STATE_FINALIZED` is not properly handled.
4344
* Many functions are not thread safe.

layers/10_cmdbufemu/emulate.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
static constexpr cl_version version_cl_khr_command_buffer =
2323
CL_MAKE_VERSION(0, 9, 7);
2424
static constexpr cl_version version_cl_khr_command_buffer_mutable_dispatch =
25-
CL_MAKE_VERSION(0, 9, 3);
25+
CL_MAKE_VERSION(0, 9, 5);
2626

2727
SLayerContext& getLayerContext(void)
2828
{

0 commit comments

Comments
 (0)