add ValueError to the list of accepable intercepted exceptions for placeholder testing #141

bckohan · bckohan · commit e4fb60ee8da7 · 2024-04-11T15:57:36.000-07:00
diff --git a/render_static/transpilers/urls_to_js.py b/render_static/transpilers/urls_to_js.py
@@ -490,7 +490,7 @@ def get_params(pattern: Union[RoutePattern, RegexPattern]) -> Dict[str, Any]:
                         placeholder_url = reverse(
                             qname, kwargs={**kwargs, **(endpoint.default_args or {})}
                         )
-                except (NoReverseMatch, TypeError, AttributeError):
+                except (NoReverseMatch, TypeError, AttributeError, ValueError):
                     continue
 
                 replacements = []

Original file line number	Diff line number	Diff line change
`@@ -490,7 +490,7 @@ def get_params(pattern: Union[RoutePattern, RegexPattern]) -> Dict[str, Any]:`
`490`	`490`	`placeholder_url = reverse(`
`491`	`491`	`qname, kwargs={kwargs, (endpoint.default_args or {})}`
`492`	`492`	`)`
`493`		`- except (NoReverseMatch, TypeError, AttributeError):`
	`493`	`+ except (NoReverseMatch, TypeError, AttributeError, ValueError):`
`494`	`494`	`continue`
`495`	`495`
`496`	`496`	`replacements = []`