Fix compile warning (incompatible pointer type) #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mod_cloudflare.c: In function 'set_cf_default_proxies':
mod_cloudflare.c:187:23: warning: initialization from incompatible
pointer type [enabled by default]
char **proxies = CF_DEFAULT_TRUSTED_PROXY;
^
|
Or just change |
Raptor007
approved these changes
Nov 2, 2017
Raptor007
left a comment
Raptor007
left a comment
There was a problem hiding this comment.
Yes, this solves the compiler warning without changing functionality.
B10nOnGit
reviewed
Dec 19, 2018
|
I don't understand why this hasn't been merged in yet. |
|
Well, probably won't be merged anymore since the module is abandoned by Cloudflare |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mod_cloudflare.c: In function 'set_cf_default_proxies':
mod_cloudflare.c:187:23: warning: initialization from incompatible
pointer type [enabled by default]
char **proxies = CF_DEFAULT_TRUSTED_PROXY;
^
The above error was being emitted on gcc 4.8.5 (apache 2.4.6) before applying this change. Verified things still seem to function as far as access_logs go.