Skip to content

Commit 4954c8e

Browse files
committed
Update emsdk to 4.0.18
1 parent 2df83a9 commit 4954c8e

File tree

7 files changed

+25
-23
lines changed

7 files changed

+25
-23
lines changed

.github/workflows/deploy-pages.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
clang-runtime: '20'
2727
cling: Off
2828
micromamba_shell_init: bash
29-
emsdk_ver: "3.1.73"
29+
emsdk_ver: "4.0.18"
3030

3131
steps:
3232
- uses: actions/checkout@v5

.github/workflows/emscripten.yml

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,28 +27,28 @@ jobs:
2727
cling: Off
2828
llvm_enable_projects: "clang;lld"
2929
llvm_targets_to_build: "WebAssembly"
30-
emsdk_ver: "3.1.73"
30+
emsdk_ver: "4.0.18"
3131
- name: osx15-arm-clang-repl-20-emscripten
3232
os: macos-15
3333
clang-runtime: '20'
3434
cling: Off
3535
llvm_enable_projects: "clang;lld"
3636
llvm_targets_to_build: "WebAssembly"
37-
emsdk_ver: "3.1.73"
37+
emsdk_ver: "4.0.18"
3838
- name: ubu24-x86-clang-repl-20-emscripten
3939
os: ubuntu-24.04
4040
clang-runtime: '20'
4141
cling: Off
4242
llvm_enable_projects: "clang;lld"
4343
llvm_targets_to_build: "WebAssembly"
44-
emsdk_ver: "3.1.73"
44+
emsdk_ver: "4.0.18"
4545
- name: win2025-x86-clang-repl-20-emscripten
4646
os: windows-2025
4747
clang-runtime: '20'
4848
cling: Off
4949
llvm_enable_projects: "clang;lld"
5050
llvm_targets_to_build: "WebAssembly"
51-
emsdk_ver: "3.1.73"
51+
emsdk_ver: "4.0.18"
5252

5353
steps:
5454
- uses: actions/checkout@v5
@@ -366,25 +366,25 @@ jobs:
366366
clang-runtime: '20'
367367
cling: Off
368368
micromamba_shell_init: bash
369-
emsdk_ver: "3.1.73"
369+
emsdk_ver: "4.0.18"
370370
- name: osx15-arm-clang-repl-20-emscripten_wasm
371371
os: macos-15
372372
clang-runtime: '20'
373373
cling: Off
374374
micromamba_shell_init: bash
375-
emsdk_ver: "3.1.73"
375+
emsdk_ver: "4.0.18"
376376
- name: ubu24-arm-clang-repl-20-emscripten_wasm
377377
os: ubuntu-24.04-arm
378378
clang-runtime: '20'
379379
cling: Off
380380
micromamba_shell_init: bash
381-
emsdk_ver: "3.1.73"
381+
emsdk_ver: "4.0.18"
382382
- name: win2025-x86-clang-repl-20-emscripten
383383
os: windows-2025
384384
clang-runtime: '20'
385385
cling: Off
386386
micromamba_shell_init: powershell
387-
emsdk_ver: "3.1.73"
387+
emsdk_ver: "4.0.18"
388388

389389
steps:
390390
- uses: actions/checkout@v5
@@ -479,8 +479,10 @@ jobs:
479479
-DSYSROOT_PATH=$SYSROOT_PATH \
480480
../
481481
fi
482-
482+
set +e
483483
emmake make -j ${{ env.ncpus }} check-cppinterop
484+
cat /home/runner/work/CppInterOp/CppInterOp/build/unittests/googletest-prefix/src/googletest-stamp/googletest-build-*.log
485+
set -e
484486
os="${{ matrix.os }}"
485487
if [[ "${os}" != macos* ]] ; then
486488
actual_size=$(stat -c%s "./lib/libclangCppInterOp.so")

Emscripten-build-instructions.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,24 +19,24 @@ cd ./CppInterOp-wasm
1919
```
2020

2121
To create a wasm build of CppInterOp we make use of the emsdk toolchain. This can be installed by executing (we only currently
22-
support version 3.1.73)
22+
support version 4.0.18)
2323
```bash
2424
git clone https://github.com/emscripten-core/emsdk.git
25-
./emsdk/emsdk install 3.1.73
25+
./emsdk/emsdk install 4.0.18
2626
```
2727

2828
and to activate the emsdk environment on Linux and osx execute (we are defining SYSROOT_PATH for use later)
2929

3030
```bash
31-
./emsdk/emsdk activate 3.1.73
31+
./emsdk/emsdk activate 4.0.18
3232
source ./emsdk/emsdk_env.sh
3333
export SYSROOT_PATH=$PWD/emsdk/upstream/emscripten/cache/sysroot
3434
```
3535

3636
and on Windows execute in Powershell
3737

3838
```powershell
39-
.\emsdk\emsdk activate 3.1.73
39+
.\emsdk\emsdk activate 4.0.18
4040
.\emsdk\emsdk_env.ps1
4141
$env:PWD_DIR= $PWD.Path
4242
$env:SYSROOT_PATH="$env:EMSDK/upstream/emscripten/cache/sysroot"

docs/Emscripten-build-instructions.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,27 +32,27 @@ Now move into this directory using the following command
3232
3333
To create a wasm build of CppInterOp we make use of the emsdk toolchain.
3434
This can be installed by executing (we only currently support version
35-
3.1.73)
35+
4.0.18)
3636

3737
.. code:: bash
3838
3939
git clone https://github.com/emscripten-core/emsdk.git
40-
./emsdk/emsdk install 3.1.73
40+
./emsdk/emsdk install 4.0.18
4141
4242
and to activate the emsdk environment on Linux and osx execute
4343
(we are defining SYSROOT_PATH for use later)
4444

4545
.. code:: bash
4646
47-
./emsdk/emsdk activate 3.1.73
47+
./emsdk/emsdk activate 4.0.18
4848
source ./emsdk/emsdk_env.sh
4949
export SYSROOT_PATH=$PWD/emsdk/upstream/emscripten/cache/sysroot
5050
5151
and on Windows execute in Powershell
5252

5353
.. code:: powershell
5454
55-
.\emsdk\emsdk activate 3.1.73
55+
.\emsdk\emsdk activate 4.0.18
5656
.\emsdk\emsdk_env.ps1
5757
$env:PWD_DIR= $PWD.Path
5858
$env:SYSROOT_PATH="$env:EMSDK/upstream/emscripten/cache/sysroot"
@@ -429,4 +429,4 @@ and on Windows execute
429429
--contents xeus-cpp/notebooks/images/marie.png `
430430
--contents xeus-cpp/notebooks/audio/audio.wav `
431431
--XeusAddon.mounts="$env:PREFIX/share/xeus-cpp/tagfiles:/share/xeus-cpp/tagfiles" `
432-
--XeusAddon.mounts="$env:PREFIX/etc/xeus-cpp/tags.d:/etc/xeus-cpp/tags.d"
432+
--XeusAddon.mounts="$env:PREFIX/etc/xeus-cpp/tags.d:/etc/xeus-cpp/tags.d"

environment-wasm.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
name: CppInterOp-wasm
22
channels:
3-
- https://prefix.dev/emscripten-forge-dev
3+
- https://prefix.dev/emscripten-forge-4x
44
- https://prefix.dev/conda-forge
55
dependencies:
6-
- emscripten-abi==3.1.73
6+
- emscripten-abi==4.0.18
77
- nlohmann_json
88
- nlohmann_json-abi
99
- xeus-lite

unittests/CppInterOp/FunctionReflectionTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1455,7 +1455,7 @@ TYPED_TEST(CppInterOpTest, FunctionReflectionTestGetFunctionAddress) {
14551455

14561456
std::vector<Decl*> Decls;
14571457
std::string code = "int f1(int i) { return i * i; }";
1458-
std::vector<const char*> interpreter_args = {"-include", "new"};
1458+
std::vector<const char*> interpreter_args = {"-include", "new", "-Xclang", "-iwithsysroot/include/compat"};
14591459

14601460
GetAllTopLevelDecls(code, Decls, /*filter_implicitGenerated=*/false,
14611461
interpreter_args);

unittests/CppInterOp/InterpreterTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ TYPED_TEST(CppInterOpTest, InterpreterTestProcess) {
142142
GTEST_SKIP() << "Test fails for OOP JIT builds";
143143
if (llvm::sys::RunningOnValgrind())
144144
GTEST_SKIP() << "XFAIL due to Valgrind report";
145-
std::vector<const char*> interpreter_args = { "-include", "new" };
145+
std::vector<const char*> interpreter_args = { "-include", "new", "-Xclang", "-iwithsysroot/include/compat" };
146146
auto* I = TestFixture::CreateInterpreter(interpreter_args);
147147
EXPECT_TRUE(Cpp::Process("") == 0);
148148
EXPECT_TRUE(Cpp::Process("int a = 12;") == 0);

0 commit comments

Comments
 (0)