determine log file location (#3)

Author: ludviggunne

Makefile

@@ -1,4 +1,4 @@
-CXXFLAGS=-Wall -Wextra -Wpedantic
+CXXFLAGS=-Wall -Wextra -Wpedantic -std=c++17
 SRC=main.cpp\
     config.cpp
 OBJ=$(SRC:%.cpp=%.o)

config.cpp

@@ -6,6 +6,15 @@
 #include <cstring>
 #include <cerrno>
 
+// mkdir and access
+#ifdef _WIN32
+#include <direct.h>
+#include <io.h>
+#else
+#include <sys/stat.h>
+#include <unistd.h>
+#endif
+
 std::string Config::load(const std::filesystem::path &path)
 {
     // Read config file
@@ -57,6 +66,22 @@ std::string Config::load(const std::filesystem::path &path)
             continue;
         }
 
+        if (key == "log_file") {
+            if (!value.is<std::string>()) {
+                return "Invalid value type for '" + key + "'";
+            }
+            m_logFilePath = value.get<std::string>();
+            continue;
+        }
+
+        if (key == "enable_logging") {
+            if (!value.is<bool>()) {
+                return "Invalid value type for '" + key + "'";
+            }
+            m_loggingEnabled = value.get<bool>();
+            continue;
+        }
+
         if (key == "args") {
             if (!value.is<picojson::array>())
                 return "Invalid value type for '" + key + "'";
@@ -136,6 +161,11 @@ std::string Config::parseArgs(int argc, char **argv)
     if (m_filename.empty())
         return "Missing filename";
 
+    if (m_logFilePath.empty()) {
+        const std::string error = getDefaultLogFilePath(m_logFilePath);
+        if (!error.empty())
+            return error;
+    }
     if (configPath.empty())
         configPath = findConfig(m_filename);
 
@@ -167,3 +197,53 @@ std::filesystem::path Config::findConfig(const std::filesystem::path &input_path
 
     return "";
 }
+
+static std::string mkdirRecursive(const std::filesystem::path &path)
+{
+    int res;
+    std::filesystem::path subpath = "";
+    for (auto dir : path) {
+        subpath = subpath / dir;
+#ifdef _WIN32
+        res = _access(subpath.string().c_str(), 0) && _mkdir(subpath.string().c_str());
+#else
+        res = access(subpath.string().c_str(), F_OK) && mkdir(subpath.string().c_str(), 0777);
+#endif
+        if (res)
+            return "Failed to create '" + subpath.string() + "': " + std::strerror(errno);
+    }
+    return "";
+}
+
+std::string Config::getDefaultLogFilePath(std::filesystem::path &path)
+{
+    path = "";
+
+#ifdef _WIN32
+    const char *localappdata = std::getenv("LOCALAPPDATA");
+
+    if (localappdata) {
+        path = localappdata;
+    } else {
+        return "%LOCALAPPDATA% not set";
+    }
+#else
+    const char *xdg_state_home = std::getenv("XDG_STATE_HOME");
+
+    if (xdg_state_home) {
+        path = xdg_state_home;
+    } else {
+        path = std::string(std::getenv("HOME")) + "/.local/state";
+    }
+#endif
+
+    path = path / "run-cppcheck";
+
+    const std::string error = mkdirRecursive(path);
+    if (!error.empty())
+        return error;
+
+    path = path / "log.txt";
+
+    return "";
+}

config.h

@@ -9,8 +9,10 @@ class Config {
 public:
     Config()
         : m_projectFilePath("")
-        , m_filename("")
+        , m_logFilePath("")
+        , m_loggingEnabled(true)
         , m_cppcheck("cppcheck")
+        , m_filename("")
         , m_args({})
     {
     }
@@ -28,12 +30,20 @@ class Config {
      * on failure. */
     std::string parseArgs(int argc, char **argv);
 
+    const std::filesystem::path logFilePath() const
+    {
+        return m_logFilePath;
+    }
+
 private:
     static std::filesystem::path findConfig(const std::filesystem::path &input_path);
+    static std::string getDefaultLogFilePath(std::filesystem::path &path);
 
-    std::filesystem::path m_projectFilePath = "";
-    std::filesystem::path m_filename;
+    std::filesystem::path m_projectFilePath;
+    std::filesystem::path m_logFilePath;
+    bool m_loggingEnabled;
     std::string m_cppcheck;
+    std::filesystem::path m_filename;
     std::vector<std::string> m_args;
 };
 

main.cpp

@@ -59,8 +59,6 @@ static int executeCommand(const std::string& cmd, std::string &output)
 
 int main(int argc, char** argv) {
 
-    const std::string log_path = std::filesystem::current_path() / "log.txt";
-    logfile.open(log_path, std::ios_base::app);
 
     Config config;
 
@@ -70,9 +68,15 @@ int main(int argc, char** argv) {
         return EXIT_FAILURE;
     }
 
+    logfile.open(config.logFilePath(), std::ios_base::app);
+    if (logfile.bad()) {
+        std::cerr << "error: Failed to open logfile at '" << config.logFilePath().string() << "'" << std::endl;
+        return EXIT_FAILURE;
+    }
+
     const std::string cmd = config.command();
 
-    logfile << "CMD:" << cmd << std::endl;
+    logfile << "CMD: " << cmd << std::endl;
 
     std::string output;
     int res = executeCommand(cmd, output);