unit testing

Author: devfd

js/geocoder.js

@@ -16,7 +16,7 @@ export default {
     }
 
     return RNGeocoder.geocodePosition(position).catch(err => {
-      if (!this.apiKey) { throw err; }
+      if (!this.apiKey || err.code !== 'NOT_AVAILABLE') { throw err; }
       return GoogleApi.geocodePosition(this.apiKey, position);
     });
   },
@@ -27,7 +27,7 @@ export default {
     }
 
     return RNGeocoder.geocodeAddress(address).catch(err => {
-      if (!this.apiKey) { throw err; }
+      if (!this.apiKey || err.code !== 'NOT_AVAILABLE') { throw err; }
       return GoogleApi.geocodeAddress(this.apiKey, address);
     });
   },

js/googleApi.js

@@ -63,18 +63,18 @@ export default {
       return Promise.reject(new Error("invalid apiKey / position"));
     }
 
-    return this.googleRequest(`${googleUrl}?key=${apiKey}&latlng=${position.lat},${position.lng}`);
+    return this.geocodeRequest(`${googleUrl}?key=${apiKey}&latlng=${position.lat},${position.lng}`);
   },
 
   geocodeAddress(apiKey, address) {
     if (!apiKey || !address) {
       return Promise.reject(new Error("invalid apiKey / address"));
     }
 
-    return this.googleRequest(`${googleUrl}?key=${apiKey}&address=${encodeURI(address)}`);
+    return this.geocodeRequest(`${googleUrl}?key=${apiKey}&address=${encodeURI(address)}`);
   },
 
-  async googleRequest(url) {
+  async geocodeRequest(url) {
     const res = await fetch(url);
     const json = await res.json();
 

package.json

@@ -4,7 +4,7 @@
   "description": "react native geocoding and reverse geocoding",
   "main": "index.js",
   "scripts": {
-    "test": "e2e/run.sh"
+    "test": "mocha --recursive --require test/setup.js --reporter dot test/unit "
   },
   "keywords": [
     "react-component",
@@ -35,6 +35,9 @@
     "chai": "^3.5.0",
     "colors": "^1.1.2",
     "mocha": "^2.4.5",
+    "proxyquire": "^1.7.9",
+    "sinon": "^1.17.4",
+    "sinon-chai": "^2.8.0",
     "wd": "^0.4.0"
   }
 }

test/helpers/funcs.js renamed to test/e2e/helpers/funcs.js

@@ -16,32 +16,54 @@ const Paris = {
   lng: 2.3488,
 };
 
-describe ('react-native-geocoder', function() {
-  this.timeout(600000);
+const sleepBeforeStart = process.env['SAUCE_RUN'] ? 3 * 60 * 1000 : 10 * 1000;
+
+const driverConfig = process.env['SAUCE_RUN'] ?
+  { host: 'ondemand.saucelabs.com', port: 80 } :
+  { host: 'localhost', port: 4723 };
+
+let driverCaps = {
+  platformName: 'Android',
+  deviceName: 'Google Nexus 7C GoogleAPI Emulator',
+  platformVersion: '4.4',
+  newCommandTimeout: 600,
+  commandTimeout: 600,
+  idleTimeout: 1000,
+  app: 'http://localhost:8080/e2e/GeocoderE2EApp/android/app/build/outputs/apk/app-debug.apk',
+  appiumVersion: '1.5.2',
+}
+
+driverCaps = process.env['SAUCE_RUN'] ? driverCaps :
+  {
+    platformName: 'Android',
+    deviceName: 'Android emulator',
+    newCommandTimeout: 600,
+    app: 'http://localhost:8080/e2e/GeocoderE2EApp/android/app/build/outputs/apk/app-debug.apk',
+  };
 
-  const driver = wd.promiseChainRemote({
-    host: 'localhost',
-    port: 4723
-  });
+describe ('react-native-geocoder', function() {
+  this.timeout(60000000);
 
+  const driver = wd.promiseChainRemote(driverConfig);
   require("./helpers/logging").configure(driver);
 
-  before(() => {
-    return driver.init({
-        platformName: 'Android',
-        deviceName: 'Android Emulator',
-        newCommandTimeout: 60000,
-        app: path.resolve('e2e/GeocoderE2EApp/android/app/build/outputs/apk/app-debug.apk')
-      })
-      .setImplicitWaitTimeout(3000);
+  before(async function() {
+    console.log('Init driver');
+    await driver.init(driverCaps);
+
+    console.log('set implicit timeout');
+    await driver.setImplicitWaitTimeout(10000);
+
+    console.log('sleeping ', sleepBeforeStart);
+    await driver.sleep(sleepBeforeStart);
   });
 
   after(async () => {
     await driver.quit();
   });
 
   it ('displays default view', failWithShot(driver, shotDir, async function() {
-    await driver.waitForElementByXPath('//android.widget.EditText[1]', 120000); // wait for view to be initialized
+    await driver.waitForElementByXPath('//android.widget.EditText[1]', 5 * 60 * 1000); // wait for view to be initialized
     await driver.waitForElementByXPath('//android.widget.EditText[2]');
     await driver.waitForElementByXPath('//android.widget.TextView[starts-with(@text, "Geocode")]');
     await driver.waitForElementByXPath('//android.widget.TextView[starts-with(@text, "Reverse")]');

test/helpers/logging.js renamed to test/e2e/helpers/logging.js

@@ -0,0 +1,13 @@
+require('babel-core/register')({
+  presets: ["react-native"]
+});
+require("babel-polyfill");
+
+require('colors');
+
+var chai = require("chai");
+var sinon = require("sinon");
+var sinonChai = require("sinon-chai");
+chai.use(sinonChai);
+
+global.expect = chai.expect;