Run tests as part of the CI build.

Author: sanason

.github/workflows/ci.yml

@@ -3,7 +3,7 @@ on:
   pull_request:
 
 jobs:
-  lint:
+  build:
     runs-on: ubuntu-latest
     steps:
       - name: Code Checkout
@@ -17,3 +17,8 @@ jobs:
         run: npm ci --timing
       - name: Lint javascript
         run: npm run lint
+      - name: Start the test site and run the cucumber tests against it
+        # aa-exec applies Ubuntu's AppArmor profile for stable Chrome binaries to the Chrome for Testing binary downloaded by Puppeteer
+        # Without it, Puppeteer fails with error "No usable sandbox!"
+        # See https://pptr.dev/troubleshooting#issues-with-apparmor-on-ubuntu
+        run: npm run test-site-dev & sleep 20; aa-exec --profile=chrome npm run cucumber

.gitignore

@@ -1 +1,2 @@
-/node_modules
+node_modules
+output

features/README.md

@@ -24,12 +24,20 @@ Then run the tests against the test site:
 npm run cucumber
 ```
 
-## Running the tests with a debugger attached
+### Running the tests with a debugger attached
 
 ```bash
 npm run cucumber:debug
 ```
 
+### Running the tests and generating a nicely formatted test report
+
+```bash
+npm run cucumber:report
+```
+
+Test report should be available in `output/test-results.html`.
+
 ## Configuring with environment variables
 
 ### Verbose mode

package-lock.json

@@ -9,6 +9,7 @@
     "lint": "eslint Universal-Federated-Analytics.js",
     "cucumber": "cucumber-js",
     "cucumber:debug": "VERBOSE=true node --inspect-brk node_modules/@cucumber/cucumber/bin/cucumber-js",
+    "cucumber:report": "cucumber-js --format \"html\":\"output/test-results.html\"",
     "test-site-dev": "docker build --no-cache --build-arg DAP_ENV='dev' -t dap-test-site-dev . && docker run --rm -p 8080:80 --name dap-test-site-dev dap-test-site-dev",
     "test-site-stg": "docker build --no-cache --build-arg DAP_ENV='stg' -t dap-test-site-stg . && docker run --rm -p 8080:80 --name dap-test-site-stg dap-test-site-stg",
     "test-site-prd": "docker build --no-cache --build-arg DAP_ENV='prd' -t dap-test-site-prd . && docker run --rm -p 8080:80 --name dap-test-site-prd dap-test-site-prd"