ci: refactor conditional parts

Author: dkm

.github/workflows/send-emails.yml

@@ -74,20 +74,8 @@ jobs:
 
           echo "SERIES_DIR=/tmp/series" >> $GITHUB_ENV
 
-      - name: Check for label 'no-ml' to skip sending emails
-        id: checklabel
-        run: |
-          # Skip if PR has label "no-ml"
-          if echo "$PR_LABELS" | grep -qiE "(^|,)no-ml(,|$)"; then
-            echo "Opt-out label present: skipping mailing list." | tee $GITHUB_STEP_SUMMARY
-            echo "skip_sending=1" >> $GITHUB_OUTPUT
-          else
-            echo "skip_sending=0" >> $GITHUB_OUTPUT
-          fi
-
       - name: Get commit list from PR and skip the internal ones
         id: commits
-        if: ${{ steps.checklabel.outputs.skip_sending != '1' }}
         run: |
           # Skip commits that touches any of these
           patterns=(".github/"
@@ -120,20 +108,46 @@ jobs:
             echo "has_commits=false" >> $GITHUB_OUTPUT
           else
             COUNT=$(wc -l < /tmp/commits.txt)
+            echo "Adding one commit to the send list"
             echo "COUNT=$COUNT" >> $GITHUB_ENV
             echo "has_commits=true" >> $GITHUB_OUTPUT
           fi
 
       - name: Check what to do based on series' size
         if: steps.commits.outputs.has_commits == 'true'
+        id: count_commits
         run: |
           MAX=150
           if [ "${COUNT}" -gt "$MAX" ]; then
             echo "Series has $COUNT commits (> $MAX). Not doing anything" | tee  $GITHUB_STEP_SUMMARY
+            echo skip=true >> $GITHUB_OUTPUT
+          else
+            echo "Will send the series"
+            echo skip=false >> $GITHUB_OUTPUT
           fi
 
+      - name: Check for label 'no-ml' to skip sending emails
+        id: checklabel
+        run: |
+          # Skip if PR has label "no-ml"
+          if echo "$PR_LABELS" | grep -qiE "(^|,)no-ml(,|$)"; then
+            echo "Opt-out label present: skipping mailing list." | tee $GITHUB_STEP_SUMMARY
+            echo "skip=true" >> $GITHUB_OUTPUT
+          else
+            echo "No opt-out label found"
+            echo "skip=false" >> $GITHUB_OUTPUT
+          fi
+
+      - name: Decide if we're sending something or not
+        id: send_emails
+        if: ( steps.commits.outputs.has_commits == 'true' &&
+          steps.count_commits.outputs.skip == 'false' &&
+          steps.checklabel.outputs.skip == 'false' )
+        run: |
+          echo "enabled=true" >> $GITHUB_OUTPUT
+
       - name: Prepare patch series
-        if: steps.commits.outputs.has_commits == 'true'
+        if: steps.send_emails.outputs.enabled == 'true'
         run: |
           set -euo pipefail
 
@@ -190,7 +204,7 @@ jobs:
           done < <(find /tmp/series/ -maxdepth 1 -type f -print0|sort -z -n)
 
       - name: Send series via git send-email
-        if: steps.commits.outputs.has_commits == 'true'
+        if: steps.send_emails.outputs.enabled == 'true'
         env:
           GIT_SMTP_SERVER: ${{ secrets.SMTP_SERVER }}
           GIT_SMTP_ENCRYPTION: tls