Skip to content

Timezones and Timezone offsets now parse correctly #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2012
Merged

Timezones and Timezone offsets now parse correctly #2

merged 1 commit into from
Jan 11, 2012

Conversation

@erikreedstrom
Copy link

@erikreedstrom erikreedstrom commented Jan 11, 2012

  • fixed timezone implementation for ISO8601 and RFC3339 formats
  • added ability to parse milliseconds in accordance with ISO8601/RFC3339
  • updated toISOString to output 3 digit milliseconds in accordance with RFC3339 format
  • added specs for new functionality

Other changes

  • removed build directory as newer frameworks typically contain asset pipelines and JS uglifiers
  • removed outdated changelist as it is no longer required
  • TODO updated

Timezones and Timezone offsets now parse correctly
9da641e 
- fixed timezone implementation for ISO8601 and RFC3339 formats
- added ability to parse milliseconds in accordance with ISO8601/RFC3339
- updated toISOString to output 3 digit milliseconds in accordance with RFC3339 format
- added specs for new functionality

Other changes
- removed build directory as newer frameworks typically contain asset pipelines and JS uglifiers
- removed outdated changelist as it is no longer required
- TODO updated
@erikreedstrom
Copy link
Author

erikreedstrom commented Jan 11, 2012

I was using rfc3339date.js as an overlay on DateJS, but have decided that I'd had enough of DateJS not parsing timezone/offset data. Full implementation of the standards is not complete, but covers a good 95% of use case scenarios.

@eric
Copy link
Owner

eric commented Jan 11, 2012

This looks great! Thanks!

eric added a commit that referenced this pull request Jan 11, 2012
@eric
Merge pull request #2 from erikreedstrom/next
75fb8e8 
Timezones and Timezone offsets now parse correctly
@eric eric merged commit 75fb8e8 into eric:next Jan 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erikreedstrom @eric