Improve a bit...

Author: gitdode

avr64ea.c

@@ -291,7 +291,6 @@ int main(void) {
     initSPI();
     initEVSYS();
     initInts();
-    initBME68x();
 
     if (USART) {
         printString("Hello AVR64EA!\r\n");
@@ -318,6 +317,12 @@ int main(void) {
         printString("Radio init failed!\r\n");
     }
 
+    int8_t bme688 = initBME68x();
+    if (bme688 < 0 && USART) {
+        printString("BME688 init failed!\r\n");
+        printInt(bme688);
+    }
+
     // enable global interrupts
     sei();
 

bme688.c

@@ -10,11 +10,11 @@
 #include "bme688.h"
 
 /**
- * Writes given data to given register(s).
+ * Writes given register - data pairs to respective register(s).
  *
  * @param reg register of first register - data pair
  * @param data array with data of first register - data pair as first element,
- *   with remaining register - data pair following
+ *   with remaining register - data pairs following
  * @param len (number of register - data pairs) - 1
  * @param intfPtr
  * @return success
@@ -28,15 +28,15 @@ static BME68X_INTF_RET_TYPE bme68xWrite(uint8_t reg,
     for (uint32_t i = 0; i < len; i++) {
         transmit(data[i]);
     }
-
     PORTC_OUTSET = (1 << PD2);
 
     // TODO
     return 0;
 }
 
 /**
- * Reads given data starting with given register auto-incrementing.
+ * Reads from register(s) into given data array starting with
+ * given register auto-incrementing.
  *
  * @param reg start register
  * @param data array with data to be read from consecutive registers
@@ -70,67 +70,64 @@ static void bme68xDelayUs(uint32_t period, void *intfPtr) {
     _delay_us(period);
 }
 
-/**
- * Initializes the BME68x to use SPI interface.
- *
- * @param bme bme68x device descriptor
- * @param pin SPI chip select pin
- * @return success
- */
-uint8_t initBME68xIntf(struct bme68x_dev *bme, uint8_t pin) {
-    bme->intf = BME68X_SPI_INTF;
-    bme->write = bme68xWrite;
-    bme->read = bme68xRead;
-    bme->delay_us = bme68xDelayUs;
-    bme->intf_ptr = &pin;
-    bme->amb_temp = 20;
-
-    return 0;
-}
-
-void initBME68x() {
-    struct bme68x_dev bme;
+int8_t initBME68x() {
+    struct bme68x_dev dev;
     struct bme68x_conf conf;
     struct bme68x_heatr_conf heater_conf;
     struct bme68x_data data;
     int8_t result;
 
-    result = initBME68xIntf(&bme, PD2); // FIXME pin not used
-    // TODO check result
-    printInt(result);
+    uint8_t pin = PD2;
+
+    dev.intf = BME68X_SPI_INTF;
+    dev.write = bme68xWrite;
+    dev.read = bme68xRead;
+    dev.delay_us = bme68xDelayUs;
+    dev.intf_ptr = &pin; // TODO not used
+    dev.amb_temp = 20; // could use temp measured with thermistor ;-)
 
-    result = bme68x_init(&bme);
-    // TODO check result
-    printInt(result);
+    result = bme68x_init(&dev);
+    // TODO properly check result
+    if (result < 0) {
+        return result;
+    }
 
     conf.filter = BME68X_FILTER_OFF;
     conf.odr = BME68X_ODR_NONE;
     conf.os_hum = BME68X_OS_8X;
     conf.os_pres = BME68X_OS_8X;
     conf.os_temp = BME68X_OS_8X;
-    result = bme68x_set_conf(&conf, &bme);
-    // TODO check result
-    printInt(result);
+    result = bme68x_set_conf(&conf, &dev);
+    // TODO properly check result
+    if (result < 0) {
+        return result;
+    }
 
     heater_conf.enable = BME68X_ENABLE;
     heater_conf.heatr_temp = 300;
     heater_conf.heatr_dur = 100;
-    result = bme68x_set_heatr_conf(BME68X_FORCED_MODE, &heater_conf, &bme);
-    // TODO check result
-    printInt(result);
+    result = bme68x_set_heatr_conf(BME68X_FORCED_MODE, &heater_conf, &dev);
+    // TODO properly check result
+    if (result < 0) {
+        return result;
+    }
 
-    result = bme68x_set_op_mode(BME68X_FORCED_MODE, &bme);
-    // TODO check result
-    printInt(result);
+    result = bme68x_set_op_mode(BME68X_FORCED_MODE, &dev);
+    // TODO properly check result
+    if (result < 0) {
+        return result;
+    }
 
-    uint32_t meas_dur = bme68x_get_meas_dur(BME68X_FORCED_MODE, &conf, &bme) +
+    uint32_t meas_dur = bme68x_get_meas_dur(BME68X_FORCED_MODE, &conf, &dev) +
             (heater_conf.heatr_dur * 1000);
-    bme.delay_us(meas_dur, bme.intf_ptr);
+    dev.delay_us(meas_dur, dev.intf_ptr);
 
     uint8_t n_data;
-    result = bme68x_get_data(BME68X_FORCED_MODE, &data, &n_data, &bme);
-    // TODO check result
-    printInt(result);
+    result = bme68x_get_data(BME68X_FORCED_MODE, &data, &n_data, &dev);
+    // TODO properly check result
+    if (result < 0) {
+        return result;
+    }
 
     div_t tdiv = div(data.temperature, 100);
 
@@ -142,4 +139,6 @@ void initBME68x() {
             (uint32_t)data.gas_resistance,
             data.status);
     printString(buf);
+
+    return true;
 }

bme688.h

@@ -1,8 +1,6 @@
 /* 
  * File:   bme688.h
  * Author: [email protected]
- * 
- * Thanks to https://github.com/boschsensortec/BME68x_SensorAPI/tree/master/examples
  *
  * Created on 4. Oktober 2025, 20:31
  */
@@ -22,11 +20,11 @@
 #include "bme68x/bme68x.h"
 
 /**
- * Initializes the BME68x sensor using the given pin for SPI chip select.
+ * Initializes the BME68x sensor.
  * 
- * @param pin SPI chip select pin
+ * @return error code
  */
-void initBME68x(void);
+int8_t initBME68x(void);
 
 #undef __DELAY_BACKWARD_COMPATIBLE__