Merge pull request #1316 from gradle/eskatos/precompiled/clean-stale-output

Let GenerateScriptPluginAdapters task clean stale outputs

Author: bamboo

subprojects/integ-tests/src/test/kotlin/org/gradle/kotlin/dsl/integration/PrecompiledScriptPluginIntegrationTest.kt

@@ -8,7 +8,9 @@ import org.gradle.kotlin.dsl.fixtures.gradleRunnerFor
 import org.gradle.kotlin.dsl.fixtures.normalisedPath
 
 import org.hamcrest.CoreMatchers.equalTo
+import org.junit.Assert.assertFalse
 import org.junit.Assert.assertThat
+import org.junit.Assert.assertTrue
 import org.junit.Test
 
 
@@ -78,4 +80,25 @@ class PrecompiledScriptPluginIntegrationTest : AbstractPluginIntegrationTest() {
             assertThat(outcomeOf(generationTask), equalTo(FROM_CACHE))
         }
     }
+
+    @Test
+    fun `precompiled script plugins adapters generation clean stale outputs`() {
+
+        withDefaultSettings()
+        withBuildScript("""
+            plugins { `kotlin-dsl` }
+            repositories { jcenter() }
+        """)
+
+        val fooScript = withFile("src/main/kotlin/foo.gradle.kts", "")
+
+        build("generateScriptPluginAdapters")
+        assertTrue(existing("build/generated-sources/kotlin-dsl-plugins/kotlin/FooPlugin.kt").isFile)
+
+        fooScript.renameTo(fooScript.parentFile.resolve("bar.gradle.kts"))
+
+        build("generateScriptPluginAdapters")
+        assertFalse(existing("build/generated-sources/kotlin-dsl-plugins/kotlin/FooPlugin.kt").exists())
+        assertTrue(existing("build/generated-sources/kotlin-dsl-plugins/kotlin/BarPlugin.kt").isFile)
+    }
 }

subprojects/plugins/src/main/kotlin/org/gradle/kotlin/dsl/plugins/precompiled/GenerateScriptPluginAdapters.kt

@@ -52,6 +52,7 @@ open class GenerateScriptPluginAdapters : DefaultTask() {
     internal
     fun generate() =
         outputDirectory.asFile.get().let { outputDir ->
+            outputDir.deleteRecursively()
             outputDir.mkdirs()
             for (scriptPlugin in plugins) {
                 scriptPlugin.writeScriptPluginAdapterTo(outputDir)