More test coverage for the JavaModuleDependenciesBridge

Author: jjohannes

src/test/groovy/org/gradlex/javamodule/testing/test/CustomizationTest.groovy

@@ -53,27 +53,4 @@ class CustomizationTest extends Specification {
         then:
         result.task(":app:test").outcome == TaskOutcome.SUCCESS
     }
-
-    def "repetitive blackbox calls on the same test suite have no effect"() {
-        given:
-        appBuildFile << '''
-            javaModuleTesting.blackbox(testing.suites["test"])
-            javaModuleTesting.blackbox(testing.suites["test"])
-        '''
-        appModuleInfoFile << '''
-            module org.gradlex.test.app { 
-            }
-        '''
-        appTestModuleInfoFile << '''
-            module org.gradlex.test.app.test { 
-                requires org.junit.jupiter.api;
-            }
-        '''
-
-        when:
-        def result = runTests()
-
-        then:
-        result.task(":app:test").outcome == TaskOutcome.SUCCESS
-    }
 }

src/test/groovy/org/gradlex/javamodule/testing/test/JavaModuleDependenciesBridgeTest.groovy

@@ -0,0 +1,69 @@
+package org.gradlex.javamodule.testing.test
+
+import org.gradle.testkit.runner.TaskOutcome
+import org.gradlex.javamodule.testing.test.fixture.GradleBuild
+import spock.lang.Ignore
+import spock.lang.Specification
+
+class JavaModuleDependenciesBridgeTest extends Specification {
+
+    @Delegate
+    GradleBuild build = new GradleBuild()
+
+    def "respects moduleNameToGA mappings"() {
+        given:
+        appBuildFile << '''
+            javaModuleDependencies {
+                moduleNameToGA.put("com.example.lib", "com.example:lib")
+            }
+            javaModuleTesting.whitebox(testing.suites["test"]) {
+                requires.add("org.junit.jupiter.api")
+                requires.add("com.example.lib")
+                opensTo.add("org.junit.platform.commons")
+            }
+        '''
+        appModuleInfoFile << '''
+            module com.example.app { 
+            }
+        '''
+        libModuleInfoFile << '''
+            module com.example.lib { 
+            }
+        '''
+
+        when:
+        def result = runTests()
+
+        then:
+        result.task(":app:test").outcome == TaskOutcome.SUCCESS
+    }
+
+    @Ignore // See: https://github.com/gradlex-org/java-module-testing/issues/3
+    def "respects moduleNamePrefixToGroup mappings"() {
+        given:
+        appBuildFile << '''
+            javaModuleDependencies {
+                moduleNamePrefixToGroup.put("com.example.", "com.example")
+            }
+            javaModuleTesting.whitebox(testing.suites["test"]) {
+                requires.add("org.junit.jupiter.api")
+                requires.add("com.example.lib")
+                opensTo.add("org.junit.platform.commons")
+            }
+        '''
+        appModuleInfoFile << '''
+            module com.example.app { 
+            }
+        '''
+        libModuleInfoFile << '''
+            module com.example.lib { 
+            }
+        '''
+
+        when:
+        def result = runTests()
+
+        then:
+        result.task(":app:test").outcome == TaskOutcome.SUCCESS
+    }
+}

src/test/groovy/org/gradlex/javamodule/testing/test/fixture/GradleBuild.groovy

@@ -13,6 +13,8 @@ class GradleBuild {
     final File appBuildFile
     final File appModuleInfoFile
     final File appTestModuleInfoFile
+    final File libBuildFile
+    final File libModuleInfoFile
 
     final String gradleVersionUnderTest = System.getProperty("gradleVersionUnderTest")
 
@@ -22,33 +24,33 @@ class GradleBuild {
         this.appBuildFile = file("app/build.gradle.kts")
         this.appModuleInfoFile = file("app/src/main/java/module-info.java")
         this.appTestModuleInfoFile = file("app/src/test/java/module-info.java")
+        this.libBuildFile = file("lib/build.gradle.kts")
+        this.libModuleInfoFile = file("lib/src/main/java/module-info.java")
 
         settingsFile << '''
+            pluginManagement {
+                plugins { id("org.gradlex.java-module-dependencies") version "1.0" }
+            }
             dependencyResolutionManagement { repositories.mavenCentral() }
+            includeBuild(".")
             rootProject.name = "test-project"
-            include("app")
+            include("app", "lib")
         '''
         appBuildFile << '''
             plugins {
-                id("org.gradlex.java-module-dependencies") version "1.0"
+                id("org.gradlex.java-module-dependencies")
                 id("org.gradlex.java-module-testing")
                 id("application")
             }
+            group = "com.example"
             dependencies {
                 testImplementation(platform("org.junit:junit-bom:5.9.0"))
             }
             application {
                 mainModule.set("org.gradlex.test.app")
                 mainClass.set("org.gradlex.test.app.Main")
             }
-            tasks.register("printRuntimeJars") {
-                doLast { println(configurations.runtimeClasspath.get().files.map { it.name }) }
-            }
-            tasks.register("printCompileJars") {
-                doLast { println(configurations.compileClasspath.get().files.map { it.name }) }
-            }
         '''
-
         file("app/src/test/java/com/example/AppTest.java") << '''
             package com.example;
             
@@ -61,6 +63,15 @@ class GradleBuild {
                 }
             }
         '''
+
+        libBuildFile << '''
+            plugins {
+                id("org.gradlex.java-module-dependencies")
+                id("org.gradlex.java-module-testing")
+                id("java-library")
+            }
+            group = "com.example"
+        '''
     }
 
     File file(String path) {