From 1210d2336ea0eff8886aaf5e72916e8e2ecbf6e0 Mon Sep 17 00:00:00 2001 From: Alan deLevie Date: Sat, 14 Jun 2014 14:12:34 -0400 Subject: [PATCH 1/3] upgrade to latest rspec gems --- rails_nlp.gemspec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rails_nlp.gemspec b/rails_nlp.gemspec index 120131a..c95e439 100644 --- a/rails_nlp.gemspec +++ b/rails_nlp.gemspec @@ -19,10 +19,10 @@ Gem::Specification.new do |spec| spec.add_development_dependency "bundler", "~> 1.6" spec.add_development_dependency "rake" - spec.add_development_dependency "rspec-rails", '~> 2.14.1' + spec.add_development_dependency "rspec-rails", '~> 3.0.1' spec.add_development_dependency "factory_girl_rails", "~> 4.0" spec.add_development_dependency "guard", "~> 2.6" - spec.add_development_dependency "guard-rspec", "~> 4.2.8" + spec.add_development_dependency "guard-rspec", "~> 4.2.10" spec.add_development_dependency "flexmock", "~> 1.3.1" spec.add_development_dependency "shoulda-matchers", "~> 2.6.0" spec.add_development_dependency "codeclimate-test-reporter" From 5afb20c0b63fc2eb5fae6ec0acb3025570896d40 Mon Sep 17 00:00:00 2001 From: Alan deLevie Date: Sat, 14 Jun 2014 14:12:51 -0400 Subject: [PATCH 2/3] stop using deprecated color_enabled in spec_helper --- spec/spec_helper.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index fa0fca7..e43bbff 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -10,7 +10,6 @@ RSpec.configure do |config| config.order = "random" - config.color_enabled = true config.tty = true config.mock_with :flexmock config.include FactoryGirl::Syntax::Methods From 03b0a2cdd925eb6210117d7e046abebc6d1e14d3 Mon Sep 17 00:00:00 2001 From: Alan deLevie Date: Sat, 14 Jun 2014 14:14:04 -0400 Subject: [PATCH 3/3] Convert specs to RSpec 3.0.1 syntax with Transpec This conversion is done by Transpec 2.2.4 with the following command: transpec * 3 conversions from: it { should ... } to: it { is_expected.to ... } For more details: https://github.com/yujinakayama/transpec#supported-conversions --- spec/rails_nlp/keyword_spec.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spec/rails_nlp/keyword_spec.rb b/spec/rails_nlp/keyword_spec.rb index 6d226fd..2736991 100644 --- a/spec/rails_nlp/keyword_spec.rb +++ b/spec/rails_nlp/keyword_spec.rb @@ -2,9 +2,9 @@ module RailsNlp describe Keyword do - it { should validate_presence_of(:name)} - it { should validate_uniqueness_of(:name)} - it { should have_many(:wordcounts) } + it { is_expected.to validate_presence_of(:name)} + it { is_expected.to validate_uniqueness_of(:name)} + it { is_expected.to have_many(:wordcounts) } describe "analysis of keywords before save" do describe "phonetic" do