Skip to content

Conversation

@Surabhi-1605
Copy link

@Surabhi-1605 Surabhi-1605 commented Oct 22, 2025

Fixes Terraform version compatibility issues in EKS acceptance tests:

  • Updated AWS provider from >= 4.0.0to ~> 5.0
  • Updated VPC module from 4.0.0 to 5.0.0
  • Removed assume_role block to eliminate warnings
  • Resolves vpc = true EIP compatibility error

Fixes: EKS acceptance test failures due to Terraform version incompatibility

@Surabhi-1605 Surabhi-1605 requested a review from a team as a code owner October 22, 2025 11:54
@hashicorp-cla-app
Copy link

hashicorp-cla-app bot commented Oct 22, 2025

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • Surabhi-1605
  • Surabhi Singh

Surabhi Singh seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@hashicorp-cla-app
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Surabhi Singh seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@vdinesh4738
Copy link
Contributor

Please update the branch, add change logger and set backport label

@Surabhi-1605 Surabhi-1605 added the pr/no-backport signals that a PR will not contain a backport label label Oct 23, 2025
Surabhi Singh and others added 6 commits October 23, 2025 12:41
- Updated branch as requested by reviewers
- All conflicts resolved
- Ready for changelog and backport labels
- Fixed AWS provider version constraint from invalid '~>= 6.4.1' to '~> 5.0'
- Updated VPC module version from '4.0.0' to '5.0.0'
- Resolves EKS acceptance test compatibility issues
@Surabhi-1605 Surabhi-1605 added backport/1.8.x Backport to release/1.8.x branch backport/1.7.x Backport to release/1.7.x branch labels Oct 23, 2025
- CLA has been signed
- Re-running checks to update status
- Restored assume_role configuration for proper IAM role assumption
- This is required for HashiCorp's GitHub Actions OIDC workflow
- Maintains security best practices with temporary credentials
- Use dynamic block to only assume role when role_arn is provided
- Allows local development without role_arn variable
- Maintains CI/CD compatibility when role_arn is set
- Fixes 'Missing required argument' error for local testing
- Run terraform fmt to fix formatting issues
- Resolves Terraform fmt check failure in CI
- Enable IPv6 on VPC to support dual-stack networking tests
- Configure IPv6 prefixes for public and private subnets
- Fixes acceptance-dual-stack test failures introduced in PR #4895
- Required for dual-stack testing enabled on Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.7.x Backport to release/1.7.x branch backport/1.8.x Backport to release/1.8.x branch pr/no-backport signals that a PR will not contain a backport label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants