From 4633e251cac7d5e012f493ec3169db7735a4e98a Mon Sep 17 00:00:00 2001 From: Kristin Bradley Date: Tue, 28 Oct 2025 16:42:05 -0700 Subject: [PATCH 01/14] HDS-5572 Fix inheritance of color styles for Buttons witin Modals triggered from within the SideNav or AppHeader --- .changeset/fine-rocks-trade.md | 5 +++ .../src/styles/components/app-header.scss | 7 +++- .../styles/components/side-nav/header.scss | 7 +++- .../components/mock/app/sidebar/side-nav.gts | 34 +++++++++++++++++++ 4 files changed, 51 insertions(+), 2 deletions(-) create mode 100644 .changeset/fine-rocks-trade.md diff --git a/.changeset/fine-rocks-trade.md b/.changeset/fine-rocks-trade.md new file mode 100644 index 00000000000..1fe8547a316 --- /dev/null +++ b/.changeset/fine-rocks-trade.md @@ -0,0 +1,5 @@ +--- +"@hashicorp/design-system-components": patch +--- + +`Button` - Fixed color inheritance for Buttons within a `Modal` triggered from either the `SideNav` or `AppHeader` diff --git a/packages/components/src/styles/components/app-header.scss b/packages/components/src/styles/components/app-header.scss index 46167a0f7ae..afe1404bea7 100644 --- a/packages/components/src/styles/components/app-header.scss +++ b/packages/components/src/styles/components/app-header.scss @@ -110,7 +110,12 @@ .hds-dropdown-toggle-button, .hds-dropdown-toggle-icon { // Apply dark theme to child interactive components not within a nested dropdown - &:not(.hds-dropdown * *, .ember-basic-dropdown-trigger * *, .ember-basic-dropdown-content * *) { + &:not( + .hds-dropdown * *, + .ember-basic-dropdown-trigger * *, + .ember-basic-dropdown-content * *, + .hds-dialog-primitive__wrapper * + ) { @include hds-interactive-dark-theme(); // disabled state: diff --git a/packages/components/src/styles/components/side-nav/header.scss b/packages/components/src/styles/components/side-nav/header.scss index e79eb3d3add..4b02de0cf59 100644 --- a/packages/components/src/styles/components/side-nav/header.scss +++ b/packages/components/src/styles/components/side-nav/header.scss @@ -76,7 +76,12 @@ .hds-dropdown-toggle-button, .hds-dropdown-toggle-icon { // Apply dark theme to child interactive components not within a nested dropdown - &:not(.hds-dropdown * *, .ember-basic-dropdown-trigger * *, .ember-basic-dropdown-content * *) { + &:not( + .hds-dropdown * *, + .ember-basic-dropdown-trigger * *, + .ember-basic-dropdown-content * *, + .hds-dialog-primitive__wrapper * + ) { @include hds-interactive-dark-theme(); // disabled state: diff --git a/showcase/app/components/mock/app/sidebar/side-nav.gts b/showcase/app/components/mock/app/sidebar/side-nav.gts index c5f61f41237..cf0793e5295 100644 --- a/showcase/app/components/mock/app/sidebar/side-nav.gts +++ b/showcase/app/components/mock/app/sidebar/side-nav.gts @@ -13,8 +13,12 @@ import { HdsSideNavList, HdsButton, HdsDropdown, + HdsButtonSet, } from '@hashicorp/design-system-components/components'; +import ModalWithTrigger from '../../../page-components/modal/code-fragments/with-trigger'; +import { on } from '@ember/modifier'; + // types import type { HdsSideNavSignature } from '@hashicorp/design-system-components/components/hds/side-nav/index'; import type Owner from '@ember/owner'; @@ -152,8 +156,38 @@ export default class MockAppSidebarOldSideNav extends Component + + + <:modal as |M|> + + Modal title + + +

+ Modal content +

+
+ + + + + + + +
+
+ <:footer> {{#if this.showFooter}} Date: Tue, 28 Oct 2025 16:48:09 -0700 Subject: [PATCH 02/14] Fix color inheritance for Buttons in Modal --- .changeset/fine-rocks-trade.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.changeset/fine-rocks-trade.md b/.changeset/fine-rocks-trade.md index 1fe8547a316..e858a37cd63 100644 --- a/.changeset/fine-rocks-trade.md +++ b/.changeset/fine-rocks-trade.md @@ -2,4 +2,6 @@ "@hashicorp/design-system-components": patch --- -`Button` - Fixed color inheritance for Buttons within a `Modal` triggered from either the `SideNav` or `AppHeader` + +`Button` - Fixed color inheritance for Buttons within a `Modal` which is triggered from either the `SideNav` or `AppHeader` + From 8518743141d2f76edcca1a861e2ddeb6dea4deea Mon Sep 17 00:00:00 2001 From: Kristin Bradley Date: Tue, 28 Oct 2025 16:48:44 -0700 Subject: [PATCH 03/14] Update showcase/app/components/mock/app/sidebar/side-nav.gts --- showcase/app/components/mock/app/sidebar/side-nav.gts | 1 - 1 file changed, 1 deletion(-) diff --git a/showcase/app/components/mock/app/sidebar/side-nav.gts b/showcase/app/components/mock/app/sidebar/side-nav.gts index cf0793e5295..4eb88f0c893 100644 --- a/showcase/app/components/mock/app/sidebar/side-nav.gts +++ b/showcase/app/components/mock/app/sidebar/side-nav.gts @@ -187,7 +187,6 @@ export default class MockAppSidebarOldSideNav extends Component - <:footer> {{#if this.showFooter}} Date: Wed, 29 Oct 2025 11:36:23 -0700 Subject: [PATCH 04/14] HDS-5572 Remove Modal example from AppFrame demo, add nested Button content examples to SideNav Showcase --- .../components/mock/app/sidebar/side-nav.gts | 33 ---- .../side-nav/sub-sections/content.gts | 183 ++++++++++++++++++ 2 files changed, 183 insertions(+), 33 deletions(-) diff --git a/showcase/app/components/mock/app/sidebar/side-nav.gts b/showcase/app/components/mock/app/sidebar/side-nav.gts index 4eb88f0c893..c5f61f41237 100644 --- a/showcase/app/components/mock/app/sidebar/side-nav.gts +++ b/showcase/app/components/mock/app/sidebar/side-nav.gts @@ -13,12 +13,8 @@ import { HdsSideNavList, HdsButton, HdsDropdown, - HdsButtonSet, } from '@hashicorp/design-system-components/components'; -import ModalWithTrigger from '../../../page-components/modal/code-fragments/with-trigger'; -import { on } from '@ember/modifier'; - // types import type { HdsSideNavSignature } from '@hashicorp/design-system-components/components/hds/side-nav/index'; import type Owner from '@ember/owner'; @@ -156,35 +152,6 @@ export default class MockAppSidebarOldSideNav extends Component - - - <:modal as |M|> - - Modal title - - -

- Modal content -

-
- - - - - - - -
-
<:footer> diff --git a/showcase/app/components/page-components/side-nav/sub-sections/content.gts b/showcase/app/components/page-components/side-nav/sub-sections/content.gts index 11f6f5c7c8c..0b8b411d38b 100644 --- a/showcase/app/components/page-components/side-nav/sub-sections/content.gts +++ b/showcase/app/components/page-components/side-nav/sub-sections/content.gts @@ -12,10 +12,22 @@ import ShwTextH3 from 'showcase/components/shw/text/h3'; import { HdsSideNav, + HdsSideNavHeader, + HdsSideNavHeaderHomeLink, HdsSideNavPortal, HdsSideNavPortalTarget, + HdsSideNavList, + HdsButton, + HdsButtonSet, + HdsDropdown, } from '@hashicorp/design-system-components/components'; +import ModalWithTrigger from '../../../page-components/modal/code-fragments/with-trigger'; +import SuperSelectWithButtons from 'showcase/components/page-components/form/super-select/code-fragments/with-multiple-base-element'; +import FlyoutWithTrigger from 'showcase/components/page-components/flyout/code-fragments/with-trigger'; + +import { on } from '@ember/modifier'; + const SubSectionContent: TemplateOnlyComponent =